Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp999003ybt; Fri, 19 Jun 2020 21:06:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzEj/rMvt1iTW4s5K0qqtZ7l01zlnwfPOf3Tc7OWZA+k9ej9Xw6WkhSsm3ooJxL7rOP96w3 X-Received: by 2002:a05:6402:1a48:: with SMTP id bf8mr6580355edb.133.1592625988108; Fri, 19 Jun 2020 21:06:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592625988; cv=none; d=google.com; s=arc-20160816; b=WxdDBNvgb601nuk8Cc+OijEbZU9FWHYsWUibyFUTdoX81LZPtXlWv8Q70hIlvwq0VI CiyQIsubhVLky4umjy2xCXyJhGt9HFpuKcRReUAGcb3JAnhPf8BQwnpxyVhVFj2gUXwy uHCBH3SOvGndOO7u6pz6pDbp4pslW84sk4ZY/ap2mlSXs89Ei2EJUlgMoQ+o3olG9HsF IhYdOj72wRKJGsUv3PmbSd/8eKf5Y/vr2NlRAVVWc9TIrOjem8fras6W1kWKECTVf6sL zMgT3+ZmtddEa7n1KvCVehBDJkvtRM5aqFtOlT79fiWSc7VbepkylzzCYXD+lfIhZU6y KOgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fwGjUWsntCOll67b/gc9EQu/D/ouX/aF2K5XEMWsgDI=; b=I9FuhP/K5/uJQEB6wqVxg6dbDtr/Zkv7u6N/vM0sN6WnNuJUJ7GBo8BBaC351Y4As/ jzuAOyeUt+oZw4WtNcKoHrpVEI6pigeg7hJ19j8BQKDT1hjlXNsqtk2Ks3DT0vm4iI7B zBHjGN9hZ/xXOA3Pc2e2TCHsUdCweE23EHWSfnfaEU40ayXt961wWK+R1+COgA5zyFuO sZeDE7c084ZVkpzoEVDAnrFNpbqX5v8V1qUS7OpFtX8B0OJSoroGtTiIvZYYDHSY2eEI 7q7npZOfSRw83zHn7as/uZz9NWKzFIni8hRfsOMGuB1uyh4Ta7+Yo3xT+rS0vgnLZ3pE Ljzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LSsDTDBE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i23si5672645edj.3.2020.06.19.21.06.06; Fri, 19 Jun 2020 21:06:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LSsDTDBE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395179AbgFSQmW (ORCPT + 99 others); Fri, 19 Jun 2020 12:42:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:35782 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388575AbgFSOob (ORCPT ); Fri, 19 Jun 2020 10:44:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B99221582; Fri, 19 Jun 2020 14:44:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592577871; bh=YGuNbxnOFdGZn9xhW1g0YbhvMFNUM6o6VtQi5BCwJ9E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LSsDTDBET3liFYEMD199Nm3AKO5cSwOUJYmtQB8gp/rWAMRfpFM8gHzkClKYty+Da ZXkKGgGbEZXB7H2vc6xJydCywYfC5PLk3y27THT/K5wZGh4GwGIwGgP7wJ9GWF9r7e C2FX26xZgPoJhl0mJNfhCJXCwH7gkSuNaQLoS0RQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Xie XiuQi , Andrew Bowers , Jeff Kirsher , Sasha Levin Subject: [PATCH 4.9 093/128] ixgbe: fix signed-integer-overflow warning Date: Fri, 19 Jun 2020 16:33:07 +0200 Message-Id: <20200619141625.060048318@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141620.148019466@linuxfoundation.org> References: <20200619141620.148019466@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xie XiuQi [ Upstream commit 3b70683fc4d68f5d915d9dc7e5ba72c732c7315c ] ubsan report this warning, fix it by adding a unsigned suffix. UBSAN: signed-integer-overflow in drivers/net/ethernet/intel/ixgbe/ixgbe_common.c:2246:26 65535 * 65537 cannot be represented in type 'int' CPU: 21 PID: 7 Comm: kworker/u256:0 Not tainted 5.7.0-rc3-debug+ #39 Hardware name: Huawei TaiShan 2280 V2/BC82AMDC, BIOS 2280-V2 03/27/2020 Workqueue: ixgbe ixgbe_service_task [ixgbe] Call trace: dump_backtrace+0x0/0x3f0 show_stack+0x28/0x38 dump_stack+0x154/0x1e4 ubsan_epilogue+0x18/0x60 handle_overflow+0xf8/0x148 __ubsan_handle_mul_overflow+0x34/0x48 ixgbe_fc_enable_generic+0x4d0/0x590 [ixgbe] ixgbe_service_task+0xc20/0x1f78 [ixgbe] process_one_work+0x8f0/0xf18 worker_thread+0x430/0x6d0 kthread+0x218/0x238 ret_from_fork+0x10/0x18 Reported-by: Hulk Robot Signed-off-by: Xie XiuQi Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c index 0d2baec546e1..c17135b7fca7 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c @@ -2219,7 +2219,7 @@ s32 ixgbe_fc_enable_generic(struct ixgbe_hw *hw) } /* Configure pause time (2 TCs per register) */ - reg = hw->fc.pause_time * 0x00010001; + reg = hw->fc.pause_time * 0x00010001U; for (i = 0; i < (MAX_TRAFFIC_CLASS / 2); i++) IXGBE_WRITE_REG(hw, IXGBE_FCTTV(i), reg); -- 2.25.1