Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1002325ybt; Fri, 19 Jun 2020 21:13:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjFSsR6E7+iRK6IrDGs94sJFUN4I2ABeYDpENpo1/UkUhk4qbVOm0yn9U7Rs+tA/AeJIzr X-Received: by 2002:a50:ee04:: with SMTP id g4mr6353392eds.119.1592626431244; Fri, 19 Jun 2020 21:13:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592626431; cv=none; d=google.com; s=arc-20160816; b=UWPn+8zOpkDpfogB47XZjtf4AuwosTXBEelNnqzl4tUGOpOxY4GQnESw5F1PPd03nW RDL5f2apgqcK6P0RvpEv/B63D7pCoiQBcJUMxASJYX8QgnlKzoh8X5xSJksKWMx2PXn1 fh/EYUPNVX87BYinHH9Id92MsfBrzA7t/AQzszuPqXjSVs/WSkV32hKsU99f94k8T5Ql Zq2qfGorsAG+eJj24aHd+1jNGdBNbfJQe5p7m2+EPA6U1XySaAffLQ/+mSet45l4d9Qj CBtkecMGakdc3mbsSSEBoHRk8ign317oo9P327+f9rQ9mTt6zoiLgr/fP861Af2kHyjC KmOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:to:subject:dkim-signature; bh=4GUluXhPQYRHL0WKaQGOjQp7SkcDMonDRoNlnFMC1Vg=; b=p2xkzWItnZg4W+9BrMaolzcFMD7OmDauVDMtms+OZSNLg0mdemp/AcHgPRwzlzkW5S Bl45g/FbdbnZJHjnelz4xF+nsZ7HXAWz/Xl50f6idMFS5YkoPSgdGNhuDINfoTwjt7CT ViDvKvbvWB+Do6blRugU7R6d86Kfy/q7JtyAMSp3MHSx4bpqbRijWaVksM7+EUSQ4G9d cN+yVel/yaBpMG4VrfmfUwArawoawn75sVfF5fF7x1TT2WVJqeJUWHEWWwSEFFvKIrkt H/+/IBUU0p7RSfBKCRguI/nAlu+UYjdASoiue4WoGTnA6ynzTY+81fP86LAxfc23fGZ/ +iAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=d78wgNJs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z3si5173713eja.429.2020.06.19.21.13.29; Fri, 19 Jun 2020 21:13:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=d78wgNJs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732018AbgFSRRE (ORCPT + 99 others); Fri, 19 Jun 2020 13:17:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:49958 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729842AbgFSRRC (ORCPT ); Fri, 19 Jun 2020 13:17:02 -0400 Received: from [192.168.1.74] (75-58-59-55.lightspeed.rlghnc.sbcglobal.net [75.58.59.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5ED0120DD4; Fri, 19 Jun 2020 17:17:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592587022; bh=ZXqvXAmVATfcOFfYDgssdi24IIgo7rfGyS4R1yKWIB0=; h=Subject:To:References:From:Date:In-Reply-To:From; b=d78wgNJsoEVyI8veX7Z8JHTuu5+qT47of6JK7UQwqdGNtgoorNO6t9sgsZ45aMfcW cLArwSQOeEaOU4+uXfwiliUP97QcEIZ90wvmEEJGAZ9bRSDY1+ixU48ZkayuafuX04 5vQyqOmXeLNuNALDkTVsl1UeclqvlEaztkvdql7k= Subject: Re: [PATCH] pci: pcie: AER: Fix logging of Correctable errors To: Matt Jolly , Russell Currey , Sam Bobroff , Oliver O'Halloran , Bjorn Helgaas , linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200618155511.16009-1-Kangie@footclan.ninja> From: Sinan Kaya Autocrypt: addr=okaya@kernel.org; keydata= mQENBFrnOrUBCADGOL0kF21B6ogpOkuYvz6bUjO7NU99PKhXx1MfK/AzK+SFgxJF7dMluoF6 uT47bU7zb7HqACH6itTgSSiJeSoq86jYoq5s4JOyaj0/18Hf3/YBah7AOuwk6LtV3EftQIhw 9vXqCnBwP/nID6PQ685zl3vH68yzF6FVNwbDagxUz/gMiQh7scHvVCjiqkJ+qu/36JgtTYYw 8lGWRcto6gr0eTF8Wd8f81wspmUHGsFdN/xPsZPKMw6/on9oOj3AidcR3P9EdLY4qQyjvcNC V9cL9b5I/Ud9ghPwW4QkM7uhYqQDyh3SwgEFudc+/RsDuxjVlg9CFnGhS0nPXR89SaQZABEB AAG0HVNpbmFuIEtheWEgPG9rYXlhQGtlcm5lbC5vcmc+iQFOBBMBCAA4FiEEYdOlMSE+a7/c ckrQvGF4I+4LAFcFAlztcAoCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQvGF4I+4L AFfidAf/VKHInxep0Z96iYkIq42432HTZUrxNzG9IWk4HN7c3vTJKv2W+b9pgvBF1SmkyQSy 8SJ3Zd98CO6FOHA1FigFyZahVsme+T0GsS3/OF1kjrtMktoREr8t0rK0yKpCTYVdlkHadxmR Qs5xLzW1RqKlrNigKHI2yhgpMwrpzS+67F1biT41227sqFzW9urEl/jqGJXaB6GV+SRKSHN+ ubWXgE1NkmfAMeyJPKojNT7ReL6eh3BNB/Xh1vQJew+AE50EP7o36UXghoUktnx6cTkge0ZS qgxuhN33cCOU36pWQhPqVSlLTZQJVxuCmlaHbYWvye7bBOhmiuNKhOzb3FcgT7kBDQRa5zq1 AQgAyRq/7JZKOyB8wRx6fHE0nb31P75kCnL3oE+smKW/sOcIQDV3C7mZKLf472MWB1xdr4Tm eXeL/wT0QHapLn5M5wWghC80YvjjdolHnlq9QlYVtvl1ocAC28y43tKJfklhHiwMNDJfdZbw 9lQ2h+7nccFWASNUu9cqZOABLvJcgLnfdDpnSzOye09VVlKr3NHgRyRZa7me/oFJCxrJlKAl 2hllRLt0yV08o7i14+qmvxI2EKLX9zJfJ2rGWLTVe3EJBnCsQPDzAUVYSnTtqELu2AGzvDiM gatRaosnzhvvEK+kCuXuCuZlRWP7pWSHqFFuYq596RRG5hNGLbmVFZrCxQARAQABiQEfBBgB CAAJBQJa5zq1AhsMAAoJELxheCPuCwBX2UYH/2kkMC4mImvoClrmcMsNGijcZHdDlz8NFfCI gSb3NHkarnA7uAg8KJuaHUwBMk3kBhv2BGPLcmAknzBIehbZ284W7u3DT9o1Y5g+LDyx8RIi e7pnMcC+bE2IJExCVf2p3PB1tDBBdLEYJoyFz/XpdDjZ8aVls/pIyrq+mqo5LuuhWfZzPPec 9EiM2eXpJw+Rz+vKjSt1YIhg46YbdZrDM2FGrt9ve3YaM5H0lzJgq/JQPKFdbd5MB0X37Qc+ 2m/A9u9SFnOovA42DgXUyC2cSbIJdPWOK9PnzfXqF3sX9Aol2eLUmQuLpThJtq5EHu6FzJ7Y L+s0nPaNMKwv/Xhhm6Y= Message-ID: Date: Fri, 19 Jun 2020 13:17:00 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200618155511.16009-1-Kangie@footclan.ninja> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/18/2020 11:55 AM, Matt Jolly wrote: > + pci_warn(dev, " device [%04x:%04x] error status/mask=%08x/%08x\n", > + dev->vendor, dev->device, > + info->status, info->mask); > + } else { > + pci_err(dev, " device [%04x:%04x] error status/mask=%08x/%08x\n", > + dev->vendor, dev->device, > + info->status, info->mask); Function pointers for pci_warn vs. pci_err ? This looks like a lot of copy/paste.