Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1003075ybt; Fri, 19 Jun 2020 21:15:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4n5rfS6KvaxhMZLkuHuljUNYJhVXdrmU26sMPvDqKlKo2GmpNUGDwiAesANfMzY9fXNan X-Received: by 2002:a50:e14e:: with SMTP id i14mr6212206edl.279.1592626532473; Fri, 19 Jun 2020 21:15:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592626532; cv=none; d=google.com; s=arc-20160816; b=BSmdOY8NpnX7xjdI60ALvWyNV5UJoS/vNPy2jvamX+7dfeElaRCVbk5aAf3KkSPnM1 Dkr691rMHLTgGrfEdkE+bG/y1GdxfBXG/IEw9dD/axhm4ws/kMF1ozDO4FtaFYO0DMDC 4d59+UaQkLuQpsXJBI4Jy4O0hZa7mguriJB8V+wPfn8CfegBSQr5rxT0ZcKEsNVrQQkE GPwdBVsslJBIpC48saMFkPKsOOKFytu50jzNxAI/A9sxnCIl/ccs1snm/nrJEcaiTKLn s1IM/LNyaTpwz4AvBaQkph007InstgNLC7Lwx80UWa5qjoPmVelpm/tduuzABuOrQPWY NwOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:subject:reply-to:cc:from:to:dkim-signature:date; bh=pmcgB8cIWmktL8m7nzcLgHPgxr84gMsapvN9vA7VbRQ=; b=0mXmFC8vXDZfmy3aOvROvxP3cbxvdoyAevL+lnzsjpqvIEyuuCr7hY2AVs1B1jMcGU R4cpkvJB+ukbEFDdetcw8ANHJ8REOeYlOHDs1y25C8JbHhwKzC2tn7UI5rZBlcssMZOj bXX1Ek7msIculQrL6TqEjAD1EhcIhC+wTXiezZckAdQgmmSzljjqBf16AghTKy1HWn3M gHpHJL+vGdZ1C2JqwiUVFrz9d5jjg2QEg7V1lX4BPPdEiI2/h3dMnzd8/SyBM1mR9tcW YSvsZborr+ES+E5Ws4RBP9kL5nL3hZ5Y6gQ81kmyioN3cL1TurLqI36sn5tHZPWSghGh WM0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@pm.me header.s=protonmail header.b=QePdyPao; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=pm.me Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ol24si5060610ejb.516.2020.06.19.21.15.10; Fri, 19 Jun 2020 21:15:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@pm.me header.s=protonmail header.b=QePdyPao; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=pm.me Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392643AbgFSRfR (ORCPT + 99 others); Fri, 19 Jun 2020 13:35:17 -0400 Received: from mail2.protonmail.ch ([185.70.40.22]:62029 "EHLO mail2.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732307AbgFSRfQ (ORCPT ); Fri, 19 Jun 2020 13:35:16 -0400 Date: Fri, 19 Jun 2020 17:35:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail; t=1592588111; bh=pmcgB8cIWmktL8m7nzcLgHPgxr84gMsapvN9vA7VbRQ=; h=Date:To:From:Cc:Reply-To:Subject:From; b=QePdyPaod+pKMacktRWNzHWsjJrj3nxq+JWWbCnDXbS/XssWQheK7VvLrcMZFk2TB tE6C6kVxHHDZGWQSt4YUXJGXoF2xlHDw9Nj4aNVf1feMzuXoYFjlNqeqf/Bkogl1sN Gdd4U/c1Ul12Xg+pO2TRkX3u8u0U7IUkHORviBlTfSK1tjI1ZcOtCXZLZ/hLQ0B3Q7 /Ruv9nJHKEmLkQ3Si7B4scvBY5q0MInhS+i6cseXRzT7cOS7QhGcpbpsYd+MahWE7D NUVIGh8kYWqdls84gtjAdA//pd+ORdZNtzWFX451SUecJOE3fuxEtOPSNq92vAIqq4 LjyhnBMB6pXZQ== To: "David S. Miller" , Jakub Kicinski From: Alexander Lobakin Cc: Michal Kubecek , Florian Fainelli , Andrew Lunn , Jiri Pirko , Antoine Tenart , Steffen Klassert , Aya Levin , Tom Herbert , Alexander Lobakin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Reply-To: Alexander Lobakin Subject: [PATCH net 0/3] net: ethtool: netdev_features_strings[] cleanup Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=7.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mail.protonmail.ch Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This little series adds the last forgotten feature string for NETIF_F_GSO_TUNNEL_REMCSUM and attempts to prevent such losses in future. Patches 2-3 seem more like net-next candidates rather than net-fixes, but if we don't stop it now, no guarantees that it won't happen again soon. I was thinking about some kind of static assertion to have an early prevention mechanism for this, but the existing of 2 intended holes (former NO_CSUM and UFO) makes this problematic, at least at first sight. Alexander Lobakin (3): net: ethtool: add missing string for NETIF_F_GSO_TUNNEL_REMCSUM net: ethtool: fix indentation of netdev_features_strings net: ethtool: sync netdev_features_strings order with enum netdev_features net/ethtool/common.c | 133 ++++++++++++++++++++++++------------------- 1 file changed, 74 insertions(+), 59 deletions(-) --=20 2.27.0