Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <f6102c402ae3f4232aebf4e102953f21fdb86cf6.camel@perches.com>
Subject: Re: [PATCH 1/2] drivers: cdrom: fix all errors reported by
 checkpatch
From:   Joe Perches <joe@perches.com>
To:     Simao Gomes Viana <devel@superboring.dev>,
        linux-kernel@vger.kernel.org
Cc:     Arnd Bergmann <arnd@arndb.de>, Jens Axboe <axboe@kernel.dk>
Date:   Fri, 19 Jun 2020 11:29:59 -0700
In-Reply-To: <20200619180834.8032-1-devel@superboring.dev>
References: <20200619180834.8032-1-devel@superboring.dev>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.36.2-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2020-06-19 at 20:08 +0200, Simao Gomes Viana wrote:
> This fixes all errors that scripts/checkpatch.pl
> reports about drivers/cdrom/*.c and a lot of warnings
> as well. I skipped warnings that I don't know whether
> fixing them will break anything.

This is too many changes in a single patch to verify
them easily.

If you really want to change this file, and it's likely
not particularly necessary, I suggest that you send a
patch series that where each patch individually does:

1: Horizontal whitespace only changes
   o Trim trailing whitespace
   o Add alignment whitespace
   o Add operator spacing whitespace
2: Vertical whitespace changes if any
3: Convert embedded assignments to multiple lines
4: Comment style updates

And whatever other specific style changes necessary
to properly and easily identify them as correct.