Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1008177ybt; Fri, 19 Jun 2020 21:26:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxgE/asmlYrvfR6Dau6SSW0YqhY6kQHqbnMvnWjh+hiioHfXcefDQrv9MF3obfHqd2X07EF X-Received: by 2002:aa7:cdcb:: with SMTP id h11mr6634207edw.218.1592627195810; Fri, 19 Jun 2020 21:26:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592627195; cv=none; d=google.com; s=arc-20160816; b=ZDYk6T2gMF8418KOECoEmYk5aBhLkL8BvIa0H7s+CQp5CKzoL4YtM+AM5hYy4QHQ7y tHCLk5VRN2RlEXiwAJTV9ttcw5Cten1gJ2el5ImX9/iQ2VVnywkeGxac6ayePfu6SOv7 AkVwpqJKlCfiI3f3PeUyBeCJXu15MkTdTWviMbMtyd/pOBXIR7d+gHP9/0oPcahNJjRD FocQhJMj7D4Dp14Md4Wi96HcHfyZ5+j2fLlhtBJDHgcErBhgdmEAAZaNeA0syTXqSXjX IhMk9OcXooBd5OyCWy4wlp3kDRn6/VIaXfs9WR0icqEk/V65/Ba2IxeF2VnjbRmklVm1 8+Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=VAU12alREgfzl1CJUkH1Xyf+LPrf6Vg4/H6UXvCgEjw=; b=DeXtazYBGkE9470E0oCyKZ8OWvmKSVZPnG/ZQ/hqQWCozO9ioEPhWqwqQqPJBY9VLY eRBjVbkKgvYxdNmEWPHa8aw9TWYJXC3UeYllNtVw4NtilIrNUsQORDmLz/TGkTjWqqbx i4rycHPiCmHqEw19crO/aRxz4m9H9vWWEuY/nssmMLD/xgxIitdXnjqNzDdjkv6MYxGU SLkjw3c+ncwkT557beDj/SOtiO2s7ykMYAoeovA/Txv37AjMgSovtShZYCjafikFOTRk /ce5AeuNVUrv67lDNu9gEmcq84CZuyPlr2jZRiH69Yd8ZhumpJe6fTyvP2LEU1+Sduw+ Zlsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Frnj43hS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bs24si5171709edb.4.2020.06.19.21.26.14; Fri, 19 Jun 2020 21:26:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Frnj43hS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395421AbgFSSlL (ORCPT + 99 others); Fri, 19 Jun 2020 14:41:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391126AbgFSSlH (ORCPT ); Fri, 19 Jun 2020 14:41:07 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 729F9C06174E; Fri, 19 Jun 2020 11:41:06 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id d6so4632855pjs.3; Fri, 19 Jun 2020 11:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VAU12alREgfzl1CJUkH1Xyf+LPrf6Vg4/H6UXvCgEjw=; b=Frnj43hSpy6OqDbFlHchyZgUeN8xJXe+NNAtJF0SqHkNJjfcSONvJ7CWcYUwZ0MTWX z3/E9H+GrtTvfRYUYoj+XLlyPpL3eYldgt04FuoTkfsWSDoYHoBW8pIUV6pRiovieMal 18IxP5GKHh/NI1lCvux+FlNhvobu90Q0sZp6dfYg3xgihblmmFJY2/lamoBjU0jnUDhj Y/wZ+5n+MBluUeIM4ngm9eXDcRp+f5tAdTNRebbbsewCcCpVJJyyl7iTg8UZrfKX/9+S OY9hGg0Q9QZpT5L5Hd225EjVM7f06CfDhUUTcuKJ8967EFsEdct8pkDfH1tGQ7IINilu wbig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=VAU12alREgfzl1CJUkH1Xyf+LPrf6Vg4/H6UXvCgEjw=; b=cBj4zkWJtaeRjZJX2HIfZ6dzP8pKeghjDHTZVgQ0yN3kqnA9zjtUrxqWhtinKiVCng gEPYYEKUC9ibhESxe7VA5nKe9Xh5/BfBi8CzfPaHxEbiIRkfBgv0pkxi2kMR6A9xniUt uZ3HIhHGi8zV9L/bGIYZ9Bh51qZ/gWVj8R0D6x9OH8gtUByseRMiyJFILFRz82kEgJAC Aa8sd7Uc/4Rz5paWZVxcZNw+wfkZxCz9gZbjuy+xxRAPzelvgyfCAvQS2onsEEEcVjIq Fe0GlA0RarWjEonhmnNatnmyegZqTVGtAPlR7YvnsyBjN/d2Z98s12bSFmmIo4a1AoEK QiAQ== X-Gm-Message-State: AOAM533y92WIG+6CZNJGKEYnHR+gO5XkKfTLpTs75h4rERBRdsksI58n K+Y3j6i4vKiMlEjN4ZqVh0Uh2Jgv X-Received: by 2002:a17:90a:de0f:: with SMTP id m15mr4587595pjv.21.1592592065824; Fri, 19 Jun 2020 11:41:05 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id b7sm6377360pfo.202.2020.06.19.11.41.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jun 2020 11:41:05 -0700 (PDT) Subject: Re: [PATCH v4] hwmon:(adm1275) Enable adm1278 ADM1278_TEMP1_EN To: Manikandan Elumalai , Jean Delvare , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Cc: saipsdasari@fb.com, patrickw3@fb.com, vijaykhemka@fb.com, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, manikandan.e@hcl.com References: <20200619165154.GA20461@cnn> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= Message-ID: Date: Fri, 19 Jun 2020 11:41:03 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200619165154.GA20461@cnn> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/19/20 9:51 AM, Manikandan Elumalai wrote: > The adm1278 temp attribute need it for openbmc platform . > This feature not enabled by default, so PMON_CONFIG needs to enable it. > > Signed-off-by: Manikandan Elumalai In addition to the other comment - please never send a new version of a patch with the same sequence number. There are now two different versions of this patch, both tagged "v4". Guenter > --- > --- v4 -Reported-by: kernel test robot > --- v3 -fix invalid signed-off. > --- -removed checkpath warnings. > --- -write ADM1278_TEMP1_EN and ADM1278_VOUT_EN conf in single line operation. > --- v2 -add Signed-off-by. > --- -removed ADM1278_TEMP1_EN check. > --- > --- > drivers/hwmon/pmbus/adm1275.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/hwmon/pmbus/adm1275.c b/drivers/hwmon/pmbus/adm1275.c > index 5caa37fb..d4e1925 100644 > --- a/drivers/hwmon/pmbus/adm1275.c > +++ b/drivers/hwmon/pmbus/adm1275.c > @@ -666,11 +666,12 @@ static int adm1275_probe(struct i2c_client *client, > tindex = 3; > > info->func[0] |= PMBUS_HAVE_PIN | PMBUS_HAVE_STATUS_INPUT | > - PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT; > + PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT | > + PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP; > > - /* Enable VOUT if not enabled (it is disabled by default) */ > - if (!(config & ADM1278_VOUT_EN)) { > - config |= ADM1278_VOUT_EN; > + /* Enable VOUT & TEMP1 if not enabled (disabled by default) */ > + if ((config & (ADM1278_VOUT_EN | ADM1278_TEMP1_EN)) != (ADM1278_VOUT_EN | ADM1278_TEMP1_EN)) { > + config |= ADM1278_VOUT_EN | ADM1278_TEMP1_EN; > ret = i2c_smbus_write_byte_data(client, > ADM1275_PMON_CONFIG, > config); > @@ -681,9 +682,6 @@ static int adm1275_probe(struct i2c_client *client, > } > } > > - if (config & ADM1278_TEMP1_EN) > - info->func[0] |= > - PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP; > if (config & ADM1278_VIN_EN) > info->func[0] |= PMBUS_HAVE_VIN; > break; >