Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1009000ybt; Fri, 19 Jun 2020 21:28:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztspRR4eBylA6bDgDZpBc0LgFkbEcldniBcV1W5ZHW1alHw4tVDMRaBh96DNVNemUf+BfL X-Received: by 2002:aa7:d717:: with SMTP id t23mr6247273edq.304.1592627323061; Fri, 19 Jun 2020 21:28:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592627323; cv=none; d=google.com; s=arc-20160816; b=DARuxOsTqhqtzFQKBFYr5jFw/UChZKekgQtUsks5bnGkDXYdRMVyGulg5BOkDzYw5K B4hzcxmppiHIlYgbVYcQZiFHyds/xp1nsG0CLbsks9va8jf3AKibjkGGVPGoZ/VtGRjp LVx+HJEMR5BACrsCtHORShMHoN3/TwqTa3ly9ZmeEBU7ifPhSZh2sCK4AuhXAQR4Jz9C wbGASuXhcKZnlAafB74JY0ckOqI+Z8nIKO/xn3N7CdDqO0D5KSyVNQfCduqbuc74FI3l y96DHkRDgqjYsYGODlKB2xpVKMDga2TrnrGZZQtA63wF2S/5bOo1QGL7i5FREm3xMoqA 7Etw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:to:from:date :dkim-signature; bh=L1X5Wlz0l9aM5xeJbCoKmndqKOAybV/aM+tduBgsy70=; b=o58ANEMQly4pmKIeThxpinXGmCEr1CPRkjMPTf9nB58Ei3vNkH+4H9yw+qLgElgPte l3NGOb3z/0ZCY5XexOQk9/lBvcXJlZVxBE2dNeNZCUp9KcLibhTyDvyWs1s28TLRIlOF kqBjVaXehrebIyybxBUqmzTy0LAPEjnj8EC2zuo/ucTHM6r8Fevi/2SeZAvL5e7t+udD 0ru7GzCXnpfMxsZ6BLnSCVqmIiUDIWh/cxyP1qjmVJxV5b7UET9M+lwbcYFli9TcEE7h SY5vX1aoJKrT2wvNhA352ysjvaBQciDTgOFzwzrESo1LgbhZ+LwsG7hWwkio+xb9875T gAyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@superboring.dev header.s=dkim header.b=tnM+lKKf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=superboring.dev Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oz26si5026020ejb.252.2020.06.19.21.28.19; Fri, 19 Jun 2020 21:28:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@superboring.dev header.s=dkim header.b=tnM+lKKf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=superboring.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436663AbgFSSlV (ORCPT + 99 others); Fri, 19 Jun 2020 14:41:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388608AbgFSSlN (ORCPT ); Fri, 19 Jun 2020 14:41:13 -0400 Received: from mail.halogenos.org (halogenos.org [IPv6:2a02:c207:2037:5246::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57412C06174E for ; Fri, 19 Jun 2020 11:41:13 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 799311500319; Fri, 19 Jun 2020 20:41:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=superboring.dev; s=dkim; t=1592592071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L1X5Wlz0l9aM5xeJbCoKmndqKOAybV/aM+tduBgsy70=; b=tnM+lKKfcH+Fe9ZsKjPPrbUeMTF+z4QRgOodKLmriay6UlIvA9UoWxL83V5IML087BothY 2wEl66IreG7hHVU9191mopMDy+lm/cH/HLVkmGD8JpKQ94pArH13QG/hJqIneKwSBUMGf6 WIBF5kZrkUrsAy7KQz4cytCiJsFs4gfa600JAc+RKQiBGkfSv9Bl8Lkiyzxp7+vIjlQSl0 T2gPM6FZEP7JNu/pHcHPJu2JszZuTPDTlb2kPQ7+8hkuFBgYnZ+9wIKBfOnXQ6HS+9B/ma D0k36Hzgnr8CzO66KQNyAHxN3iEMm9JliinLplkBYMQDEXBttVMP5D/i2t3bhQ== Date: Fri, 19 Jun 2020 20:41:04 +0200 From: Simao Gomes Viana To: Joe Perches , linux-kernel@vger.kernel.org Subject: Re: Re: [PATCH 1/2] drivers: cdrom: fix all errors reported by checkpatch Message-ID: <20200619184049.4fn2rljaay6v7bjy@simao-arch.localdomain> References: <20200619180834.8032-1-devel@superboring.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 19, 2020 at 11:29:59AM -0700, Joe Perches wrote: > On Fri, 2020-06-19 at 20:08 +0200, Simao Gomes Viana wrote: > > This fixes all errors that scripts/checkpatch.pl > > reports about drivers/cdrom/*.c and a lot of warnings > > as well. I skipped warnings that I don't know whether > > fixing them will break anything. > > This is too many changes in a single patch to verify > them easily. > > If you really want to change this file, and it's likely > not particularly necessary, I suggest that you send a > patch series that where each patch individually does: > > 1: Horizontal whitespace only changes > o Trim trailing whitespace > o Add alignment whitespace > o Add operator spacing whitespace > 2: Vertical whitespace changes if any > 3: Convert embedded assignments to multiple lines > 4: Comment style updates > > And whatever other specific style changes necessary > to properly and easily identify them as correct. > > Thank you for your feedback. I will follow up with a proper set of patches as you described in your response. I'm fairly new to submitting patches. Although I have read through some of the guidelines there is always room for improvement so it's great to get feedback like that.