Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 19 Jun 2020 16:27:29 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Heiko Carstens <heiko.carstens@de.ibm.com>
Cc:     Xiaoming Ni <nixiaoming@huawei.com>,
        alexander.shishkin@linux.intel.com, arnd@arndb.de,
        borntraeger@de.ibm.com, catalin.marinas@arm.com,
        christian@brauner.io, cyphar@cyphar.com, dhowells@redhat.com,
        ebiederm@xmission.com, fenghua.yu@intel.com, geert@linux-m68k.org,
        gor@linux.ibm.com, ink@jurassic.park.msu.ru, jolsa@redhat.com,
        linux@armlinux.org.uk, lkp@intel.com, mark.rutland@arm.com,
        mattst88@gmail.com, minchan@kernel.org, mingo@redhat.com,
        monstr@monstr.eu, namhyung@kernel.org, peterz@infradead.org,
        rth@twiddle.net, sargun@sargun.me, sfr@canb.auug.org.au,
        tony.luck@intel.com, will@kernel.org, akpm@linux-foundation.org,
        alex.huangjianhui@huawei.com, zhongjubin@huawei.com,
        linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
        clang-built-linux@googlegroups.com, kbuild-all@lists.01.org,
        linux-mm@kvack.org
Subject: Re: [PATCH v2] s390: fix build error for sys_call_table_emu
Message-ID: <20200619192729.GA29309@kernel.org>
References: <20200618141426.16884-1-nixiaoming@huawei.com>
 <20200619141717.GB9971@osiris>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200619141717.GB9971@osiris>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Fri, Jun 19, 2020 at 04:17:17PM +0200, Heiko Carstens escreveu:
> On Thu, Jun 18, 2020 at 10:14:26PM +0800, Xiaoming Ni wrote:
> > Build error on s390:
> > 	arch/s390/kernel/entry.o: in function `sys_call_table_emu':
> > 	>> (.rodata+0x1288): undefined reference to `__s390_'
> > 
> > In commit ("All arch: remove system call sys_sysctl")
> >  148  common	fdatasync		sys_fdatasync			sys_fdatasync
> > -149  common	_sysctl			sys_sysctl			compat_sys_sysctl
> > +149  common	_sysctl			sys_ni_syscall
> >  150  common	mlock			sys_mlock			sys_mlock
> > 
> > After the patch is integrated, there is a format error in the generated
> > arch/s390/include/generated/asm/syscall_table.h:
> > 	SYSCALL(sys_fdatasync, sys_fdatasync)
> > 	SYSCALL(sys_ni_syscall,) /* cause build error */
> > 	SYSCALL(sys_mlock,sys_mlock)
> > 
> > According to the guidance of Heiko Carstens, use "-" to fill the empty system call
> >  Similarly, modify tools/perf/arch/s390/entry/syscalls/syscall.tbl.
> > 
> > Fixes: ("All arch: remove system call sys_sysctl")
> > Fixes: https://lore.kernel.org/linuxppc-dev/20200616030734.87257-1-nixiaoming@huawei.com/
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com>
> > 
> > changes in v2:
> > 	use "-" to fill the empty system call
> > 
> > v1: https://lore.kernel.org/lkml/20200618110320.104013-1-nixiaoming@huawei.com/
> > ---
> >  arch/s390/kernel/syscalls/syscall.tbl           | 2 +-
> >  tools/perf/arch/s390/entry/syscalls/syscall.tbl | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>

I get just copies of that file when it gets out of sync, so I suppose
the patch should be just for arch/s390/kernel/syscalls/syscall.tbl and
processed by the s/390 maintainer?

- Arnaldo