Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] drivers: cdrom: fix all errors reported by checkpatch
To:     Simao Gomes Viana <devel@superboring.dev>,
        linux-kernel@vger.kernel.org
Cc:     Arnd Bergmann <arnd@arndb.de>
References: <20200619180834.8032-1-devel@superboring.dev>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <f1dea27d-9262-f818-20a2-e77098dbb27f@kernel.dk>
Date:   Fri, 19 Jun 2020 15:26:41 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <20200619180834.8032-1-devel@superboring.dev>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 6/19/20 12:08 PM, Simao Gomes Viana wrote:
> This fixes all errors that scripts/checkpatch.pl
> reports about drivers/cdrom/*.c and a lot of warnings
> as well. I skipped warnings that I don't know whether
> fixing them will break anything.
> 
> Before:
> drivers/cdrom/cdrom.c:
>     total: 118 errors, 126 warnings, 3794 lines checked
> drivers/cdrom/gdrom.c:
>     total: 0 errors, 16 warnings, 873 lines checked
> 
> After:
> drivers/cdrom/cdrom.c:
>     total: 0 errors, 38 warnings, 3866 lines checked
> drivers/cdrom/gdrom.c:
>     total: 0 errors, 3 warnings, 882 lines checked
> 
> Test: scripts/checkpatch.pl --file drivers/cdrom/*.c
> Test: make drivers/cdrom/cdrom.o
> Test: make CONFIG_GDROM=y drivers/cdrom/gdrom.o # partial
> Test: compiles, boots on 5.7.4
> Test: CD ROM works (tested with Audio CD)

Let's please not do this, it's a lot of churn for zero gain.

-- 
Jens Axboe