Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6371EC433C8
Subject: Re: [PATCH V7 1/4] dt-bindings: clock: add ipq6018 a53 pll compatible
To:     Stephen Boyd <sboyd@kernel.org>, agross@kernel.org,
        bjorn.andersson@linaro.org, devicetree@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org, mturquette@baylibre.com,
        robh+dt@kernel.org
References: <1591440907-20021-1-git-send-email-sivaprak@codeaurora.org>
 <1591440907-20021-2-git-send-email-sivaprak@codeaurora.org>
 <159261339539.62212.17722723971033735363@swboyd.mtv.corp.google.com>
From:   Sivaprakash Murugesan <sivaprak@codeaurora.org>
Message-ID: <efef8d40-1c89-76b5-261e-8801e4dbdf51@codeaurora.org>
Date:   Sat, 20 Jun 2020 06:36:08 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <159261339539.62212.17722723971033735363@swboyd.mtv.corp.google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 6/20/2020 6:06 AM, Stephen Boyd wrote:
> Quoting Sivaprakash Murugesan (2020-06-06 03:55:04)
>> cpus on ipq6018 are clocked by a53 pll, add device compatible for a53
>> pll found on ipq6018 devices.
>>
>> Signed-off-by: Sivaprakash Murugesan <sivaprak@codeaurora.org>
>> ---
>> [V7]
>>   * Addressed minor review comment from Rob
>>   .../devicetree/bindings/clock/qcom,a53pll.yaml         | 18 ++++++++++++++++++
>>   1 file changed, 18 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
>> index 20d2638..3161fab 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
>> @@ -15,6 +15,7 @@ description:
>>   
>>   properties:
>>     compatible:
>> +    const: qcom,ipq6018-a53pll
>>       const: qcom,msm8916-a53pll
>>   
>>     reg:
> I'm getting this error when running dt binding check:
>
> ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping
>    in "<unicode string>", line 18, column 5
> found duplicate key "const" with value "qcom,msm8916-a53pll" (original value: "qcom,ipq6018-a53pll")
>    in "<unicode string>", line 19, column 5

This error started coming after updating the dt-schema version.

Guess I need to replace const with enum to get rid of this error.

will address this.