Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1166810ybt;
        Sat, 20 Jun 2020 02:57:47 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzAaLx9VfJ40HfHME2qnyzV8XjxmDAWFToOxH8pgcaRLVlzqFBdQymDD9BBAKBlxtztvxM7
X-Received: by 2002:a17:906:840a:: with SMTP id n10mr1735295ejx.453.1592647067512;
        Sat, 20 Jun 2020 02:57:47 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1592647067; cv=none;
        d=google.com; s=arc-20160816;
        b=mVay1LBKUTvu/O38HcNviVCHGyuyR4l//DvZ+zmcqgYSTcweYe+y6r3zkXLAXQYqTb
         YzEw39C7sK7Kit7J5d7mPF3A//9Rb9Uywma6djmoeetRG2PGcNGKeoMfEcZJigQagrN9
         kVbi7Qwu7ZpctvMa4SzvNft7Ytcmx7iO9yjzfz6EqncfE55Q9HSo+ghCx+zuUqolpwVE
         N34RAbjkLJGQWHIHjrUUMLTVU7Jm/cLe4fdPGlxa5Ja8Y/C1MkAB3a11Kgc9WbfE3QmI
         VKtR9qZiyr7JGOirERilo5BJMEoL5cqDPNkDq8z/vaE03Z9qk7CJRtwOthu/G8gqXssn
         OMeg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=skDQ77maO2GC7cm4xW7BXoWafTy1w2SK+o9txAtL5SE=;
        b=duKPxl6c0X5A2rmnLLZlaRDUygAvLejc6pmqLtrrUjgXspP6nr4zdopRAPSOznksqb
         lA1TlJzsxRwr+PiCRJpGuagmObbPYu7xIK9x2NMk+D9c+H/X1ElUjxRQsMGvkP2PLGsW
         rW0onwjPWhKYc4791wzAveb9YSrna/fg96EzyCsqjjbZW/SdbXPf1hEfrFczOGD2ub2L
         Jb8/EaRKfhWxv4ul112fuhpEcaMPRmIsyCdw+SVzCTCdBj7svIF1DDYgrQdUGrG9T50k
         KUn5GxdTa5tZ171Af68sBjN2STGqB8RyMnt5KxwPRLmqj0h9Iw2Wx4ircnsFpLWNc9jg
         Zoow==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=UimnWIqp;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id dr11si6749563ejc.254.2020.06.20.02.57.24;
        Sat, 20 Jun 2020 02:57:47 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=UimnWIqp;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727944AbgFTJx3 (ORCPT <rfc822;yuvraaj@gmail.com> + 99 others);
        Sat, 20 Jun 2020 05:53:29 -0400
Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:9331 "EHLO
        hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727861AbgFTJx3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 20 Jun 2020 05:53:29 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5eeddc8c0000>; Sat, 20 Jun 2020 02:53:16 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Sat, 20 Jun 2020 02:53:28 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Sat, 20 Jun 2020 02:53:28 -0700
Received: from [10.26.73.131] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 20 Jun
 2020 09:53:22 +0000
Subject: Re: [PATCH] [v3] dmaengine: tegra210-adma: Fix runtime PM imbalance
 on error
To:     <dinghao.liu@zju.edu.cn>
CC:     <kjlu@umn.edu>, Laxman Dewangan <ldewangan@nvidia.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Vinod Koul <vkoul@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        <dmaengine@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20200618105727.14669-1-dinghao.liu@zju.edu.cn>
 <9f7684d9-7a75-497d-db1c-75cf0991a072@nvidia.com>
 <24ea1ef1.10213.172ca4d45be.Coremail.dinghao.liu@zju.edu.cn>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <f4034e16-e720-57c4-eb9d-733786212a4a@nvidia.com>
Date:   Sat, 20 Jun 2020 10:53:20 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <24ea1ef1.10213.172ca4d45be.Coremail.dinghao.liu@zju.edu.cn>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1592646796; bh=skDQ77maO2GC7cm4xW7BXoWafTy1w2SK+o9txAtL5SE=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=UimnWIqpRJy7kUAKmx0otVxsMGTTOcIcq44DP2Q5g9xTeWqUH6NSnNDqR6hnTZ/mO
         RW22vRCa6BZ6k/TDgdYcAmeWCLgM+1gQHulmACKUapQXyooMt7XRyx/UKASP+XhFBB
         XN1AXJtTB3koVzlED+vKIUKDGJkEGtjP+AdLktNtOINJfFLMTafwfYGt0AfZZlTZ5C
         djhZUysytC6torZrMRhRcjfHk3IpOnp9GURpLmvi5AdwIVa4HsC5C3j09ZMBbrOv3L
         tHH7g9g8VZfW89oOtP94NLhHaSV7L3E0wlc1z0QcQ29SDRUIF9HOklT6Kc/rjqDeFN
         E+L169HQ1F3xQ==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 19/06/2020 02:59, dinghao.liu@zju.edu.cn wrote:
>>
>> Why noidle?
>>
> 
> _noidle is enough for fixing this bug. _sync may suspend
> the device beyond expectation.

In that case, then the other instance you are fixing with this patch is
not correct.

Jon

-- 
nvpublic