Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1214431ybt; Sat, 20 Jun 2020 04:24:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyq6fQ+W1gzuIcel0b7+p0l1GTzyojEq1pEHPSGV58+ZWYn3eWt7fyB5kxB/2Ad1ljwpG7k X-Received: by 2002:a17:906:90b:: with SMTP id i11mr7415647ejd.343.1592652295784; Sat, 20 Jun 2020 04:24:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592652295; cv=none; d=google.com; s=arc-20160816; b=GUSuiK/2sk5x2Eg6JYBuCSgtBQje/HOYytVvKyl6yvzxNV/8TKwTQnZul71U5hYHkz cZhyAYP9vKj644j2SuCYGw6gAwMggmefKvQutEfrAAT1nokNdyWLH2jR9Fsj9+mOs+EE f9u91Y7RLqcT7UzyA38QiRrO/6mcK58Y43CG8VLMyLgiHls3R7nzNKVlaexATamHyPj7 UT+E1uoAUHfbf8p0RCCrR6BMwECV+POTYRCvXdodXSQx06QEY7K0SvEy4K20TrHpY4gl +GaMmghNvyoh/802YlRj/N6iq1UAbRIGJZYfto1ptgnWbdiw6R5ywnId3JudixXrG90K SXEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=RDlUDCVBjtexRolaomRC6guoitY/zFSv85mBRPHLWvs=; b=xm00csmivTukg3vkEnkqdc60qMXckQIuG5XsNMvpWQJm+9Y2aiXD20Xyu2n+6Ar6X9 tKa4GiYweOv9g4Ag76fftCxAevDuX05LlGrT0FXToN+I5b7rruhpLcpBusiFWQDYa3Hf XHlquLqYjHwf7rDmP2YTQ7E40/U+S9Bz+1j38uYX4S24uvbzdTwL4WVbacXHEdmt3CQm THXSJDPXXQcfquDz1zIa6TjwyDomhqxzIUcJNAbbJTj0ZUYZT3sSVScLxFH7IbnWbZhf 6i8Emg7M15QUgoqVpZpRw6GU/j2geMhOMtCPaZkSITxF3vtPD7zaTilzrbh9qu2jrdD1 EvZw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b93si5942965edf.199.2020.06.20.04.23.31; Sat, 20 Jun 2020 04:24:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728051AbgFTLUL (ORCPT + 99 others); Sat, 20 Jun 2020 07:20:11 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:50394 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727971AbgFTLUK (ORCPT ); Sat, 20 Jun 2020 07:20:10 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 1729920020; Sat, 20 Jun 2020 13:20:07 +0200 (CEST) Date: Sat, 20 Jun 2020 13:20:05 +0200 From: Sam Ravnborg To: Wei Yongjun Cc: Thierry Reding , David Airlie , Daniel Vetter , Philippe CORNU , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Hulk Robot Subject: Re: [PATCH] drm/panel: otm8009a: Drop unnessary backlight_device_unregister() Message-ID: <20200620112005.GA16901@ravnborg.org> References: <20200618134650.44311-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200618134650.44311-1-weiyongjun1@huawei.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=edQTgYMH c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=i0EeH86SAAAA:8 a=e5mUnYsNAAAA:8 a=zABfKpiexC27CGjMe80A:9 a=CjuIK1q_8ugA:10 a=Vxmtnl_E_bksehYqCbjh:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wei. On Thu, Jun 18, 2020 at 01:46:50PM +0000, Wei Yongjun wrote: > It's not necessary to unregister backlight device which > registered with devm_backlight_device_register(). > > Fixes: 12a6cbd4f3f1 ("drm/panel: otm8009a: Use new backlight API") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun Thanks, pushed to drm-misc-next. Sam > --- > drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c > index 895ee3d1371e..d956522f32ee 100644 > --- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c > +++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c > @@ -479,7 +479,6 @@ static int otm8009a_probe(struct mipi_dsi_device *dsi) > if (ret < 0) { > dev_err(dev, "mipi_dsi_attach failed. Is host ready?\n"); > drm_panel_remove(&ctx->panel); > - backlight_device_unregister(ctx->bl_dev); > return ret; > } > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel