Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751972AbWCYXpX (ORCPT ); Sat, 25 Mar 2006 18:45:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751977AbWCYXpW (ORCPT ); Sat, 25 Mar 2006 18:45:22 -0500 Received: from cantor2.suse.de ([195.135.220.15]:56723 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S1751972AbWCYXpV (ORCPT ); Sat, 25 Mar 2006 18:45:21 -0500 From: Andreas Schwab To: Jan Engelhardt Cc: Nathan Scott , linux-xfs@oss.sgi.com, Linux Kernel Mailing List Subject: Re: Parenthesize macros in xfs References: <20060321082327.B653275@wobbly.melbourne.sgi.com> <20060321084619.E653275@wobbly.melbourne.sgi.com> X-Yow: Well, O.K. I'll compromise with my principles because of EXISTENTIAL DESPAIR! Date: Sun, 26 Mar 2006 00:45:19 +0100 In-Reply-To: (Jan Engelhardt's message of "Sun, 26 Mar 2006 00:23:47 +0100 (MET)") Message-ID: User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1003 Lines: 32 Jan Engelhardt writes: >>> -#define swap(a, b) \ >>> +#define swap(a, b) do { \ >>> if (swaptype == 0) { \ >>> long t = *(long *)(a); \ >>> *(long *)(a) = *(long *)(b); \ >>> *(long *)(b) = t; \ >>> } else \ >>> - swapfunc(a, b, es, swaptype) >>> + swapfunc(a, b, es, swaptype) \ >>> +} while(0) >> ^^ >>Missing semicolon. >> > > It was missing before too. ;) No, previously it was provided at the call site. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra?e 5, 90409 N?rnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/