Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1367072ybt; Sat, 20 Jun 2020 08:24:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxuGa3mKGBtTWK2yF8urcPu/qdASKbNZvQNB9R9/YNgG4vAmrCaFuX59qPO9FBV5Q4EjRE4 X-Received: by 2002:a17:906:745:: with SMTP id z5mr8410074ejb.492.1592666645083; Sat, 20 Jun 2020 08:24:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592666645; cv=none; d=google.com; s=arc-20160816; b=iT3dYVFuIzgzD4/miWoq76fR5AReLvz3WeInSgGu4VC+pMDRIrkiayrvXlPbaAbhEz p9Z64nko5C6uFgE47jtlWiL6vT3d3LMVNMhX44lG/9YPN29NpNhPLJmtrs3WOcqKPmt0 iZabY4eKf1FCSwiJhcGQgvbHKT4ffusFDxQ8xJ4ibpCVaCn7oxA0qov4lY7ePNGhDUG5 +Wx3czLVi55WMaK0saptx9u4sQlmhZsaGqEo6DaM/71PxARxHIKtfFd7KgugTHjhs5we v6e212NMcM+33WcHBy59U8pcU51Ii/p8ylmiZBXiZbn38oU5i/sJnanYgc4h1mI745gt /o0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=GczsLSs5l0Kj34C9wYLwT6g5WumnEAyshUev39heJZQ=; b=0C6qrbI9mYgIuZR1X1NIGso/vvF+bz2+j8pVVqaZ8vJXQqBDIWAoO+ByvSnkzkBGgI yQwIlJ2eyorBixWh874Jw6MHIBZcDi+3qhFXYuq4K00TTdheRIiEflelS6xdwVJRERtr LTt3/EsNRt5gXwulsjSAXH91FgoUFx3OA9Y3OHgyDBS3d47NRLzlvSYK7GSVqgRkRF1M oFgQXL+GirK83B5dQOWkfLw8W6C0t9YkASQBTMU+j6a0kY9Ap7xtSEIVpxek8PUfhKI1 e6tUQvIw22wauXSS3hs4KakTEJhT7S38mRKANZDvv0ZUtDiZIFD2JmBeO+DDsEe98IVc dDZw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c102si1251427edf.216.2020.06.20.08.23.42; Sat, 20 Jun 2020 08:24:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726984AbgFTPVo (ORCPT + 99 others); Sat, 20 Jun 2020 11:21:44 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50130 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725777AbgFTPVo (ORCPT ); Sat, 20 Jun 2020 11:21:44 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1jmfJO-001PND-Rz; Sat, 20 Jun 2020 17:21:42 +0200 Date: Sat, 20 Jun 2020 17:21:42 +0200 From: Andrew Lunn To: Antoine Tenart Cc: davem@davemloft.net, f.fainelli@gmail.com, hkallweit1@gmail.com, richardcochran@gmail.com, alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, allan.nielsen@microchip.com, foss@0leil.net Subject: Re: [PATCH net-next v3 6/8] net: phy: mscc: timestamping and PHC support Message-ID: <20200620152142.GN304147@lunn.ch> References: <20200619122300.2510533-1-antoine.tenart@bootlin.com> <20200619122300.2510533-7-antoine.tenart@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200619122300.2510533-7-antoine.tenart@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + /* Retrieve the shared load/save GPIO. Request it as non exclusive as > + * the same GPIO can be requested by all the PHYs of the same package. > + * Ths GPIO must be used with the phc_lock taken (the lock is shared > + * between all PHYs). > + */ > + vsc8531->load_save = devm_gpiod_get_optional(&phydev->mdio.dev, "load-save", > + GPIOD_FLAGS_BIT_NONEXCLUSIVE | > + GPIOD_OUT_LOW); > + if (IS_ERR(vsc8531->load_save)) { > + phydev_err(phydev, "Can't get load-save GPIO (%ld)\n", > + PTR_ERR(vsc8531->load_save)); > + return PTR_ERR(vsc8531->load_save); > + } > + I can understand the GPIO being optional, it is only needed when PTP is being used. But i don't see a test anywhere that when PTP is being used the GPIO is provided. What actually happens if it is missing and somebody tries to use the PTP? Maybe only register the PTP parts with the core if the GPIO has been found in DT? Andrew