Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1372223ybt; Sat, 20 Jun 2020 08:32:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzqEKrsvI6OAH9RXp/0DB3HXQbu6fIv8rpCRXqBxp2loe4yXVcMGHcHeyosnavxHMQnWu8v X-Received: by 2002:a17:906:af6b:: with SMTP id os11mr8811562ejb.291.1592667151027; Sat, 20 Jun 2020 08:32:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592667151; cv=none; d=google.com; s=arc-20160816; b=BvPWv27xPLp/r7JaQwrZpIDekMz+eoRc7eDPYQW1ve5UCc0h8rpI+5ikNIjDi0KX6a h4fUKMahKMoFYrywpplIDOmL5CYZH2282KB8w3JzWKKAyeCUVLvZ/tMV6POncAH+bmpK yT8V28+vlpbKcD5VadpC/cWQMjYyUGwq7kG56kDWAD2vO5VtrkbBEKdDsl3jWf0PGzJf mRsBNzK4yW3LE0mkAWd7bcj8nMufO7l/k3Hs+j4/llevN9K1sxmA/yu1T5vqAa0YNNmv r41iEM4sibnwc44cl0U7OfCtWBYA6CCSDwBqb04JPIYgroIaKcGspR3Q5boq9PLMGIis ykbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=9RHpJCFXA/dGE/Qgml5wcqUoc/6Ok3CJjXFk5ee+Yu0=; b=T/pw30zlXrC50dH4rpp20au/2pj/m9J0oGAyne9QUWnIn37AOq61llLX0eENJA/zlg 5EByZ1jOSOxZ9hDpp7rWeG+CRjOqw9yN2ct5C2Zccw2DO4QeRbaSfNFY0aeVR9dc9Esp bRL3pcnz5KJNo7S9UKgYScbNyQFTTLUco8AhlQUPCkIKJQ25ZnFv2QILl6bXrfpWgshO GlV8yn/CBQxHELJAeWJ3CtofiFfv4LlTCdobbY76srx8eok0P0rqv02RdimEn3S7WKLm y7FOrliGNojytooLt5Mf8gErv95bu1T+L9tp/GkQ1iNb4nN0zqvfYKMLHniugzh+WeEK xGDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w17si110094ejz.332.2020.06.20.08.32.06; Sat, 20 Jun 2020 08:32:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726094AbgFTPaQ (ORCPT + 99 others); Sat, 20 Jun 2020 11:30:16 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:41224 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725777AbgFTPaQ (ORCPT ); Sat, 20 Jun 2020 11:30:16 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 7CF968053D; Sat, 20 Jun 2020 17:30:13 +0200 (CEST) Date: Sat, 20 Jun 2020 17:30:12 +0200 From: Sam Ravnborg To: Dmitry Osipenko Cc: Laurent Pinchart , Thierry Reding , Rob Herring , Frank Rowand , linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v8 7/7] drm/panel-simple: Add missing connector type for some panels Message-ID: <20200620153012.GA22743@ravnborg.org> References: <20200617222703.17080-1-digetx@gmail.com> <20200617222703.17080-8-digetx@gmail.com> <20200620112132.GB16901@ravnborg.org> <20200620114934.GB5829@pendragon.ideasonboard.com> <20200620143114.GA22329@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=G88y7es5 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=IkcTkHD0fZMA:10 a=pGLkceISAAAA:8 a=7gkXJVJtAAAA:8 a=e5mUnYsNAAAA:8 a=I1XKC5YfttuoCrzH9m8A:9 a=QEXdDO2ut3YA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=Vxmtnl_E_bksehYqCbjh:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry On Sat, Jun 20, 2020 at 06:05:37PM +0300, Dmitry Osipenko wrote: > 20.06.2020 17:31, Sam Ravnborg пишет: > > Hi Dmitry > > > >> > >> Oops! Good catch! > > Yep, thanks Laurent. Should have taken a better look before applying. > > > >> Indeed, I blindly set the LVDS type to all these > >> panels. Please revert this patch, I'll double check each panel and > >> prepare an updated version of this patch. Thank you very much for the > >> review! > > > > If you can prepare a fix within a few days then lets wait for that. > > I will do a better review next time. > > Hello Sam, > > I should be able to make it later today or tomorrow. Could you please > clarify what do you mean by the fix, do you what it to be as an > additional patch on top of the applied one or a new version of the patch? An additional patch on top of the one applied. It shall carry a proper fixes: tag like this: Fixes: 94f07917ebe8 ("drm/panel-simple: Add missing connector type for some panels") Cc: Dmitry Osipenko Cc: Sam Ravnborg Cc: Thierry Reding Cc: dri-devel@lists.freedesktop.org Sam