Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1467351ybt; Sat, 20 Jun 2020 11:13:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymcXs7Q6VJR8s6ZxMNMbPyPpuDvDdTrWuFiCFOrAz4fmjXcK4+X++4LDWtY7no8ncdYpbH X-Received: by 2002:a17:906:abca:: with SMTP id kq10mr9203728ejb.390.1592676839156; Sat, 20 Jun 2020 11:13:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592676839; cv=none; d=google.com; s=arc-20160816; b=QX4harGu4W5ZBjSsmvSkS1Vrf82glxuSv0MB785+4FXs/1EU8HKDv9vDCx6ge20tvs VmhRdv74PmWoVnu23eKAJJ0hG3slg+vS6xoCgLa40EtBzvW66DNeWiUofI8A639PZCh0 oQYXjzLkc+b8FV0KThMy8R5QHep6s8usiRRRVIuXsRe7b0tLp1LdCqpHtV3gC/Jz4Fdd rKDKgfH+4KNa2lSHU436BSoWReNwSK/Dw23E6D554flVUtokT875HOTPvZmnuxxV1wug 0s3oIA11G05B2VMkYBN6D1JLrluUm4r6XYvwlcoVs8opyjaruZiIyyJ/Z2lfksKcpdH3 jvbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HhcAoXPW7ZRiM/8Q3ygWBvgF6djv95EaVmKQGesqI94=; b=D3Mjxk/L6dsvBPLmtaR2A43M5J/cUezhvIsy+b80rIBczFVocWz3l2HTNM5CbxfFC+ pN+Wb6rYoea7t9NLU6XP3FjEy8UgdG+P2W1RBZr1R7lfvhCYyAPbcf/6eKg0olXArs8z zGowC8ycmnV6y+jW3w450+e0K6LHAXfOYbu889rvRTL3SUHmKv33PdhmuOM2iUfWv9zz E/PendGLccYVRS+RDVLVXGv+yHNJKfEUjn8o6tncxctGlx6VHfkEhk8ErK2MV0n5X+1V so3/xBUTXVFl+3IhEMytjwuAuiSoJMfdsonTQX5CIPvPwZ8NVSikCoC6fDZcxg/8a0xB TNEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=LVrJSweq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y16si6275344edw.311.2020.06.20.11.13.37; Sat, 20 Jun 2020 11:13:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=LVrJSweq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728633AbgFTSIt (ORCPT + 99 others); Sat, 20 Jun 2020 14:08:49 -0400 Received: from mail-oo1-f68.google.com ([209.85.161.68]:37575 "EHLO mail-oo1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728482AbgFTSIP (ORCPT ); Sat, 20 Jun 2020 14:08:15 -0400 Received: by mail-oo1-f68.google.com with SMTP id q188so2552755ooq.4 for ; Sat, 20 Jun 2020 11:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HhcAoXPW7ZRiM/8Q3ygWBvgF6djv95EaVmKQGesqI94=; b=LVrJSweqFDE8nI+TCoqMv9kLa+tcLbhtQxp9cpuM5sSKIuS/ORD16ikAeTQp3tnhlP ekwqizkOPVv9tsyXEspw0yhlTJGVnCYQERSK8uRfiJUe6YtAObMFNB/hUIubPfk1yJHS qkjG6JeAVHBJUdMtePJcb3oTWEtbjZQKYzpACjSf/8Wte0DmDXJ3T6/hYOO7bZYGWIaS iGxc1AIBA9X9JpglXXOUmagUBXFfEbBS4jMG62qX7a8k5M88+3qWW6lqzolDKdgEw6px mLNPOrwHhutG2aWargqukVxyEBWerzwfCkSguTX79zf50FIZDzXG8fRTms+jBt4aGKWb LCDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HhcAoXPW7ZRiM/8Q3ygWBvgF6djv95EaVmKQGesqI94=; b=aWpKs7Zrsm/BOy9rCeNdCo5oPYWh7/abvYRpZJxlJgv0bwYUG6JUA96CAL/QHhWh9U 8LWV4PBRgf8x/T8lz0GcomEmsSQcSqYLULGeSavdKTlMBrcB+wEZCuSoRAzxmB/URj6c WuKmc6IQRdxQSmja5PEVsRs1l7YOjWXLebE2PbuC1D0zOHfGd4SunHNzwiL6VCf9fbt1 PPnpaSeD2PO6JrqC0G1XHiteSvwJ5KnfFiKmsz6AGBVQUVaf/s7hWHemnmKddZvPqKBC AQOiPeiRNI5zJrPf3EbEonAxEb6T6U8uxcUnYwUFVOUudhdE5Rvr4hDFu+q5sjhpRkqf qqsw== X-Gm-Message-State: AOAM532EoqjcpvfuQs3IqonJe1oB0ROUpxtOUU7Clc3no3+SmRJBgVtu JD/fwVdNslww1DevZxDa/Wo= X-Received: by 2002:a4a:e6d2:: with SMTP id v18mr8270234oot.34.1592676432998; Sat, 20 Jun 2020 11:07:12 -0700 (PDT) Received: from localhost.localdomain (c-24-9-77-57.hsd1.co.comcast.net. [24.9.77.57]) by smtp.googlemail.com with ESMTPSA id y31sm2077901otb.41.2020.06.20.11.07.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jun 2020 11:07:12 -0700 (PDT) From: Jim Cromie To: jbaron@akamai.com, linux-kernel@vger.kernel.org, akpm@linuxfoundation.org, gregkh@linuxfoundation.org Cc: linux@rasmusvillemoes.dk, Jim Cromie Subject: [PATCH v4 10/17] dyndbg: make ddebug_tables list LIFO for add/remove_module Date: Sat, 20 Jun 2020 12:06:36 -0600 Message-Id: <20200620180643.887546-11-jim.cromie@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200620180643.887546-1-jim.cromie@gmail.com> References: <20200620180643.887546-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org loadable modules are the last in on this list, and are the only modules that could be removed. ddebug_remove_module() searches from head, but ddebug_add_module() uses list_add_tail(). Change it to list_add() for a micro-optimization. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index da3ed54a6521..e879af4e66e0 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -895,7 +895,7 @@ int ddebug_add_module(struct _ddebug *tab, unsigned int n, dt->ddebugs = tab; mutex_lock(&ddebug_lock); - list_add_tail(&dt->link, &ddebug_tables); + list_add(&dt->link, &ddebug_tables); mutex_unlock(&ddebug_lock); v2pr_info("%u debug prints in module %s\n", n, dt->mod_name); -- 2.26.2