Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1538217ybt; Sat, 20 Jun 2020 13:24:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzxBFcHucri5i8uQhK65ystwg+RSJbxrCfdkngaOD7/lAUi1hwleO8PMCIOOJd4LHq0Wh3 X-Received: by 2002:a17:906:3745:: with SMTP id e5mr9243880ejc.19.1592684687382; Sat, 20 Jun 2020 13:24:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592684687; cv=none; d=google.com; s=arc-20160816; b=X7Q2mdle8tq3RDUcJ2DCxmp/AChEXbnwMq+ohBSGYxCrIFgLoXA5jkDu6WLMTdw/wq GWa7S91a5xRV7DX8kD4WpN6r5c5Wfbe+SA7SampF7xdx0qjNIsbVYmuFuwmvNDmlnXj/ dkkhjLYe9P0XxeJaMh5mUvqvuKiCiQ/cwAykL7s+vRJDem9ywtv6nk8GC3/67fbbSD7L iJrLMb1xdmZ27BGEehusJefF7hT7VE1f3GZQXFvX1TXLo/r6zNBJ6j9Luz5sUPQgRhxT ZDiZMdDx6Iw1J88EX1EKO5o+Zi7GITfuRNwFHy25MbwU7F994qLz9KrhLfvgmG7g62/1 Wl5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=BWp0+qDm6D8+3mdyev80e+srYJlNGDQfDI6Ux1DPKEI=; b=h+0GfKiDqZa7p0dYaKLq6bFu5S/1PREin3c69Gp/TMozPU5X7uOjSF1yZg1OnfnxgO UMrJTqltflDN+0CTuMylYmltHs3HQ/mI1IPHMgqqP5DW+IObnjgTwk7AzWIeg3Af7s4C sveHGLnQ1KT+mEYyFd4XxB+bN1pNaR/ACY54Zq07dLZheofncpjSMyJCZtFD3QjIaVQY ooG5VVZ8T8uFX8WVfh6DeitGbIHxWNJgFB7t6xcwrER9LOjwe6TfGA3Bi4rlDpwnBMUV FGky1W9wj4ZDZaraTjZOnMlxxbLo5iF8kv97P9Adgwwle+Faf2/7RNYt/3S7HCfTwNvN /dPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="qotg/ZeX"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cm2si5827220edb.370.2020.06.20.13.24.24; Sat, 20 Jun 2020 13:24:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="qotg/ZeX"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728778AbgFTUWf (ORCPT + 99 others); Sat, 20 Jun 2020 16:22:35 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:40491 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728731AbgFTUWf (ORCPT ); Sat, 20 Jun 2020 16:22:35 -0400 Received: by mail-lj1-f196.google.com with SMTP id n23so15190188ljh.7 for ; Sat, 20 Jun 2020 13:22:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BWp0+qDm6D8+3mdyev80e+srYJlNGDQfDI6Ux1DPKEI=; b=qotg/ZeXIPMehWBAckg+OzF18WAadLD8hI2ucC1ErHAe3OF4T+ewG7b8UnXqPIrCJC NffQkxDyfJdTqZmnpSmScWrwE3vt69gKx1J5R+fiooBvd8reKOQJAOwDL2Er7dHcbG6r ujq99H01r7tEQL1RJapvL6hnCqnbi+U0YbRbTY5A4z9aOGUisYrUTF7uERjFvLEEhzQS r8WayBPRqSkjkZSvNs7AVxa4Zk7i7rM1CTDjSYTmrezr0UmbashCHAKHJQWIKZ5B8F6h 50FhDx0XlT5NpnjJ09s6t9wAMWaJCWA9kl1w5ZXxh0f6MAzLvg7sK4mfjwEQKnbMHk3l H7HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BWp0+qDm6D8+3mdyev80e+srYJlNGDQfDI6Ux1DPKEI=; b=e7EWYJGH2QPbCt9DyXCTqvy5syjFP5qV4dQ0dfgGBPthMGCDnjLSOguwKzonL5euCm tHke7FR3IviC+fiowSahokxK5K++BoKRCIQBcU9IyuMmQVGhGMeER9sEZbdudxKnJ6Rp kV1SrWouvZjYYCXq0yDicz+f2yovotahqW2M5nHvvarxQUdKnqzhCkuj4zlx+hxiyljI W8Znf/EPcBm2nZgD+K0z9VfG+HUszVjMt2Jo1lR+TzAlqfNb3gLV3MBCoviFIlrj46JY e02lWjnhSw48pgmmVfNnoqC4F2MvhP6+hI2E42q0Sy+INItrrDzkd0NZzFQmDEo7yNGH x3wA== X-Gm-Message-State: AOAM533Qq1a5lK+UMPTyMrJwecNyOQMVnYK2nW3QTBHXOMGEO70HJZhr QrB8XiNgAeG3672U21QNmJIuLShMFbq7hpoHy1p5zg== X-Received: by 2002:a2e:351a:: with SMTP id z26mr4729522ljz.144.1592684492809; Sat, 20 Jun 2020 13:21:32 -0700 (PDT) MIME-Version: 1.0 References: <20200608104832.1.Ibe95d8f3daef01e5c57d4c8c398f04d6a839492c@changeid> In-Reply-To: <20200608104832.1.Ibe95d8f3daef01e5c57d4c8c398f04d6a839492c@changeid> From: Linus Walleij Date: Sat, 20 Jun 2020 22:21:21 +0200 Message-ID: Subject: Re: [PATCH 1/4] drm/bridge: ti-sn65dsi86: Don't compile GPIO bits if not CONFIG_OF_GPIO To: Douglas Anderson Cc: Andrzej Hajda , Neil Armstrong , Sam Ravnborg , Rob Clark , Bjorn Andersson , Stephen Boyd , Sandeep Panda , kernel test robot , Daniel Vetter , David Airlie , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , "open list:DRM PANEL DRIVERS" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 8, 2020 at 7:48 PM Douglas Anderson wrote: > The kernel test robot noted that if "OF" is defined (which is needed > to select DRM_TI_SN65DSI86 at all) but not OF_GPIO that we'd get > compile failures because some of the members that we access in "struct > gpio_chip" are only defined "#if defined(CONFIG_OF_GPIO)". > > All the GPIO bits in the driver are all nicely separated out. We'll > guard them with the same "#if defined" that the header has and add a > little stub function if OF_GPIO is not defined. > > Fixes: 27ed2b3f22ed ("drm/bridge: ti-sn65dsi86: Export bridge GPIOs to Linux") > Reported-by: kernel test robot > Signed-off-by: Douglas Anderson Fair enough, Reviewed-by: Linus Walleij Yours, Linus Walleij