Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1568289ybt; Sat, 20 Jun 2020 14:31:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzkHi40bBOZwJx6/LpoPL1DiERzKSH0ZFw/x8C1YCLEGuX1alDmi8b9QUZ9NdiHPFv4ShOv X-Received: by 2002:a17:906:cd03:: with SMTP id oz3mr9849052ejb.391.1592688686826; Sat, 20 Jun 2020 14:31:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592688686; cv=none; d=google.com; s=arc-20160816; b=FMj1nndWNcICnFZDDvy6F19dar+IAr07FIExZmosruo1cz6Tkl2I0Ppgfo4Llc+Zy3 N+TejNl4HWU3Q56RKR5WXWjm6b4YzflwTPNVwG/su43YUoLASOJnc/4T5MIhtzSag8ZY +7CUP24TSjxTi1loltM3EIafJWrzQAGFDSKyLQVzHasuKbElEUfZEX4rXRK9xQH8UOfk FV79rLiXg6/4MQdaFhZSS7xAuq00VWrfOKl/fg9JpNWXgLrvQZn1ywmb1uk/Br5PGX/9 8InKXCZeLqniuLQLCz2kZ1VnPXEffGG+C1Fuzqjz80r+CTumgqifvlzsFW9GevYyJaEn 9bgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=doiVnpeZz6EAtF+e39qR7j8SwcJoFsavM/hNbCfLqRM=; b=JwBYlgFfmS7bcTjJKVGpNqKTwHS3ZHlDkaZ/jgNWiyrHbKTDHpY27IDF5FdUKwK5ZH 73ryF4bE+iC2KFnSrVMDMJqz2cOgAvEW1pIzzXitJ1I5+NBS1Vfq0du4yMdO4aar70iA YYzpR1O1hSeonOIOPl0SI/JRjl2BWqRX+qRXF1dDOItXlJEQOcaPFX4X0YAaEQ9/LtqV T5KgY2dbRu+pL0yIaDpNF2ejwaUScYNj7/xbjWjvDTXMY4tzD7R4C4b0JDwWMwfgd77R iurJt5GJy+a28bxnxOMlYMB2eThVKuhTCXABUcFgV/VvvgEu9aceF2HxFAhsYL5p/3JA hehw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dMaCyk5r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p13si6027373ejf.178.2020.06.20.14.31.04; Sat, 20 Jun 2020 14:31:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=dMaCyk5r; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729063AbgFTV2Y (ORCPT + 99 others); Sat, 20 Jun 2020 17:28:24 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:33447 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729017AbgFTV2X (ORCPT ); Sat, 20 Jun 2020 17:28:23 -0400 Received: by mail-lj1-f196.google.com with SMTP id s1so15329813ljo.0 for ; Sat, 20 Jun 2020 14:28:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=doiVnpeZz6EAtF+e39qR7j8SwcJoFsavM/hNbCfLqRM=; b=dMaCyk5rj0t13GaC05m6pfHgrVmAkqDcGWe/Aw36gXR7OcbEAac4PBq6IW1dkGlW8A iNY2Z/fqeyYQCeQS2wSz6HnwCgj7wn503dK/K1XccKAGrOQ3D9/WDTXobNV1QCZtENgM n0LeTgXZ56xLC3oHJGwUgYNIchSHbWcdeax05kfbmx+y/5jlKLBZjk/pwXtQ17NHnBW1 d5U1KDgK43yNdEMyfobXWTZqF8MOMPmie/M3W3lf8F+0+QSg4JVwgfX8gQz/NlJtZPU3 6RVVT4ndlrSTZUnFopUcjCJ2Uxt4XyxtwkWXi3oa3fy4CzD/vviVU/aW305KXamQ14+w 0NHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=doiVnpeZz6EAtF+e39qR7j8SwcJoFsavM/hNbCfLqRM=; b=TTcIZ9CR0uE6XYasiQE3S0miynjxlNig7rEVAJbrheVV8cgQ7Fk7lf1A4AharDHX2w oc3idL6nf867SZxcNrPFObBVseC+UJXe9mx7pb/tF2RJ3Ms/niRvNBlLreeifDZ8i8NQ b1Xroncu3Tz6B3ug4SI/et4hwi6Ef9KbWdVfKgV6savQusA32xYu806rrXVCIpC9/a7C rplcuee12deDrd/aZNb1/gvPv9wVC9ceEtELNF1pg1Njm4kz2ht2peKERkhZrTkjWJXq ooKP6P997+aQiIRRC7bfuME3f97y1SHJeM2QirIvETPJAqWksHwYotMDzFzGZ8dGoFOb qrBA== X-Gm-Message-State: AOAM5320OrBO9Jrn5zC6KCKXTZ3gUhOmA7cv4fQQgTctjxdlNyaAdoQo 1/ciKs5+yAn/cFa2oWRJDz6hA4HCmKQWKxHlbe5sAA== X-Received: by 2002:a2e:a40f:: with SMTP id p15mr5291445ljn.286.1592688439815; Sat, 20 Jun 2020 14:27:19 -0700 (PDT) MIME-Version: 1.0 References: <20200522030743.10204-1-frank@allwinnertech.com> <20200522030743.10204-3-frank@allwinnertech.com> <20200522152803.twvfvuhd6ztunvll@gilmour.lan> <8c7a8eeb-f4ea-4df7-b381-5aeab6dd170a.frank@allwinnertech.com> <20200605151306.kqmyj673kux4sbaa@gilmour.lan> In-Reply-To: From: Linus Walleij Date: Sat, 20 Jun 2020 23:27:08 +0200 Message-ID: Subject: =?UTF-8?B?UmU6IOWbnuWkje+8mltQQVRDSCAyLzRdIHBpbmN0cmw6IHN1bnhpOiBhZGQgc3VwcG9ydA==?= =?UTF-8?B?IGZvciB0aGUgQWxsd2lubmVyIEExMDAgcGluIGNvbnRyb2xsZXI=?= To: Frank Lee Cc: Maxime Ripard , wens , =?UTF-8?B?5p2O5oms6Z+s?= , "robh+dt" , mturquette , sboyd , "p.zabel" , =?UTF-8?B?6buE54OB55Sf?= , linux-arm-kernel , devicetree , linux-kernel , linux-clk , linux-gpio Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 16, 2020 at 11:27 AM Frank Lee wrote: > HI Chen-Yu, Linus, > On Fri, Jun 5, 2020 at 11:13 PM Maxime Ripard wrote: > > > Considering that the same pin has multiple same functions, > > > so add a suffix, like i2s3_dout3 and i2s3_din3? > > > > > > Or specify muxsel in the device tree may be another solution. > > > > Having muxsel is not really an option. We have two sets of bindings to > > maintain already, adding a third one would make it fairly hard to > > maintain. And the second binding we support is the generic pinctrl > > binding, so I'm not really sure why we would want to move away from > > that. > > > > And I'm not really fond of having a suffix either. It kind of breaks the > > consistency we had so far, and ideally I'd like to keep that. > > > > Chen-Yu, Linus? Any input on that one? This is entirely up to the driver maintainer. They need to keep the code together and the naming consistent with how they perceive the hardware works and/or is intended to work. Yours, Linus Walleij