Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1846104ybt; Sun, 21 Jun 2020 01:02:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw/qV+jSRQaEWjWi/MXAon2CS2icAHgmLlsNg7bNDp7tZOcqHGuTBTO0HTsjs8zGq3OXIqO X-Received: by 2002:a17:906:1947:: with SMTP id b7mr10514760eje.320.1592726558555; Sun, 21 Jun 2020 01:02:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592726558; cv=none; d=google.com; s=arc-20160816; b=gejq4RXOnxxsjlqKpLCi3nPnjxC48aM7LTaYDH+QOML+mhdkMwt1c6/3ikE0gyeaVj Pa2B6nn5/WtqPQBMtfJVUTV8qUDzmYra3RmwxFQGIPg3Nw7Vcybcjz1xcYFQ3B/fHI8x EHmBoalr4S2yMRv2EftQn7EdyYOUYZUStvezyI0QYEUwO1wJh+pIiBL57Nvf8dmXLe8s 9LYGTIDeTRQsyOQrNKkxsJ0I+RaWSpMf6Vn/sJV4846zY6iGyLMFchafPIY/tntY43nj HJJpoK5SOEDr6NvWGm/EQ1axTxMUOvnlO0GCOFnJcGlvHE+RPpczZWruspD624O62+4m X0SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=3KPoOm+bLmC1v50pog5fL9P6LrRZAUQ+2yrNP8FscHk=; b=QuWvSx3cGmy9m5PoSXpWQzk0iI/eydODSluoUFZAgsqYnNcuKGEPSYmUbTfBAzY4gj NoeESlVkDuk8g0jDodvVjTJCEigd3gvY5KPFFDT7uAraeJKvoTpv5t2yus1vmKBKsuh2 WyB9DtEScQEGUm8BXq36itZu16f3QpjLrlesSZda90JRZyrTv5m1yQzu8kErubYMJ8hM kHofUeixo3E65aMhYrMfLV/kUNlhWSKASAeQR4qic7ANdMzbClIldF+l4almRnPDGaP5 4ZDv7mR2V1qggM9IoepnFHwLofKZzxA/jAMbPQqVD0cRpM7ChQtSF1P8s66t98oJCUaG lFMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uClYwbC8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gt22si7262006ejb.742.2020.06.21.01.02.04; Sun, 21 Jun 2020 01:02:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uClYwbC8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729455AbgFUH63 (ORCPT + 99 others); Sun, 21 Jun 2020 03:58:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729443AbgFUH62 (ORCPT ); Sun, 21 Jun 2020 03:58:28 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59F27C061794 for ; Sun, 21 Jun 2020 00:58:28 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id m2so6880501pjv.2 for ; Sun, 21 Jun 2020 00:58:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3KPoOm+bLmC1v50pog5fL9P6LrRZAUQ+2yrNP8FscHk=; b=uClYwbC88vxgeN/XT3nnqSsi99mXsXx7ojH/vj7BsASRLl/1OSX16DO3qjAgjwUXlW NO2c6vjdEKZp9y0wUEeNy2TXN/noDCc8TAeDcj2uBnAbNioTFFCXmuwSnPpBhi8tOJm+ ZFlOGKL2zgYdL7zemvAdWgVw7yu+HG5A1P1UOyAqCYKVVmGs512K+iGxl5Dfj16Zf4cd BlghMbYZN8BlrukCS7rPqEvb9L9rft4Kfk01ZJVKYJSOqbHCdl1dxuDtzBI/gC0GrLco 4IKdaK9YiR2neltB+CWcALTR9hkwoRiFIMpV0iA7/UhY8lIfng7vtOt7UaIQZ3oL7nHh XXqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3KPoOm+bLmC1v50pog5fL9P6LrRZAUQ+2yrNP8FscHk=; b=U1Z6bG78jWNfeXmsdGDxVmkvRAZA59iSXlUTjxETgq+ILNPDmkSzgTieuaQTyT3Rc2 VsRS32q7j/l4X7+V9G68gGjGZFYlMmyis+THnxH+zDDFVfXcaGZ5/3NrZ3qtG0CdOBYu Tbxup9Y3r8mOY37TgEgZTiU++QpQtLAoEYRwU9LVs533a0fQkgTSszcYeLF2fbcVoL+M UzkFxmCYQhVREvYi7WTWF9EUDCicn62tYBReeq3Xl5lMu3dnyajYEfUGkYLj42e7NI7r Z7CsBr/m0f+aXFsluZzpUvDaXclWHxMpWx/jpYJu2SK3UMiNAIwYTm1eP6W/EWPD/3Nn tdMg== X-Gm-Message-State: AOAM533uPB6110KRFfnCnAlOFO3zcwAvMqr9sYN0P1Ne6dMDrUSWwcU4 oO9tmldFUYQEcY36tXKphyTLkw== X-Received: by 2002:a17:90a:308c:: with SMTP id h12mr12261894pjb.194.1592726307108; Sun, 21 Jun 2020 00:58:27 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id y6sm10675608pfp.144.2020.06.21.00.58.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jun 2020 00:58:26 -0700 (PDT) Date: Sun, 21 Jun 2020 00:55:39 -0700 From: Bjorn Andersson To: Avri Altman Cc: Rob Clark , Asutosh Das , "cang@codeaurora.org" , "martin.petersen@oracle.com" , "linux-scsi@vger.kernel.org" , linux-arm-msm , Subhash Jadavani , Alim Akhtar , "James E.J. Bottomley" , Bean Huo , Stanley Chu , Tomas Winkler , Colin Ian King , Bart Van Assche , open list Subject: Re: [PATCH v1 1/3] scsi: ufs: add write booster feature support Message-ID: <20200621075539.GK128451@builder.lan> References: <3c186284280c37c76cf77bf482dde725359b8a8a.1586382357.git.asutoshd@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun 21 Jun 00:40 PDT 2020, Avri Altman wrote: > > > > > On Wed, Apr 8, 2020 at 3:00 PM Asutosh Das > > wrote: > > > > > > The write performance of TLC NAND is considerably > > > lower than SLC NAND. Using SLC NAND as a WriteBooster > > > Buffer enables the write request to be processed with > > > lower latency and improves the overall write performance. > > > > > > Adds support for shared-buffer mode WriteBooster. > > > > > > WriteBooster enable: SW enables it when clocks are > > > scaled up, thus it's enabled only in high load conditions. > > > > > > WriteBooster disable: SW will disable the feature, > > > when clocks are scaled down. Thus writes would go as normal > > > writes. > > > > btw, in v5.8-rc1 (plus handful of remaining patches for lenovo c630 > > laptop (sdm850)), I'm seeing a lot of: > > > > ufshcd-qcom 1d84000.ufshc: ufshcd_query_flag: Sending flag query for > > idn 14 failed, err = 253 > > ufshcd-qcom 1d84000.ufshc: ufshcd_query_flag: Sending flag query for > > idn 14 failed, err = 253 > > ufshcd-qcom 1d84000.ufshc: ufshcd_query_flag_retry: query attribute, > > opcode 6, idn 14, failed with error 253 after 3 retires > > ufshcd-qcom 1d84000.ufshc: ufshcd_wb_ctrl write booster enable failed 253 > > > > and at least subjectively, compiling mesa seems slower, which seems > > like it might be related? > This looks like a device issue to be taken with the flash vendor: There's no way for a end-user to file a bug report with the flash vendor on a device bought from an OEM and even if they would accept the bug report they wouldn't re-provision the flash in an shipped device. So you will have to work around this in the driver. Regards, Bjorn > The device reports that it supports wd, but returns inalid idn for flag 0xe... > > Thanks, > Avri