Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1867889ybt; Sun, 21 Jun 2020 01:49:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzIiV4TkQNBZjDvB2IUyGw6LTwKExDxjCMXjLMsmqVtXj/sZdaiLvK58+QFyvDTNF1wvk41 X-Received: by 2002:a05:6402:6d6:: with SMTP id n22mr11990834edy.362.1592729361543; Sun, 21 Jun 2020 01:49:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592729361; cv=none; d=google.com; s=arc-20160816; b=b9ezLolhEPUbZLCGnZKgtD469qX52fMP9H46FcLeKTtnoBlm5ONuoIRDTJH9RbdMHa V1bzoAe3GqqF5GTxZu0QIZkXyygWOP9TLxZUYE6Zn4UL3ehkwJ/OV/pnoEFHUEmVIY9G m/XCfHE8wkS/KvwVfNRFSwgA4/oIfSllZ3YvpfO3pR/gE9SWi3rtjP9n8ikmCptVHMM4 9GoRZGfiYowZ2OPVXjq5y6BmfCsESIycRWb5O33CJqBvOkdLHZ3KLkvOwlxZR0davgqM 0RbN3ZxRmej6keOenhk9GX67edj3Y83Itd7uhPtWOsc6Va24KgGFskzymGGrLb/YiNcw bohA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=FrDbLSJW9s2HKTBcBmkBT7nyml3Kka4J7L2yJm/Ggm0=; b=q79xs3/N60FlIaSkmhcOIbnJCvTl4bQLdAsj8aqQkQKwCOOtMtj8v8vw2A28FzqTKK 0rTqMmbKBF7H2mXg5BYulFHehSaG4HuypkHjhGiPworc12jTCC/fKr7fETWS9KW8jAzW HM37z5f9W+mxAUg8K6Edy/GyV6QSRtLJLQ3ZJTefTo1RNbMBQ8oyiLfEFMik/07CUtPG TQAevHPLqbNLd1RZRTjEgWYc9LQm4h6c1ic8qWC/J0Ir84USEB/dbMfvhk2cNuhsvRHl gKs/GXP1LhXHQgjUM/NRAXKfZRzDYBGVdz8U2t5W4ZER1Xr7+vqn++YL4vKYRE0hVK5V dtgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b7si766957edw.413.2020.06.21.01.48.44; Sun, 21 Jun 2020 01:49:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729542AbgFUIpc (ORCPT + 99 others); Sun, 21 Jun 2020 04:45:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729509AbgFUIpc (ORCPT ); Sun, 21 Jun 2020 04:45:32 -0400 Received: from nautica.notk.org (ipv6.notk.org [IPv6:2001:41d0:1:7a93::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E676BC061794 for ; Sun, 21 Jun 2020 01:45:31 -0700 (PDT) Received: by nautica.notk.org (Postfix, from userid 1001) id 0BA2CC01A; Sun, 21 Jun 2020 10:45:28 +0200 (CEST) Date: Sun, 21 Jun 2020 10:45:13 +0200 From: Dominique Martinet To: Alexander Kapshuk Cc: lucho@ionkov.net, ericvh@gmail.com, davem@davemloft.net, kuba@kernel.org, v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/9p: Validate current->sighand in client.c Message-ID: <20200621084512.GA720@nautica> References: <20200618190807.GA20699@nautica> <20200620201456.14304-1-alexander.kapshuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200620201456.14304-1-alexander.kapshuk@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alexander Kapshuk wrote on Sat, Jun 20, 2020: > Use (un)lock_task_sighand instead of spin_lock_irqsave and > spin_unlock_irqrestore to ensure current->sighand is a valid pointer as > suggested in the email referenced below. Thanks for v2! Patch itself looks good to me. I always add another `Link:` tag to the last version of the patch at the time of applying, so the message might be a bit confusing. Feel free to keep the link to the previous discussion but I'd rather just repeat a bit more of what we discussed (e.g. fix rcu not being dereferenced cleanly by using the task helpers as suggested) rather than just link to the thread Sorry for nitpicking but I think commit messages are important and it's better if they're understandable out of context, even if you give a link for further details for curious readers, it helps being able to just skim through git log. Either way I'll include the patch in my test run today or tomorrow, had promised it for a while... Cheers, -- Dominique