Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1909013ybt; Sun, 21 Jun 2020 03:13:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxSJXVEKju3CjtQ3wyUU2LpLt0aMAk5NL8xPWmcRaZ8OAA2UMKcfdvZ5HrcAwofZGghjMql X-Received: by 2002:a17:906:455:: with SMTP id e21mr149215eja.550.1592734438872; Sun, 21 Jun 2020 03:13:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592734438; cv=none; d=google.com; s=arc-20160816; b=H8FTVxLgKLXQ3MIULBT4+TzK7qnF6nW7wYJyrdXa6ppPC9jIrkNzr/aKeQ8uhDIk9o 4YHh60vZ3xj+eKha+LxmAbDMwNXzJVGwwWWSQHZZrm9EG5tYc0VWb+aWeFGialtodxWn 1+7XWWMZX543YXF/jDXIs0CbOA6VkVJ/iPqQlmB888l5yQWmSvERkCxsvr6WzSxUTLsh hmLw6OyjSIBcDMlNufrB5kpHTnUfqHeFImrsomna0Rlt8cNDWWxgphbtmBVQE1J5DJUY /g6y729JpCkUvDCGR7pvEelIZSIuLpP5x9XyRBIdx3PbpbpRQJFX3uhf0Kg0vw7dD2L+ wofA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=hXCaj+05K3j3ohDduMYvUhwQVadDBgc0NER8cldE3iM=; b=xHWIfut0akI90HFLk4MFtLeJgnfBLWWBxdFB22wYNE8W1lkJPHi4JLa3knQrwjwddx JN4TQWhKEuey9afDMIZcXHo9npKOypm8NfgdgKzff7K4EDJpWSVC3ldoDznuneDZP5Ia mnbmi22ajuK9W+fZIikf9iYPbb5Qd6cwuo5qMPIQuAv+S4YizmSR3FiY4gPIPC/PLQXH eZBhH3QnCCN04wxswwH5Yvwi20lK0md9b/1f7FxaXLgzKdI9vYCRGlmy6Yuv5mqC/L3L vPbExFiccjrrkBj1be3sELo8FGzzVFKFEHu/EXkPnZd7MTV9umvh4JM92mIkLd6MPkAJ XAyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JacV56jN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d20si7493922edq.97.2020.06.21.03.13.36; Sun, 21 Jun 2020 03:13:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JacV56jN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729820AbgFUKLh (ORCPT + 99 others); Sun, 21 Jun 2020 06:11:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729794AbgFUKLe (ORCPT ); Sun, 21 Jun 2020 06:11:34 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D32F8C061794; Sun, 21 Jun 2020 03:11:33 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id a1so878655ejg.12; Sun, 21 Jun 2020 03:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=hXCaj+05K3j3ohDduMYvUhwQVadDBgc0NER8cldE3iM=; b=JacV56jN0UAqIKn/L+yrXZ1YfYh4Q/eYmfobEmxx0heGkHbYeySg4Cj47tcTXnD7mt cCkH53ca4G4ptICTZqM8IM285xnI9ZoY95ylV2hvfwyWAbO+whlUmGqtt+nBn2Kwn3az dFGk7ZLN9aPqsHEXsBlvcgFOZo9k4TIx/dJoKDUyFBvp08Y9Tt/4dK6SVXpnEE6yeuQQ Hpe7P6JmjNampNMDfJ3fgwizQ4xil4HuQIM9wJ8wVq+Phtbq3w524OzD6UTuoSacxepl FhbT3lHYTzE6Iy7EQQAgdwOI9ApgVCt3w0kbtfhY/WGLWB6xSs+rqXPnePfzmfZr4kal d68w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hXCaj+05K3j3ohDduMYvUhwQVadDBgc0NER8cldE3iM=; b=jn+CIIKWhtA2BLfw5S9M5yKazc1q8H3ZQjBp2TO7wTuDN3BteExSbpbswKM5LAy078 JFTLH1NxJJ+7afnZPDMXQNwA/ldljb4FdY4BmecN9Bcv92O89WSxzWQ+/m/7RnaGRM0j c+iFvyY9+l4kmBZsmKARPJWPMb26NP43iG03q9sa4jB4xCzRQeZRQ2JGQn5RiZWZMoF/ BSpeoEwN9IKAhi703kJ2t0wSoH6ZYhpoXKQbLRBzAhRz5/lMoijcD7vopSaLavS9CfMi w7l1eDMheP6bvqN1doJpdTvEpeeclYOx71pECeXw5HrjR9twHQI+sYVVpmIlgA5jEwNR XN5g== X-Gm-Message-State: AOAM532s07cqFhhxxWhSV24jOkYNnwBVelhKju3dHjnyvyQj0PK8trlK WxVC2FVK3s2b+vkzpXTGuBSYZk2+ X-Received: by 2002:a17:906:191a:: with SMTP id a26mr1183980eje.315.1592734292554; Sun, 21 Jun 2020 03:11:32 -0700 (PDT) Received: from localhost.localdomain ([82.209.196.123]) by smtp.gmail.com with ESMTPSA id y26sm9717201edv.91.2020.06.21.03.11.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jun 2020 03:11:32 -0700 (PDT) From: Pavel Begunkov To: Jens Axboe , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] io_uring: kill NULL checks for submit state Date: Sun, 21 Jun 2020 13:09:53 +0300 Message-Id: <4b127f2fd5c4f5587a8c1d497c055cf39ab31cd3.1592733956.git.asml.silence@gmail.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After recent changes, io_submit_sqes() always passes valid submit state, so kill leftovers checking it for NULL. Signed-off-by: Pavel Begunkov --- fs/io_uring.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fs/io_uring.c b/fs/io_uring.c index 676911260f60..0bcf819e9661 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -1371,11 +1371,7 @@ static struct io_kiocb *io_alloc_req(struct io_ring_ctx *ctx, gfp_t gfp = GFP_KERNEL | __GFP_NOWARN; struct io_kiocb *req; - if (!state) { - req = kmem_cache_alloc(req_cachep, gfp); - if (unlikely(!req)) - goto fallback; - } else if (!state->free_reqs) { + if (!state->free_reqs) { size_t sz; int ret; -- 2.24.0