Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750995AbWCZJ05 (ORCPT ); Sun, 26 Mar 2006 04:26:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751104AbWCZJ05 (ORCPT ); Sun, 26 Mar 2006 04:26:57 -0500 Received: from linux01.gwdg.de ([134.76.13.21]:13550 "EHLO linux01.gwdg.de") by vger.kernel.org with ESMTP id S1750995AbWCZJ04 (ORCPT ); Sun, 26 Mar 2006 04:26:56 -0500 Date: Sun, 26 Mar 2006 11:26:41 +0200 (MEST) From: Jan Engelhardt To: Andreas Schwab cc: Nathan Scott , linux-xfs@oss.sgi.com, Linux Kernel Mailing List Subject: Re: Parenthesize macros in xfs In-Reply-To: Message-ID: References: <20060321082327.B653275@wobbly.melbourne.sgi.com> <20060321084619.E653275@wobbly.melbourne.sgi.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 601 Lines: 20 >>>> + swapfunc(a, b, es, swaptype) \ >>>> +} while(0) >>> ^^ >>>Missing semicolon. >> >> It was missing before too. ;) > >No, previously it was provided at the call site. Bad habit IMO. It does not hurt to provide it in both the macro and the call site, GCC can handle empty instructions. Jan Engelhardt -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/