Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 21 Jun 2020 19:46:21 -0400
From:   Sasha Levin <sashal@kernel.org>
To:     Qais Yousef <qais.yousef@arm.com>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Alan Stern <stern@rowland.harvard.edu>,
        Tony Prisk <linux@prisktech.co.nz>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Oliver Neukum <oneukum@suse.de>,
        linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 5.7 229/388] usb/ohci-platform: Fix a warning
 when hibernating
Message-ID: <20200621234621.GC1931@sasha-vm>
References: <20200618010805.600873-1-sashal@kernel.org>
 <20200618010805.600873-229-sashal@kernel.org>
 <20200618095600.umb4gyegy2hszlep@e107158-lin.cambridge.arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20200618095600.umb4gyegy2hszlep@e107158-lin.cambridge.arm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jun 18, 2020 at 10:56:01AM +0100, Qais Yousef wrote:
>Hi Sasha/Alan
>
>On 06/17/20 21:05, Sasha Levin wrote:
>
>[...]
>
>> diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c
>> index 7addfc2cbadc..4a8456f12a73 100644
>> --- a/drivers/usb/host/ohci-platform.c
>> +++ b/drivers/usb/host/ohci-platform.c
>> @@ -299,6 +299,11 @@ static int ohci_platform_resume(struct device *dev)
>>  	}
>>
>>  	ohci_resume(hcd, false);
>> +
>> +	pm_runtime_disable(dev);
>> +	pm_runtime_set_active(dev);
>> +	pm_runtime_enable(dev);
>> +
>
>I am not sure what's the protocol here, but the series was fixing similar
>problems to this driver but I didn't myself directly observe a warning because
>of that.
>
>https://lore.kernel.org/lkml/20200518154931.6144-2-qais.yousef@arm.com/
>https://lore.kernel.org/lkml/20200518154931.6144-3-qais.yousef@arm.com/
>
>So just pointing it out in case they're worth backporting to stable too.

I'll grab them too, thanks!

-- 
Thanks,
Sasha