Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200621213806.551879-1-konradybcio@gmail.com> <20200621213806.551879-4-konradybcio@gmail.com>
In-Reply-To: <20200621213806.551879-4-konradybcio@gmail.com>
From:   Alexey Minnekhanov <alexey.min@gmail.com>
Date:   Mon, 22 Jun 2020 02:49:04 +0300
Message-ID: <CANi4RBR=jYva1-c4fJgNUgRF6g1pNbKR8JmEg_kBfv+QOdLW2g@mail.gmail.com>
Subject: Re: [PATCH 3/8] soc: qcom: socinfo: Add socinfo entry for SDM630
To:     Konrad Dybcio <konradybcio@gmail.com>
Cc:     skrzynka@konradybcio.pl, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Kees Cook <keescook@chromium.org>,
        Anton Vorontsov <anton@enomsg.org>,
        Colin Cross <ccross@android.com>,
        Tony Luck <tony.luck@intel.com>, linux-arm-msm@vger.kernel.org,
        linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,
I also wanted to send this, but in this form:

[PATCH] soc: qcom: socinfo: Add soc information for SDM630/636/660

Add socinfo support for SDM630/636/660.

---
 drivers/soc/qcom/socinfo.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
index 5983c6ffb078..398a3c77954e 100644
--- a/drivers/soc/qcom/socinfo.c
+++ b/drivers/soc/qcom/socinfo.c
@@ -202,8 +202,14 @@ static const struct soc_id soc_id[] =3D {
  { 310, "MSM8996AU" },
  { 311, "APQ8096AU" },
  { 312, "APQ8096SG" },
+ { 317, "SDM660" },
+ { 318, "SDM630" },
  { 321, "SDM845" },
+ { 324, "SDA660" },
+ { 327, "SDA630" },
  { 341, "SDA845" },
+ { 345, "SDM636" },
+ { 346, "SDA636" },
 };

I think it would be great to have all IDs of compatible SoCs at once.

I've tested it on my sdm660 by adding some printks in probe:
[ 1.609040] socinfo: family =3D Snapdragon
[ 1.609043] socinfo: machine =3D SDM660
[ 1.619712] socinfo: soc_id =3D 317
[ 1.630347] socinfo: revision =3D 1.0

=D0=BF=D0=BD, 22 =D0=B8=D1=8E=D0=BD. 2020 =D0=B3. =D0=B2 00:40, Konrad Dybc=
io <konradybcio@gmail.com>:
>
> This patch adds missing soc ID for SDM630.
>
> Signed-off-by: Konrad Dybcio <konradybcio@gmail.com>
> ---
>  drivers/soc/qcom/socinfo.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index 5983c6ffb078..705f142ee588 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -202,6 +202,7 @@ static const struct soc_id soc_id[] =3D {
>         { 310, "MSM8996AU" },
>         { 311, "APQ8096AU" },
>         { 312, "APQ8096SG" },
> +       { 318, "SDM630" },
>         { 321, "SDM845" },
>         { 341, "SDA845" },
>  };
> --
> 2.27.0
>