Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2394080ybt; Sun, 21 Jun 2020 19:07:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLUmHDbJO2mP7F3WlJavqcKu76H0PIcblx2g8ljWjCWcX6mqYSLN4H5Cp+BNRR56nTBtyT X-Received: by 2002:a50:cf05:: with SMTP id c5mr15228867edk.232.1592791643624; Sun, 21 Jun 2020 19:07:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592791643; cv=none; d=google.com; s=arc-20160816; b=bKigfDALq1GBFYHk4psaST8HoOq236QRGYZbPnXNOQpkj92ossOGI3KyEUqJhg3CJq 2QUsXyL9gLzGrspplfShaXzWjyPJgvOvC7aLmi4t7L0poTAK/hFV4VAGr1s35Qe+uoxG lieMDQYzZ62GquAiU544DqXjexArxi8j4J/Z6R+e0L2c3ktCezRkGDcCbTAdSKbDEFX/ AYWnGqNzFGQXpRsig4nj34zQabb/3Pj9yaBRiqKYpnRuXj2pPkgNpvLVijeIf8S5O+mi H99Gx96zBT4NJE+juKpm7EvFYPTj9ZZG/6POVI5ykt7Fnxy8v+XTilmF6pYNixuqLd6y RTpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:to:from :dkim-signature; bh=T9ruRtjScrhQOEGuZPPmv1vIChUuWjpbNJJwO4pbNvQ=; b=xNDmPH8df/tmQxk8RiTt/u4wxJp4QeXO/mnZUMHKfeyKN/AextDnJ2hqGzhLqfIH4D /CB8ze2MnpHup2mEfn02gVj0VHNoFZo6yGPbJdnRJ5w0VqYEwso4ASNF/bMNYeT5HO1i 8xq9OQ9ih+5tMUZLb9J1gVZ4Mw4cKGcoHrQufbwR8x1AWpNC5PYXm96TeXyMhAVDV0j2 X588UJWh09sYwmp7ESRkFMhyvhS0lKbdTZu2eSU8u/V62VteEmOp50dky8lOOSUMClLB r0P/9SM5+ZFD3di/QPG0sXop0/Jp55obElM5Sqv1TBDCLKyVZlw6CXr96XkbPI0jmcSl /MyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gdoVPiFU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i17si8380520eja.574.2020.06.21.19.06.56; Sun, 21 Jun 2020 19:07:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gdoVPiFU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726700AbgFVCEn (ORCPT + 99 others); Sun, 21 Jun 2020 22:04:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726617AbgFVCEn (ORCPT ); Sun, 21 Jun 2020 22:04:43 -0400 Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62AC3C061794 for ; Sun, 21 Jun 2020 19:04:43 -0700 (PDT) Received: by mail-qt1-x82e.google.com with SMTP id i3so2056949qtq.13 for ; Sun, 21 Jun 2020 19:04:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=T9ruRtjScrhQOEGuZPPmv1vIChUuWjpbNJJwO4pbNvQ=; b=gdoVPiFUytVJUybTuMhXWJuTWY749YKQM9niJn7AizMzyyjmipnV7fkCxvOekslzzq GpH2yAVwbL+FY+xD7TnzL1/fwbG8/W/1V7+PeGBqH9k1QA0aUnaa3hmG8kqvVwNae83F A7/KSnAYO7NnVvI95RPTgDb5833KTozwelOWTR3bJ/fJl8mvQ+Br5evhUz1G+9x0S0v+ TlTDUlPPJj6qiJZHn15hRk76OrYFOUoXcd/87tJkWHpFFtXy2CbhmihWvQirKJJxJU0p 6AI6XpybSLzJBMUWDWDUFp2nxlKVis/Qew7SdFi3KPmRK9WhTJxfBYSIfTh5kOsZjPxb hJ7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=T9ruRtjScrhQOEGuZPPmv1vIChUuWjpbNJJwO4pbNvQ=; b=PaYyjewHdz1w07Y4XqejAEBuR86salsToSks8Sp7qei2ljKW0loxkHpw0Ikj8Jo6r/ rc2tFbHhHG1+AEKAGLisTAIHsdIhEFmGN1Orcm2GtHI7XMmdhfEfpr+836Bdduxud6I+ +Em/ISbiyV4VCb/Is4O97iaxxQ+bZdQWvWatt3NR/1ky+MmfXDAQQAcOewNZMD4Il2IE j2ACtqkTAIkYwg65swiAGMuYlRdvamtSQ0AWR2BgJBtVHO7s3b45M/e3gxYGLAxUkACG B+NBF7fH1KPOdu9kasTk6vR0FjWq8wvw+bOtYa5QhIXFxYBslJK3g3mwAAheXhFJHKQE VO2Q== X-Gm-Message-State: AOAM530xT/YoVS7zsj9VFZ99YfFzD7iLL+TSQn6wwqBxEqWQXJHkwdHU 6l3A9XXai5zwkCUIS9N0TpY= X-Received: by 2002:ac8:3778:: with SMTP id p53mr3505416qtb.228.1592791481746; Sun, 21 Jun 2020 19:04:41 -0700 (PDT) Received: from linux.home ([2604:2000:1344:41d:c0e3:b26:d2d0:5003]) by smtp.googlemail.com with ESMTPSA id m128sm11764351qke.90.2020.06.21.19.04.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Jun 2020 19:04:41 -0700 (PDT) From: Gaurav Singh To: gaurav1086@gmail.com, Josh Poimboeuf , Peter Zijlstra , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] [objtoo] fix memory leak in special_get_alts Date: Sun, 21 Jun 2020 22:04:34 -0400 Message-Id: <20200622020434.18159-1-gaurav1086@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Free alt before returning to avoid memory leak. Signed-off-by: Gaurav Singh --- tools/objtool/special.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/objtool/special.c b/tools/objtool/special.c index e74e0189de22..f6f7dee1ba77 100644 --- a/tools/objtool/special.c +++ b/tools/objtool/special.c @@ -188,8 +188,10 @@ int special_get_alts(struct elf *elf, struct list_head *alts) memset(alt, 0, sizeof(*alt)); ret = get_alt_entry(elf, entry, sec, idx, alt); - if (ret) + if (ret) { + free(alt); return ret; + } list_add_tail(&alt->list, alts); } -- 2.17.1