Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2529989ybt; Mon, 22 Jun 2020 00:09:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxVzZ5PosTDlWxNY2EuaeIUUXElf5g7FhzsvoevNnWfyWJf57rWrosbBbpz4tGy5R1nEdWE X-Received: by 2002:a17:906:7712:: with SMTP id q18mr14266061ejm.140.1592809783811; Mon, 22 Jun 2020 00:09:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592809783; cv=none; d=google.com; s=arc-20160816; b=TkyFpSU3SnfmGgpvq/K4xSrqXVK3iQdty29Vz+KkPZyqIzPjfez7u11CxdUAMq8sc1 pjGKqaw7CMh9PZ/I0+BTJVJyW743xvPvlZkM1goYjbyVby6LpbK8cZ3JMH7lTGcDs2/B CDuwCFy+IKAFqCyL/aP7hdSEpBz1rTqv3deg8y/T5ezAaugHuoPq8UudYooy96oZ893E LqH0Ouji/Jh6ZmhL4dNxBOCuGxT4gd0w0Y1E5ES5zE9s/XucN2bXMPk/KpIL8hd0EDNg b8OstG3urq8/ufHc21ghbP7zGxRb1FYYADA5B2j3gSdAnKoKR+bfavZdVDRCbVw52hyZ UmCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=809b0utICez5cFMS5PmWGhMZY+JZDQtjyNoBJHaNEwE=; b=RQGFW5Ji62fSP/aYbp7nTD8AczZHkgKX0fGMJSAZdtRbyNk6ibkiN0KtsR+S0VK4WP PMEhzRldhbJgarm6t5BYBoc5mRyxy0uV14oLEVsrSxujRqeNDbYVaILyl+2ESwjITj+1 taEUo2cZ2rUXkKPm1unOc9nzx+VNJS+BXJe33c89umhQgDrsVXQzRzTNSdswHZrhoePo 6Vx0K2w+UhjpZk2YCdTBW7CSBhVRNshRd5uSwhcHpmwveAitsagPyltFWFXJ+qTmDRsJ Z1FhnrcDO71C4aMkPOSyb8D9V3iOcnuF73EelPK3DTxRkZI94NW5NVGAzovqjd5vjC6U 3b3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x6si985325ejw.73.2020.06.22.00.09.21; Mon, 22 Jun 2020 00:09:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731322AbgFVHHb (ORCPT + 99 others); Mon, 22 Jun 2020 03:07:31 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:6381 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731258AbgFVHHb (ORCPT ); Mon, 22 Jun 2020 03:07:31 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 9387677F378764EFCB63; Mon, 22 Jun 2020 15:07:28 +0800 (CST) Received: from DESKTOP-J8O3A6U.china.huawei.com (10.173.221.213) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Mon, 22 Jun 2020 15:07:22 +0800 From: Xiang Zheng To: , CC: , , Subject: [PATCH] vfio/type1: Add conditional rescheduling after iommu map failed Date: Mon, 22 Jun 2020 15:02:17 +0800 Message-ID: <20200622070217.4768-1-zhengxiang9@huawei.com> X-Mailer: git-send-email 2.15.1.windows.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.173.221.213] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org c5e6688752c25 ("vfio/type1: Add conditional rescheduling") missed a "cond_resched()" in vfio_iommu_map if iommu map failed. This is a very tiny optimization and the case can hardly happen. Signed-off-by: Xiang Zheng --- drivers/vfio/vfio_iommu_type1.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c index 5e556ac9102a..48fb9cc4a40a 100644 --- a/drivers/vfio/vfio_iommu_type1.c +++ b/drivers/vfio/vfio_iommu_type1.c @@ -1225,8 +1225,10 @@ static int vfio_iommu_map(struct vfio_iommu *iommu, dma_addr_t iova, return 0; unwind: - list_for_each_entry_continue_reverse(d, &iommu->domain_list, next) + list_for_each_entry_continue_reverse(d, &iommu->domain_list, next) { iommu_unmap(d->domain, iova, npage << PAGE_SHIFT); + cond_resched(); + } return ret; } -- 2.19.1