Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 22 Jun 2020 10:03:45 +0200
From:   Matthias Maennich <maennich@google.com>
To:     Shuah Khan <skhan@linuxfoundation.org>
Cc:     Julia Lawall <julia.lawall@inria.fr>, linux-kernel@vger.kernel.org,
        kernel-team@android.com, YueHaibing <yuehaibing@huawei.com>,
        jeyu@kernel.org, cocci@systeme.lip6.fr, stable@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] scripts: add dummy report mode to add_namespace.cocci
Message-ID: <20200622080345.GD260206@google.com>
References: <20200604164145.173925-1-maennich@google.com>
 <alpine.DEB.2.21.2006042130080.2577@hadrien>
 <bf757b9d-6a67-598b-ed6e-7ee24464abfa@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <bf757b9d-6a67-598b-ed6e-7ee24464abfa@linuxfoundation.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote:
>On 6/4/20 1:31 PM, Julia Lawall wrote:
>>
>>
>>On Thu, 4 Jun 2020, Matthias Maennich wrote:
>>
>>>When running `make coccicheck` in report mode using the
>>>add_namespace.cocci file, it will fail for files that contain
>>>MODULE_LICENSE. Those match the replacement precondition, but spatch
>>>errors out as virtual.ns is not set.
>>>
>>>In order to fix that, add the virtual rule nsdeps and only do search and
>>>replace if that rule has been explicitly requested.
>>>
>>>In order to make spatch happy in report mode, we also need a dummy rule,
>>>as otherwise it errors out with "No rules apply". Using a script:python
>>>rule appears unrelated and odd, but this is the shortest I could come up
>>>with.
>>>
>>>Adjust scripts/nsdeps accordingly to set the nsdeps rule when run trough
>>>`make nsdeps`.
>>>
>>>Suggested-by: Julia Lawall <julia.lawall@inria.fr>
>>>Fixes: c7c4e29fb5a4 ("scripts: add_namespace: Fix coccicheck failed")
>>>Cc: YueHaibing <yuehaibing@huawei.com>
>>>Cc: jeyu@kernel.org
>>>Cc: cocci@systeme.lip6.fr
>>>Cc: stable@vger.kernel.org
>>>Signed-off-by: Matthias Maennich <maennich@google.com>
>>
>>Acked-by: Julia Lawall <julia.lawall@inria.fr>
>>
>>Shuah reported the problem to me, so you could add
>>
>>Reported-by: Shuah Khan <skhan@linuxfoundation.org>
>>
>
>Very cool. No errors with this patch. Thanks for fixing it
>quickly.

I am happy I could fix that and thanks for confirming. I assume your
Tested-by could be added?

Is somebody willing to take this patch through their tree?

Cheers,
Matthias

>
>thanks,
>-- Shuah
>
>
>