Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2560898ybt; Mon, 22 Jun 2020 01:13:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz1YysUNFoX9pUS6dnD+dSd3wfIKDwYIsvTJ9s2EIux1wrK2vKmYrlJsuhQ0qMoR5EJNnIY X-Received: by 2002:a17:906:2b0e:: with SMTP id a14mr1929603ejg.459.1592813605879; Mon, 22 Jun 2020 01:13:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592813605; cv=none; d=google.com; s=arc-20160816; b=SigUIud+hJKGRH0yDMgPQ0c9UIiTeyDpAmGnA3xxB8y172DcicqwAjxcL9dT5tDlC9 lVKv4mlhxSepKPrAsWAp+hvCeiDkwH/RkZhueHqXlAZhZZhDExnJEEV9O36RiRlCIzoz d7Zxic6rnmVa6qczAZAanng2vbuSzUS9mN55yg9Z+KRBXtbSDjtBZCxs8l2c1+3RuFRq qBJhwg/X5reNhhvxqaeTPPpEBrLtU0y8JqxVWn7IhMFv68u88zICDogkr50f6TxuoCJQ tGQc1XFqnctSHANP285qfKvlEilxNE0k1LF6Evcq0iFNUPka4ykc9gFittq+YCvQuiEs EykA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=lPM2dXcZWsfdanvmWpEJKe0oZi4Qaag02Vnv/2CyipI=; b=mr05IjoZzYOY6MX0Bpx8aWE4mKIOpT0iIZJI5FJBCEAhW2y5u7XXWlM/Hcrn/Ow7t2 Ljiqi5IsRKUR3bUu8w8By1g/CH7JRlYUz0xByJiymNuohJbBzXANZViLuTNUJit0WPpp 0WSMkgplCRtmuU5Hhdjw5XXHx96uEZrZSjS8IL1BfSzciP+JVeFd3q2caMgtvzW+6xNH Y/YVgrjtkn3iOF9e9NVeYndSKsNMaZiQdhnzzEH4KZ4FBK8PNvPXc+trhLRW4MCixapD /J//+b0uW62m93tvWda/a0v0dqd2trHbLS+fq53VaLFNmirNLLVZ+2F7SfrDdCvnujFG EheA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cnVX3sYP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v23si8357536eju.572.2020.06.22.01.13.03; Mon, 22 Jun 2020 01:13:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cnVX3sYP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726787AbgFVIJ5 (ORCPT + 99 others); Mon, 22 Jun 2020 04:09:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726616AbgFVIJS (ORCPT ); Mon, 22 Jun 2020 04:09:18 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EDF2C061795 for ; Mon, 22 Jun 2020 01:09:18 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id 17so194916wmo.1 for ; Mon, 22 Jun 2020 01:09:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=lPM2dXcZWsfdanvmWpEJKe0oZi4Qaag02Vnv/2CyipI=; b=cnVX3sYPQCbhNmRKFn9tmv4J3PekwjpwF6bfi8cMBn2SGOb6LT/dVyM7wombRqgxpA is2ldG64YjU0yLCBODga9bjLY4rweVKScALDadK0DPBSHD4GQOASqFj2EfFbNg8jF5lQ hxWMa9gmc6n2o6E0PbjkRrnQOmKKOs/aagbN1jFEHRseJdungrzUTi2gvS28rxskZBwm lZ0woZ21p3kH6TUzjauOlKzuWgYiN79rDsW4inREu727cglKBj0bkV/0h9HnUAX29Hqw AeJcAhMaKyMZdK+GnP4kqbAz2ECNuKxVqw4mPqXf2oOYLgMcPpQostHQYYi1s3+TjFlr 3PEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=lPM2dXcZWsfdanvmWpEJKe0oZi4Qaag02Vnv/2CyipI=; b=NTwTCPLAOU+nVvJkdUgincC0F8LNjbFidSN+ruR6eSC4wptottzjH5Y/h8ig1Uh88p wDRquV+yabotqhFSsbOUQ58xPov38CM0ynjTMI4hpot+vVeQyBnIaZlqwcnKmX7NbYA/ PAOLiKKyD7IDzNW7WoM6FS3EaM8ETFu5op+1hpm+PLR3FXqvy+rLVu0jS2rzBo5zzQDP 4OHUDKGIL6sFFazWMwziUom7uWfdzOvj47cALzgDIzMBOJ9Xd3WfxG9pFE5qJzsEgmcb ajmavcOkkf7GdY7TRcS4ktzX6BfeJ+PRtbZu3byD40ncCbuCAVB/N5vRKYtsEc6anlaz bppg== X-Gm-Message-State: AOAM530/+D/CHxhc3T2Zh2vRiyOoLNh+4xjbFNAuNa/B3ts28vAwsOtR 4mixcXrc3blRt5eXJtn/2Pn6JA== X-Received: by 2002:a1c:9cd3:: with SMTP id f202mr16240567wme.64.1592813356869; Mon, 22 Jun 2020 01:09:16 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x18sm5883006wrq.13.2020.06.22.01.09.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2020 01:09:16 -0700 (PDT) Date: Mon, 22 Jun 2020 09:09:13 +0100 From: Lee Jones To: andy.shevchenko@gmail.com, michael@walle.cc, robh+dt@kernel.org, broonie@kernel.org, devicetree@vger.kernel.org, linus.walleij@linaro.org, linux@roeck-us.net, andriy.shevchenko@linux.intel.com, robin.murphy@arm.com, gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes Message-ID: <20200622080913.GO954398@dell> References: <20200611191002.2256570-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200611191002.2256570-1-lee.jones@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 11 Jun 2020, Lee Jones wrote: > Currently, when a child platform device (sometimes referred to as a > sub-device) is registered via the Multi-Functional Device (MFD) API, > the framework attempts to match the newly registered platform device > with its associated Device Tree (OF) node. Until now, the device has > been allocated the first node found with an identical OF compatible > string. Unfortunately, if there are, say for example '3' devices > which are to be handled by the same driver and therefore have the same > compatible string, each of them will be allocated a pointer to the > *first* node. Any more reviews/comments before I apply this? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog