Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751248AbWCZOXO (ORCPT ); Sun, 26 Mar 2006 09:23:14 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751251AbWCZOXO (ORCPT ); Sun, 26 Mar 2006 09:23:14 -0500 Received: from cantor.suse.de ([195.135.220.2]:4324 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S1751248AbWCZOXO (ORCPT ); Sun, 26 Mar 2006 09:23:14 -0500 From: Andreas Schwab To: Jan Engelhardt Cc: Nathan Scott , linux-xfs@oss.sgi.com, Linux Kernel Mailing List Subject: Re: Parenthesize macros in xfs References: <20060321082327.B653275@wobbly.melbourne.sgi.com> <20060321084619.E653275@wobbly.melbourne.sgi.com> X-Yow: All of a sudden, I want to THROW OVER my promising ACTING CAREER, grow a LONG BLACK BEARD and wear a BASEBALL HAT!! ... Although I don't know WHY!! Date: Sun, 26 Mar 2006 16:23:12 +0200 In-Reply-To: (Jan Engelhardt's message of "Sun, 26 Mar 2006 11:26:41 +0200 (MEST)") Message-ID: User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1012 Lines: 29 Jan Engelhardt writes: >>>>> + swapfunc(a, b, es, swaptype) \ >>>>> +} while(0) >>>> ^^ >>>>Missing semicolon. >>> >>> It was missing before too. ;) >> >>No, previously it was provided at the call site. > > Bad habit IMO. It does not hurt to provide it in both the macro and > the call site, GCC can handle empty instructions. There is no way to provide the missing semicolon at the call site. swapfunc can't provide it either, since it's not a macro. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstra?e 5, 90409 N?rnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/