Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2690893ybt; Mon, 22 Jun 2020 04:50:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwmzZ10QXyo4tlR5U7lqDM4Vw8Asim9P0P9EGf4Fg71Qm5sYVAVLGWj/MifQyg2/uu9uU7G X-Received: by 2002:a17:906:3fd2:: with SMTP id k18mr5639097ejj.387.1592826656080; Mon, 22 Jun 2020 04:50:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592826656; cv=none; d=google.com; s=arc-20160816; b=Wg8xvHAibpsPmJGOq3zi48RENXaKZbJ6cIEo+sViy1DcNKqUz3vt9eqkZKTtgo85L1 A39Rj5gIJAIwrGSnvytJSKtOeMVjRc+iJT5bcGThqCavrKSCudLeR0ViyOT5FEb0Anei krGuF9vNJMDXtQlfwX7AaPBLJzWWzUMm+yQ2i9jrdcJsXK+i97aeZaSkoVwwAUJPgSV/ 46/DTudW97D07pzKZ9+j8BBRT72y1CEFLV2ngmXNY/gb7tfAn91MP0MYnqV07ycolfEg XFDLieNi9G0phwmLNWVLhbhvnQdOTKSknseQOtm8UUmWsEEhpaNxCf0GTorGxbpRvPAM QF2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:from:subject:mime-version :message-id:date:dkim-signature; bh=j19qINoTS0ZUB5VmYI6tnBHGsC7YwPPKrYVY46VAbqw=; b=Lp9r60ygSZ9iSnrWpsAAu1O0LsGHbr9wokt98MAPS3x8m6gNJ0ahSigObl62bsQymK 8Qp/nyIwxpo+mNnr11JJ8imAkTu+d6L0MIfzUnBMCWy4CJBA33NoENK/SrPblcyioBXi N9fcdmxkLCY9e+GY5D2KjxWoIh0M74QSUlWm5incKGLZAzuqSxUR+wlsnEqwIw9JuhZQ zIwekxAelxL074g14T4qUf4JVWg4CQVVa+I7D6nVk0MU3xDBrCKBjgHk6i1CGjF0IF8a e7WCHypo+k+PH8K0b8IBZbaPkPKS/kSu2CoLpR3nvNMjWc8Rr+FY3tmovqTmc7EKgFwM KcWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=TLI75zhb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l6si2202169ejx.493.2020.06.22.04.50.33; Mon, 22 Jun 2020 04:50:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=TLI75zhb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727962AbgFVLqx (ORCPT + 99 others); Mon, 22 Jun 2020 07:46:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727120AbgFVLqw (ORCPT ); Mon, 22 Jun 2020 07:46:52 -0400 Received: from mail-qv1-xf49.google.com (mail-qv1-xf49.google.com [IPv6:2607:f8b0:4864:20::f49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77DC0C061794 for ; Mon, 22 Jun 2020 04:46:52 -0700 (PDT) Received: by mail-qv1-xf49.google.com with SMTP id v1so12436043qvx.8 for ; Mon, 22 Jun 2020 04:46:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=j19qINoTS0ZUB5VmYI6tnBHGsC7YwPPKrYVY46VAbqw=; b=TLI75zhb3hcV71NRaoY51FnnY5U5mwBw4h8IRj01n/GB6WFaLkNAhOJ8mnrRi3Kt3U D5/gxSxGrus9cNQo5m1Gcy6XqXBDCOw3JYI8VmnY7KeZnA7NkePDxNoyI09U/OSYdl2+ hZ/u5zK+54x66LU6Nq3QU4GNpunW1AZfRo/MZdfk+il4B1WHnDB1+DQ7fPll1n+1XZ+L y6GDaAQ/h9xMJ4jkd550Ctde6Of3UWj0ud5H+4FdWvJ7l8GD/L64pmBh0KUAiTwOsVGu PIXKyL4z1yLzsRB7rNwGrL+OhEOFvq49zwARR2aWdduxZjBc784HqWV1e9Xm+McOFmSC UTrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=j19qINoTS0ZUB5VmYI6tnBHGsC7YwPPKrYVY46VAbqw=; b=egZ7OXYElDOd6i54z1Q+pw50pRAAX7YigI6cV3ZlMB4FQq6j3HQUn6MwhUYmthvycE erejC+WgUX3OTG41xFRiNQWzNMZKwRGMSHVzYcSBFyPZlPL7Aw/xKt52i7SbkXImq3hI SVmXIhoa0MWE9bPWnYD1EClVm76DR1CAE9fUo3scWPYeCOBrd1i7FGQpT5pQpd9IryqV sUHmiejxJGcZqKDZBJW2FcosQx2VYPU48ztO0/hV9EhZmDHwgC7+io6oKX7F4EC/JArd 0gpbdPYSgFikaBeMG9PEYG1jTLD80Mw091Zs8I3JFLSYYc2V5ThGoFHdG3CFcoRdUgkb oQPg== X-Gm-Message-State: AOAM5331ed1vfGRwF9/mP4K3Jj+C3AKoeRkZk8b8ZvVd3aNDeYK/JHrP pNJpJL+DP+Ov9BnMyIz9sxhCzmcEFLI= X-Received: by 2002:a0c:8d46:: with SMTP id s6mr21215475qvb.241.1592826411606; Mon, 22 Jun 2020 04:46:51 -0700 (PDT) Date: Mon, 22 Jun 2020 13:46:36 +0200 Message-Id: <20200622114639.165874-1-darekm@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.27.0.111.gc72c7da667-goog Subject: [PATCH v2] media: cros-ec-cec: do not bail on device_init_wakeup failure From: Dariusz Marcinkiewicz To: linux-media@vger.kernel.org Cc: narmstrong@baylibre.com, Dariusz Marcinkiewicz , Hans Verkuil , Mauro Carvalho Chehab , Benson Leung , Enric Balletbo i Serra , Guenter Roeck , Lee Jones , Sebastian Reichel , Dariusz Marcinkiewicz , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Do not fail probing when device_init_wakeup fails. device_init_wakeup fails when the device is already enabled as wakeup device. Hence, the driver fails to probe the device if: - The device has already been enabled for wakeup (by e.g. sysfs) - The driver has been unloaded and is being loaded again. This goal of the patch is to fix the above cases. Overwhelming majority of the drivers do not check device_init_wakeup return code. v2: add Fixes tags Fixes: cd70de2d356ee ("media: platform: Add ChromeOS EC CEC driver") Signed-off-by: Dariusz Marcinkiewicz --- drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c index 0e7e2772f08f..2d95e16cd248 100644 --- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c +++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c @@ -277,11 +277,7 @@ static int cros_ec_cec_probe(struct platform_device *pdev) platform_set_drvdata(pdev, cros_ec_cec); cros_ec_cec->cros_ec = cros_ec; - ret = device_init_wakeup(&pdev->dev, 1); - if (ret) { - dev_err(&pdev->dev, "failed to initialize wakeup\n"); - return ret; - } + device_init_wakeup(&pdev->dev, 1); cros_ec_cec->adap = cec_allocate_adapter(&cros_ec_cec_ops, cros_ec_cec, DRV_NAME, -- 2.27.0.111.gc72c7da667-goog