Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2691632ybt; Mon, 22 Jun 2020 04:52:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzGjvph00RGaR7f5gCa2Q4XunJGtAxhatnIDnn8fpqnWxpKtYSUBpODfLC7+CoSiRJrMys X-Received: by 2002:aa7:de08:: with SMTP id h8mr16066838edv.164.1592826735814; Mon, 22 Jun 2020 04:52:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592826735; cv=none; d=google.com; s=arc-20160816; b=dIfXxfR9oNer8ttHK0NUYHRwW51ZTVEpLMRc/35hmDJcZy5tYzvDfm2kunBMRkQ346 OvllyD8778c1BgcHs4Z9anP1Wr8PdCAQ4gYTeRpg1DenJ8MLgc1mZDxHPpi8pdPZlw8U y1k19y4YBE0QZSjsQ5qABYddG/3fzlMrEVK7+qPOA8H/NpeBncgkTZzSo5x0xB85jWCy xd7vyW82gQKYMUssZbjCekJk94+6tkAsgeUYwqzX5+1+Yp1LIlj+SA/8cxcSJHqGoLf2 9YKuPY8d2hbIWcYrS47iK+Qd4aOqiw8EjPRS05ov5XoLRhgOqMyP6hTUBxNp/ILBgNRA djug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=fH4rNdOd/0DtPCmm7DTynSkeo7LxPbR8dmKw5LybOyU=; b=cL5fmlPy+S/HnWWtEI4Dd2XhMGLk0o9Ny5Kefso66fsmy/BUsLjt4VhlwfwQr92yf3 i36lANWdKFQr0EHX3Q+1vq4gT36YgKW1hvcWgwH1o5sCjpNn2y9MN+58FWgDyIdDdB3f YOwsKPLkejB5sth3flQxIlJaV5TQ7orxRN77ZQq2hKvMKZcwCaVl/p1Dp+tTBRNQb7XQ T4OozUvX6vT/nmSb8LPl04PPD6spEPn/v8LPvonI/FOzMhfkWi/bf5lumW6Ry4EHZvv1 1+KMy+3gZ1j8MUwzei0Wd8kWnCxcrMjd828WqAnr9OQaKCdL369P6mTw6QZaTA+bn8zS neLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tessares-net.20150623.gappssmtp.com header.s=20150623 header.b=VAmdyUsd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y16si9429927edw.311.2020.06.22.04.51.53; Mon, 22 Jun 2020 04:52:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@tessares-net.20150623.gappssmtp.com header.s=20150623 header.b=VAmdyUsd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727970AbgFVLuD (ORCPT + 99 others); Mon, 22 Jun 2020 07:50:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727838AbgFVLuD (ORCPT ); Mon, 22 Jun 2020 07:50:03 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 049B8C061795 for ; Mon, 22 Jun 2020 04:50:03 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id w6so6364248ejq.6 for ; Mon, 22 Jun 2020 04:50:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tessares-net.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fH4rNdOd/0DtPCmm7DTynSkeo7LxPbR8dmKw5LybOyU=; b=VAmdyUsdN2ivud7I3BUybzNsHUoWtcliplXD1llq7mJ8rXj6Yo00x/zDCgoW7dvJeV bhrmghsAG/kmbv4PKQNP/hIEvYBKYjzOlcxtFTHzuS3ulJEruyYSfW1tK/X6fno65QdL qnfg0dy/L76P/M9ECK0zlhiG8aheuE+2YUtCMJTyr3n5plQwKFuw3oWCZYwcnuuqxsgL 7q32ZjqiNBAVsBojvHKsSkHZ7gAs6Pqa8lhXxbjphHS0h//reFYJvRb03tU6hsUe8HqA YVrWpKm4Kms6Vt9bS6CbNfD9kNhp4T1vii7iuR0sP9gbCfcvSwHb0lSkH/j2kbiQK3Dk uhQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fH4rNdOd/0DtPCmm7DTynSkeo7LxPbR8dmKw5LybOyU=; b=GsnTR6Rb++sQ2Ythnjlh5r/WoSgOr3sTSHxmhDZr3bQ/nx6OukOJrXmFuMZ/p+A5Hc odvDpwdjAkkHRwPbyv4/dKFwr9BKWY1cpFpvNidV3dJt7axC8x4UFfydZ223DirQg3UL 1yUYoWaDwMEqDb55zQpAyKMJkWXq3gLV/d2qv+94hPYDebvVXL8fzyneyOHf+x3DAkee gZcBNUzyqpE/0mzvq99be/WvOah0+LTB4xJUVmnWveLYfgGRsH73RT2FG8fHw0RWuuLW 4ScAp2ISju8nd4NVmTPx+KQI4zJOC14Iou6QKJ7bEBOUT/QaqfFnrzUIDKYZzknxJsWL s+EA== X-Gm-Message-State: AOAM533UTDJ4QMwjC4DUIBdLK8YRDtJAddK8NcuaMV6kSj8ee+aGO/TL cwI8LieD/2G/INpt9DN8I5K92t5l7uo= X-Received: by 2002:a17:906:3c10:: with SMTP id h16mr9735413ejg.87.1592826601230; Mon, 22 Jun 2020 04:50:01 -0700 (PDT) Received: from tsr-lap-08.nix.tessares.net ([81.246.10.41]) by smtp.gmail.com with ESMTPSA id s2sm12389468edu.39.2020.06.22.04.50.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2020 04:50:00 -0700 (PDT) Subject: Re: [PATCH net v2] mptcp: drop sndr_key in mptcp_syn_options To: Geliang Tang , Mat Martineau , "David S. Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, mptcp@lists.01.org, linux-kernel@vger.kernel.org References: <60f8315d6ae7b62d175c573f75cee50f14ce988b.1592826171.git.geliangtang@gmail.com> From: Matthieu Baerts Message-ID: <1c0f6f37-ede8-b341-f274-2b65b17dc141@tessares.net> Date: Mon, 22 Jun 2020 13:50:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <60f8315d6ae7b62d175c573f75cee50f14ce988b.1592826171.git.geliangtang@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geliang, On 22/06/2020 13:45, Geliang Tang wrote: > In RFC 8684, we don't need to send sndr_key in SYN package anymore, so drop Please next time try to have max 72 chars per line in your commit message ;) > it. > > Fixes: cc7972ea1932 ("mptcp: parse and emit MP_CAPABLE option according to v1 spec") > Signed-off-by: Geliang Tang Thank you for this v2. It looks good to me! Reviewed-by: Matthieu Baerts Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net