Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2711385ybt; Mon, 22 Jun 2020 05:18:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVfAd/LnWAnlxWQz7ehJI/cAFgPBMUoHs8Z3D4J8S2ZeqZ0xbphv2DZfMtwFKdecvxVI8M X-Received: by 2002:a17:906:8387:: with SMTP id p7mr15145888ejx.323.1592828291864; Mon, 22 Jun 2020 05:18:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592828291; cv=none; d=google.com; s=arc-20160816; b=wZfcgieDVs49YoNyFGjmW4lQuyiNz/CKZprtC2IEooED4iZltMa/lOjTdAPFFlq6FP FhDcH6F9BDS8cFt5PmpMFtKreJLo72ywdVome4x196GRHctZCjhhVVhv7hWhszHbGbqI EKwUPmg1Km7Jfx4/q6ueEsoMSTh7OPTgvEM4PeBCu9BnMbbK3ATzrS3VtJ7L/2JzILrR +LyjVKaozbJz6yyWlBucgJZzlQzLnsP9zHTVOtQSZ3oDeAAfsMffY4rzBgk1GajRol49 T8E/x7ON19jizJ+xHK6qCqVxwVGmtJyonvTuBBc4rhwIJMK9iJTd+C4N+VX8FFw0lKiQ tfGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:reply-to; bh=hQzYMaUlZUDlc8Lem8l9/7cthTQDrT2IC1P1jvMCOQw=; b=pBmiD2SClM74RylAVi+jGamZtHaBUXDEb9HbQS+srpZ/foPKQZgRerC1eVS3T1I3jh qmB9Yzd+OnpXKgcjMVU/UZLg1+bhuDnTUkL4hrxRVl2gF7rb57svHZwWVs2KN2l8Ho3Y zn+E06jdCea/9Aj4yKpO4ZjfscIFTMauyS65ry7EnTi/JBcukjL0tsGu6/HMZaKOmLY2 FZ1VdmZjsHYIpESvJ+TdB7fH1oAZaZsR9dSi0hLvP+IiTEo2xIZaG1dv+TR4WH/RKaNi rJgYLnuOS2tHrO+rP3DZ6/rJ5k2k5FZ3m73wh5BjpYkRn1b+kl4pFpN1diM8UA678RzI xgFg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v23si8637659eju.572.2020.06.22.05.17.48; Mon, 22 Jun 2020 05:18:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728042AbgFVMP4 (ORCPT + 99 others); Mon, 22 Jun 2020 08:15:56 -0400 Received: from mail-ed1-f48.google.com ([209.85.208.48]:44931 "EHLO mail-ed1-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726947AbgFVMPz (ORCPT ); Mon, 22 Jun 2020 08:15:55 -0400 Received: by mail-ed1-f48.google.com with SMTP id s28so13416234edw.11 for ; Mon, 22 Jun 2020 05:15:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=hQzYMaUlZUDlc8Lem8l9/7cthTQDrT2IC1P1jvMCOQw=; b=Dtr8IYktUZfhlUZhlXZK2CNk58bd23iVdkSg6gPBTMh/lqABrZqPti7GogH8EytJzD yorQIITXTmTs2SBHV8oYJMW1Ts9CVoHQaueOwhoCE6n4DoPp0k2MAUspzxUOZQdZULpp SZaBUXceKuoo11p2qIqDQVlFnCEFaRpKLf5eduo15TsyvMDE899MaFNG6Sv/rDngZUeC p80XB1Q+BWIeGa96R4QQSJdRSV7Ayk6wMxYyKoHu/Oa6kMVBZxFRJbtPEYHeB+Gidk2Q KjqmO22Fd2ee6CrmpIr37dpFFSAg3ywO0UxLaG/kkNYWHOCzLEZycsZVwEZqw8yqzrLm XzOg== X-Gm-Message-State: AOAM533WfNopHzB0yQiGDZq/MAXKc7B3j16uw2/WhjSzOxD3IblsPH0z akSAThAWgR8TjyggIvkU+eK2pyTobNPWgw== X-Received: by 2002:aa7:d98e:: with SMTP id u14mr17025220eds.247.1592828153714; Mon, 22 Jun 2020 05:15:53 -0700 (PDT) Received: from [10.68.32.147] (broadband-37-110-38-130.ip.moscow.rt.ru. [37.110.38.130]) by smtp.gmail.com with ESMTPSA id j3sm12254485edr.87.2020.06.22.05.15.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2020 05:15:53 -0700 (PDT) Reply-To: efremov@linux.com Subject: Re: [Cocci] [PATCH v3] coccinelle: misc: add array_size_dup script to detect missed overflow checks To: Julia Lawall Cc: Kees Cook , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org References: <20200615102045.4558-1-efremov@linux.com> <20200619131313.15468-1-efremov@linux.com> From: Denis Efremov Autocrypt: addr=efremov@linux.com; keydata= mQINBFsJUXwBEADDnzbOGE/X5ZdHqpK/kNmR7AY39b/rR+2Wm/VbQHV+jpGk8ZL07iOWnVe1 ZInSp3Ze+scB4ZK+y48z0YDvKUU3L85Nb31UASB2bgWIV+8tmW4kV8a2PosqIc4wp4/Qa2A/ Ip6q+bWurxOOjyJkfzt51p6Th4FTUsuoxINKRMjHrs/0y5oEc7Wt/1qk2ljmnSocg3fMxo8+ y6IxmXt5tYvt+FfBqx/1XwXuOSd0WOku+/jscYmBPwyrLdk/pMSnnld6a2Fp1zxWIKz+4VJm QEIlCTe5SO3h5sozpXeWS916VwwCuf8oov6706yC4MlmAqsQpBdoihQEA7zgh+pk10sCvviX FYM4gIcoMkKRex/NSqmeh3VmvQunEv6P+hNMKnIlZ2eJGQpz/ezwqNtV/przO95FSMOQxvQY 11TbyNxudW4FBx6K3fzKjw5dY2PrAUGfHbpI3wtVUNxSjcE6iaJHWUA+8R6FLnTXyEObRzTS fAjfiqcta+iLPdGGkYtmW1muy/v0juldH9uLfD9OfYODsWia2Ve79RB9cHSgRv4nZcGhQmP2 wFpLqskh+qlibhAAqT3RQLRsGabiTjzUkdzO1gaNlwufwqMXjZNkLYu1KpTNUegx3MNEi2p9 CmmDxWMBSMFofgrcy8PJ0jUnn9vWmtn3gz10FgTgqC7B3UvARQARAQABtCFEZW5pcyBFZnJl bW92IDxlZnJlbW92QGxpbnV4LmNvbT6JAlcEEwEIAEECGwMFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4ACGQEWIQR2VAM2ApQN8ZIP5AO1IpWwM1AwHwUCXsQtuwUJB31DPwAKCRC1IpWwM1Aw H3dQD/9E/hFd2yPwWA5cJ5jmBeQt4lBi5wUXd2+9Y0mBIn40F17Xrjebo+D8E5y6S/wqfImW nSDYaMfIIljdjmUUanR9R7Cxd/Z548Qaa4F1AtB4XN3W1L49q21h942iu0yxSLZtq9ayeja6 flCB7a+gKjHMWFDB4nRi4gEJvZN897wdJp2tAtUfErXvvxR2/ymKsIf5L0FZBnIaGpqRbfgG Slu2RSpCkvxqlLaYGeYwGODs0QR7X2i70QGeEzznN1w1MGKLOFYw6lLeO8WPi05fHzpm5pK6 mTKkpZ53YsRfWL/HY3kLZPWm1cfAxa/rKvlhom+2V8cO4UoLYOzZLNW9HCFnNxo7zHoJ1shR gYcCq8XgiJBF6jfM2RZYkOAJd6E3mVUxctosNq6av3NOdsp1Au0CYdQ6Whi13azZ81pDlJQu Hdb0ZpDzysJKhORsf0Hr0PSlYKOdHuhl8fXKYOGQxpYrWpOnjrlEORl7NHILknXDfd8mccnf 4boKIZP7FbqSLw1RSaeoCnqH4/b+ntsIGvY3oJjzbQVq7iEpIhIoQLxeklFl1xvJAOuSQwII I9S0MsOm1uoT/mwq+wCYux4wQhALxSote/EcoUxK7DIW9ra4fCCo0bzaX7XJ+dJXBWb0Ixxm yLl39M+7gnhvZyU+wkTYERp1qBe9ngjd0QTZNVi7MbkCDQRbCVF8ARAA3ITFo8OvvzQJT2cY nPR718Npm+UL6uckm0Jr0IAFdstRZ3ZLW/R9e24nfF3A8Qga3VxJdhdEOzZKBbl1nadZ9kKU nq87te0eBJu+EbcuMv6+njT4CBdwCzJnBZ7ApFpvM8CxIUyFAvaz4EZZxkfEpxaPAivR1Sa2 2x7OMWH/78laB6KsPgwxV7fir45VjQEyJZ5ac5ydG9xndFmb76upD7HhV7fnygwf/uIPOzNZ YVElGVnqTBqisFRWg9w3Bqvqb/W6prJsoh7F0/THzCzp6PwbAnXDedN388RIuHtXJ+wTsPA0 oL0H4jQ+4XuAWvghD/+RXJI5wcsAHx7QkDcbTddrhhGdGcd06qbXe2hNVgdCtaoAgpCEetW8 /a8H+lEBBD4/iD2La39sfE+dt100cKgUP9MukDvOF2fT6GimdQ8TeEd1+RjYyG9SEJpVIxj6 H3CyGjFwtIwodfediU/ygmYfKXJIDmVpVQi598apSoWYT/ltv+NXTALjyNIVvh5cLRz8YxoF sFI2VpZ5PMrr1qo+DB1AbH00b0l2W7HGetSH8gcgpc7q3kCObmDSa3aTGTkawNHzbceEJrL6 mRD6GbjU4GPD06/dTRIhQatKgE4ekv5wnxBK6v9CVKViqpn7vIxiTI9/VtTKndzdnKE6C72+ jTwSYVa1vMxJABtOSg8AEQEAAYkCPAQYAQgAJgIbDBYhBHZUAzYClA3xkg/kA7UilbAzUDAf BQJexC4MBQkHfUOQAAoJELUilbAzUDAfPYoQAJdBGd9WZIid10FCoI30QXA82SHmxWe0Xy7h r4bbZobDPc7GbTHeDIYmUF24jI15NZ/Xy9ADAL0TpEg3fNVad2eslhCwiQViWfKOGOLLMe7v zod9dwxYdGXnNRlW+YOCdFNVPMvPDr08zgzXaZ2+QJjp44HSyzxgONmHAroFcqCFUlfAqUDO T30gV5bQ8BHqvfWyEhJT+CS3JJyP8BmmSgPa0Adlp6Do+pRsOO1YNNO78SYABhMi3fEa7X37 WxL31TrNCPnIauTgZtf/KCFQJpKaakC3ffEkPhyTjEl7oOE9xccNjccZraadi+2uHV0ULA1m ycHhb817A03n1I00QwLf2wOkckdqTqRbFFI/ik69hF9hemK/BmAHpShI+z1JsYT9cSs8D7wb aF/jQVy4URensgAPkgXsRiboqOj/rTz9F5mpd/gPU/IOUPFEMoo4TInt/+dEVECHioU3RRrW EahrGMfRngbdp/mKs9aBR56ECMfFFUPyI3VJsNbgpcIJjV/0N+JdJKQpJ/4uQ2zNm0wH/RU8 CRJvEwtKemX6fp/zLI36Gvz8zJIjSBIEqCb7vdgvWarksrhmi6/Jay5zRZ03+k6YwiqgX8t7 ANwvYa1h1dQ36OiTqm1cIxRCGl4wrypOVGx3OjCar7sBLD+NkwO4RaqFvdv0xuuy4x01VnOF Message-ID: Date: Mon, 22 Jun 2020 15:16:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org What do you think about removing duplicates warning from the rule? I mean this kind of warnings: "WARNING: same array_size (line {p1[0].line})" As for now, I think it's better to not disturb developers with this kind of things. Thanks, Denis >> +@as_dup@ >> +expression subE1 <= as.E1; >> +expression subE2 <= as.E2; >> +expression as.E1, as.E2, E3; >> +assignment operator aop; >> +position p1, p2; >> +@@ >> + >> +* array_size(E1, E2)@p1 >> + ... when != \(E1\|E2\|subE1\|subE2\) aop E3 >> + when != &\(E1\|E2\|subE1\|subE2\) >> +* array_size(E1, E2)@p2 >> + >> +@script:python depends on report@ >> +p1 << as_dup.p1; >> +p2 << as_dup.p2; >> +@@ >> + >> +coccilib.report.print_report(p2[0], >> +f"WARNING: same array_size (line {p1[0].line})") >> + >> +@script:python depends on org@ >> +p1 << as_dup.p1; >> +p2 << as_dup.p2; >> +@@ >> + >> +coccilib.org.print_todo(p2[0], >> +f"WARNING: same array_size (line {p1[0].line})") >> +