Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 22 Jun 2020 15:45:43 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Shiju Jose <shiju.jose@huawei.com>,
        James Morse <james.morse@arm.com>
Cc:     linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org, rjw@rjwysocki.net,
        helgaas@kernel.org, bp@alien8.de, lenb@kernel.org,
        tony.luck@intel.com, zhangliguang@linux.alibaba.com,
        andriy.shevchenko@linux.intel.com, wangkefeng.wang@huawei.com,
        jroedel@suse.de, linuxarm@huawei.com, yangyicong@hisilicon.com,
        jonathan.cameron@huawei.com, tanxiaofei@huawei.com
Subject: Re: [PATCH v11 0/2] ACPI / APEI: Add support to notify the vendor
 specific HW errors
Message-ID: <20200622124543.GV4282@kadam>
References: <20200622120527.690-1-shiju.jose@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200622120527.690-1-shiju.jose@huawei.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jun 22, 2020 at 01:05:25PM +0100, Shiju Jose wrote:
> CPER records describing a firmware-first error are identified by GUID.
> The ghes driver currently logs, but ignores any unknown CPER records.
> This prevents describing errors that can't be represented by a standard
> entry, that would otherwise allow a driver to recover from an error.
> The UEFI spec calls these 'Non-standard Section Body' (N.2.3 of
> version 2.8).
> 
> patch set
> 1. add a notifier chain for these non-standard/vendor-records
>    in the ghes driver.
> 
> 2. add a driver to handle HiSilicon hip PCIe controller's errors.
>    
> Changes:
> 
> V11:
> 1. Following modifications made by James Morse in the APEI patch
>    for the vendor error record.
>    - Removed kfifo and ghes_gdata_pool. Expanded commit message.
>    
>    Note: Kept the Signed-off-by: James Morse as he is given
>    because I am not sure the right format.

Wait, what?  He doesn't seem to have given any S-o-b in the public
thread.

Signed-off-by means that you handled a patch.  Presumably you are the
maintainer and hopefully you looked at the patch before applying it.
Signed-off-by is like signing a legal document to say that you didn't
add any Top Secrety SCO UNIXWare source code.  Reviewed-by means you
reviewed it and approve.  Acked-by means you approve the patch which
sort of means you are the maintainer or you care about it for some
reason, for example, maybe there was a debate and you like the chosen
approach.

regards,
dan carpenter