Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2763243ybt; Mon, 22 Jun 2020 06:30:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCzp3NZ9DkqYutqz8zCOuaAkRSjH3sY7Nx4+5J+7mchqxXmhfeavSChPsUGFStIhhwGzpA X-Received: by 2002:aa7:cd42:: with SMTP id v2mr16470736edw.360.1592832605132; Mon, 22 Jun 2020 06:30:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592832605; cv=none; d=google.com; s=arc-20160816; b=gMfiywljgFpOuuXmQ8A6bfsPxNsXmbkoKp0Ud/andwV0H0C5W8WgvhPKi0kTTOXno1 5sQ7fWhhJW1xx5XTYMjqYKZDCJWGX8/7vtDVlZoFWzasHSIeRD7bO4a4DbA9RhT8nulF O+XUio79RoZSv8HUHzPt1vz/pZiHfclKSV3eo9+yy03Mig3rtp8Gl+zQNcceu1CrvMA9 PjWtlJt38FWpbf0UOcYv8BfK0LFbcG3iycJYuMBkHUsE2ZpO7/jITafDZ6o+bAVOE/Qd vaZxWgvQr14Cant8Hiw3Ud6j3BfcdWXsXFnagA4Yki/LX3hjzqfsH+VnprzeyUimxHc0 IXfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ZDUlSn5jU53cp1tPLasRfOKgYW9o5ByHt6T8w7VHSbw=; b=uVo9N657UxNVfNjCTOMbzkcdQ9IE3XA2h0Y9ZDpH96f89h8Q/2cEtlQUuySMTgwQL4 km1qSYlxm0bUyoH7/3a9+yeRRrpGRWgf8zMASQNMbX97BEGWvPGV9Bt39obC0QO0vtCk G+BemWnwMV7w+wcCWMmUBi6CamOns+WBP2/EZBySvSH/MV4nDr+mtNa0zp0emOPgwQTf JHE+yn9OX78mD8nbqYipHLksuVZEI1z5ZFWGwwNXIeIuMRx1GOs8wtdA+PVievqfsXh8 uEytSO6TU/PESKCE+keM/dhLW9J6s8Xs9zF4eiYeTVBthhaFH+Aeo6TJrvx4WWMwxj+e KkEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b="UNo4j/9Z"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lu12si2947342ejb.269.2020.06.22.06.29.41; Mon, 22 Jun 2020 06:30:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b="UNo4j/9Z"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728920AbgFVNZd (ORCPT + 99 others); Mon, 22 Jun 2020 09:25:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727963AbgFVNZd (ORCPT ); Mon, 22 Jun 2020 09:25:33 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8943C061573; Mon, 22 Jun 2020 06:25:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZDUlSn5jU53cp1tPLasRfOKgYW9o5ByHt6T8w7VHSbw=; b=UNo4j/9Z7nm29li5UdbbUkY9c BXrIyp0PeDMrh6/1rXFa1s/DpyaYpRW5Lt9ksPHRtAqAdpZcTZZWWNtCMF8x40/5UTtYyHsykxjUF mm/gZ7W433GtXJ+Z2/zaXZOPGErm5Z2bOB10MbLP1Rb1ouo//+R5TzOhHSGabBxPvEXUinAyQkcCR byltfJLzMVgXau1qeBFwL69UWxbYxNxJY9Z4Ig4G++P8d6kFrTXSmtq6JrwslQlQPppJhcKXQ9vwF V/ZabrP5MxwiPCAIWb+si1ZrVfHlO4GeZGIi7xDcfy+s9yzfzTjSZln5pQX8JTfYkNeCtQjEg9X/H oaOBDhPZQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58964) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jnMRj-0000Fn-Nl; Mon, 22 Jun 2020 14:25:11 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jnMRd-00005S-0R; Mon, 22 Jun 2020 14:25:05 +0100 Date: Mon, 22 Jun 2020 14:25:04 +0100 From: Russell King - ARM Linux admin To: Bartosz Golaszewski Cc: Andrew Lunn , Florian Fainelli , Heiner Kallweit , "David S . Miller" , Jakub Kicinski , Rob Herring , Matthias Brugger , Microchip Linux Driver Support , Vladimir Oltean , Claudiu Manoil , Alexandre Belloni , Vivien Didelot , Tom Lendacky , Yisen Zhuang , Salil Mehta , Jassi Brar , Ilias Apalodimas , Iyappan Subramanian , Keyur Chudgar , Quan Nguyen , Frank Rowand , Philipp Zabel , Liam Girdwood , Mark Brown , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Fabien Parent , Stephane Le Provost , Pedro Tsai , Andrew Perepech , Bartosz Golaszewski Subject: Re: [PATCH 13/15] net: phy: mdio: add support for PHY supply regulator Message-ID: <20200622132504.GH1551@shell.armlinux.org.uk> References: <20200622093744.13685-1-brgl@bgdev.pl> <20200622093744.13685-14-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200622093744.13685-14-brgl@bgdev.pl> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 22, 2020 at 11:37:42AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Currently many MAC drivers control the regulator supplying the PHY but > this is conceptually wrong. The regulator should be defined as a property > of the PHY node on the MDIO bus and controlled by the MDIO sub-system. > > Add support for an optional PHY regulator which will be enabled before > optional deasserting of the reset signal. I wonder if this is the right place for this - MDIO devices do not have to be PHYs - they can be switches, and using "phy-supply" for a switch doesn't seem logical. However, I can see the utility of having having a supply provided for all mdio devices, so it seems to me to be a naming issue. Andrew? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!