Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200622053234.122120-1-hsinyi@chromium.org>
In-Reply-To: <20200622053234.122120-1-hsinyi@chromium.org>
From:   Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date:   Mon, 22 Jun 2020 22:19:07 +0800
Message-ID: <CAAOTY_-t2-uiuLCAUONkTdLt_h3gERRdadY+nS9ZXWF28t+VTQ@mail.gmail.com>
Subject: Re: [PATCH] drm/mediatek: check plane visibility in atomic_update
To:     Hsin-Yi Wang <hsinyi@chromium.org>
Cc:     Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Chun-Kuang Hu <chunkuang.hu@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        DRI Development <dri-devel@lists.freedesktop.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Yongqiang Niu <yongqiang.niu@mediatek.com>,
        Tomasz Figa <tfiga@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi, Hsin-Yi:

Hsin-Yi Wang <hsinyi@chromium.org> =E6=96=BC 2020=E5=B9=B46=E6=9C=8822=E6=
=97=A5 =E9=80=B1=E4=B8=80 =E4=B8=8B=E5=8D=881:32=E5=AF=AB=E9=81=93=EF=BC=9A
>
> Disable the plane if it's not visible. Otherwise mtk_ovl_layer_config()
> would proceed with invalid plane and we may see vblank timeout.

Except the Fixes tag,

Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>

>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
>  drivers/gpu/drm/mediatek/mtk_drm_plane.c | 23 +++++++++++++----------
>  1 file changed, 13 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/m=
ediatek/mtk_drm_plane.c
> index c2bd683a87c8..74dc71c7f3b6 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> @@ -164,6 +164,16 @@ static int mtk_plane_atomic_check(struct drm_plane *=
plane,
>                                                    true, true);
>  }
>
> +static void mtk_plane_atomic_disable(struct drm_plane *plane,
> +                                    struct drm_plane_state *old_state)
> +{
> +       struct mtk_plane_state *state =3D to_mtk_plane_state(plane->state=
);
> +
> +       state->pending.enable =3D false;
> +       wmb(); /* Make sure the above parameter is set before update */
> +       state->pending.dirty =3D true;
> +}
> +
>  static void mtk_plane_atomic_update(struct drm_plane *plane,
>                                     struct drm_plane_state *old_state)
>  {
> @@ -178,6 +188,9 @@ static void mtk_plane_atomic_update(struct drm_plane =
*plane,
>         if (!crtc || WARN_ON(!fb))
>                 return;
>
> +       if (!plane->state->visible)
> +               return mtk_plane_atomic_disable(plane, old_state);
> +
>         gem =3D fb->obj[0];
>         mtk_gem =3D to_mtk_gem_obj(gem);
>         addr =3D mtk_gem->dma_addr;
> @@ -200,16 +213,6 @@ static void mtk_plane_atomic_update(struct drm_plane=
 *plane,
>         state->pending.dirty =3D true;
>  }
>
> -static void mtk_plane_atomic_disable(struct drm_plane *plane,
> -                                    struct drm_plane_state *old_state)
> -{
> -       struct mtk_plane_state *state =3D to_mtk_plane_state(plane->state=
);
> -
> -       state->pending.enable =3D false;
> -       wmb(); /* Make sure the above parameter is set before update */
> -       state->pending.dirty =3D true;
> -}
> -
>  static const struct drm_plane_helper_funcs mtk_plane_helper_funcs =3D {
>         .prepare_fb =3D drm_gem_fb_prepare_fb,
>         .atomic_check =3D mtk_plane_atomic_check,
> --
> 2.27.0.111.gc72c7da667-goog
>