Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2861904ybt; Mon, 22 Jun 2020 08:49:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdwryYcg5MlKYKbUwbE7OzSru5kdHevSBJacDHjtJLIZwEwkozS/rAmw58JsGEeTE4zAQV X-Received: by 2002:a17:907:20ed:: with SMTP id rh13mr17296552ejb.135.1592840990156; Mon, 22 Jun 2020 08:49:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592840990; cv=none; d=google.com; s=arc-20160816; b=OGgzswW2olcReif5MW2GVl+GmomAs3w/KmXcDPKs1gnoTbMtTpZk+qu2/fZ62G7iNA LO9aT1J7OhSOuSfdEEP756stK+Zh0kN4zEoB+hQaU2TmWe/KouaO51HWWTEixi2OkcPf BQP/KfVCVDipNTRB9366dR7PBKYXbB6xE9x9c0jLVYexesD1EOPy0Le/2qx6zyAI4ReN GsT4rbPWSXcpfXs4iJuDhN6W0JNofP82sBkPRofK49oNlHeQQc/9p/By8YU4KK3/oKQ2 stq9vaiB/CGED8WWhHWVaCKry5bf3D1OG6Ge32dEZZcCllIQ0fuED4JtaPIN835oC+UI TMQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=F8T5mZjCR5K6UE+9mip6AsTcYlxfqPfxEDZRXo68qXg=; b=cTTI1qikJnbuabI9mZjmKnCPuPqv6LckPi43XwuL51YOABk0BPsQMAbLvigIqkUcGW lURaj+pGBkeOCJ2XlfLY4O9UbunVIARJGHraD3lvVDyjFE3TwVYQ7WfE2QTSWh9ZB8d4 Rky8uR0ftP9sCdtSLKJ37VO8jjhS4lZVmISd1vQqe0SKqJ9trUyAgrXqR2FBJgobwnpr JqoArd+D1D0ECVwqffOeCicvHOVjm/UFRLgupuLcSvvngVSSw/MNh5Lq5hTw1ivtPLzs sb/kwrJnz8PsSvE6AeeAicCW2nIGrL5LUYahFyplUNf1CrT21FPiiu2RrhwcfaUhkDL1 eypA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=URj6Gz7D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id do16si11400522ejc.166.2020.06.22.08.49.27; Mon, 22 Jun 2020 08:49:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=URj6Gz7D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729304AbgFVPrY (ORCPT + 99 others); Mon, 22 Jun 2020 11:47:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729250AbgFVPrX (ORCPT ); Mon, 22 Jun 2020 11:47:23 -0400 Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2103DC061573 for ; Mon, 22 Jun 2020 08:47:22 -0700 (PDT) Received: by mail-ed1-x544.google.com with SMTP id p18so14032498eds.7 for ; Mon, 22 Jun 2020 08:47:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=F8T5mZjCR5K6UE+9mip6AsTcYlxfqPfxEDZRXo68qXg=; b=URj6Gz7DCNjVsfGxAkO2DOJQ4lhP8RnWB1oBTpMB1v+b9ngI15iZSGpciCEHPwhRtm THavvnAHUL50ZpFzgz1EVT2okwJ6BeeZsAmcopLJMf5WZSkYA/QwaRG7z7H3s1k+eaJt EF3a5YtgqK/aV1lCOq+EjGrCWYUgoTtReCeLcXg7FKh05Qp1sNZubqrc5zQ2ZDlWfUTu AdbdhbrQpkW4BdEe8NFtAz6Y5DShUyx3KystsWglITp/okRj/QzsaCpNqC7cX1zVoc2L wiT0IjoCZxuJsPhLG88KnO5MoJdfND8u4agst1e7U+g4Tcv381/zETGmFcbfvKl3zUm0 NAUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=F8T5mZjCR5K6UE+9mip6AsTcYlxfqPfxEDZRXo68qXg=; b=Z5sAu0lCRHBoQXA8Nbj5f1rcQpmPUvx10dI1aAnl49bbdcpxikcI5af8baxy8/btyw hDjh7hOLxj+5iWJphE3Qo9a+tbftErWLV5bCOuWRaeWxknmuW66ccjytXrfIslwO0c0p ILmJNjR6GTvjOJyd1dXemAoVBoAK4pJDypxV1ZruOttzS0L03T7Vf2ICscWm3uecqNZP bfH8Q/X6dul8UBAdxbYQINtJ35gv2zTdQpAJHCeLap6Ev2UeyWt9M0/e0tnu/gAqLYLP k9EUWbxYfuAS1/JN0G0XLza87WWSgAws2vKAd8MiBB8sYaPEClm2d6WzIddv5h+fkIlL maXA== X-Gm-Message-State: AOAM531kiZehrj7kp0qVaunYP6bmzsbFqAvHo5zX49m0nymR+akTcytZ 08d/LbeyfRZ5YplmD/x9jbVK5Ac/ X-Received: by 2002:aa7:c790:: with SMTP id n16mr18225197eds.54.1592840840867; Mon, 22 Jun 2020 08:47:20 -0700 (PDT) Received: from localhost.localdomain ([2a02:a03f:b7f9:7600:74f4:a0e9:488b:65c7]) by smtp.gmail.com with ESMTPSA id s14sm4015599edq.36.2020.06.22.08.47.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2020 08:47:20 -0700 (PDT) From: Luc Van Oostenryck To: Masahiro Yamada Cc: linux-kernel@vger.kernel.org, Luc Van Oostenryck Subject: [PATCH] kbuild: run the checker after the compiler Date: Mon, 22 Jun 2020 17:45:12 +0200 Message-Id: <20200622154512.82758-1-luc.vanoostenryck@gmail.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since the pre-git time the checker is run first, before the compiler. But if the source file contains some syntax error, the warnings from the compiler are more useful than those from sparse (and other checker most probably too). So move the 'check' command to run after the compiler. Signed-off-by: Luc Van Oostenryck --- scripts/Makefile.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/Makefile.build b/scripts/Makefile.build index 2e8810b7e5ed..7ba6a752d5bd 100644 --- a/scripts/Makefile.build +++ b/scripts/Makefile.build @@ -252,9 +252,9 @@ cmd_gen_ksymdeps = \ endif define rule_cc_o_c - $(call cmd,checksrc) $(call cmd_and_fixdep,cc_o_c) $(call cmd,gen_ksymdeps) + $(call cmd,checksrc) $(call cmd,checkdoc) $(call cmd,objtool) $(call cmd,modversions_c) @@ -277,8 +277,8 @@ endif # Built-in and composite module parts $(obj)/%.o: $(src)/%.c $(recordmcount_source) $(objtool_dep) FORCE - $(call cmd,force_checksrc) $(call if_changed_rule,cc_o_c) + $(call cmd,force_checksrc) cmd_mod = { \ echo $(if $($*-objs)$($*-y)$($*-m), $(addprefix $(obj)/, $($*-objs) $($*-y) $($*-m)), $(@:.mod=.o)); \ base-commit: 48778464bb7d346b47157d21ffde2af6b2d39110 -- 2.27.0