Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2879134ybt; Mon, 22 Jun 2020 09:13:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyEGU5sb4gL7LYD40bd89BpDOH9ajLmr1qbw1iHz3KeVr+LRJnXzanscKjHxBx4TNaORumx X-Received: by 2002:a05:6402:129a:: with SMTP id w26mr18184600edv.41.1592842425195; Mon, 22 Jun 2020 09:13:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592842425; cv=none; d=google.com; s=arc-20160816; b=vlLGznZPsXNJep90G2k/Mu8hKydWfMjLQwZcO+7vl7HY8erVLxv15eNu93/5bB2P4h GIWTR1pCiLQNzTLX1+xqhldAWutZ11pU73i08sEyF7vKmWovIY0yJZlqoh1GcisTHt2U 7X2SjF0IxMQughNwKxVE2RBE44sNtkm91XyUM+5HDUQlDBj9qoSujILGARGY8tRsY+C2 GjeXNYNZQGOHEKgcrOGCFfVuKGImrsbuAzRaRVnbRUybMQQJ6niWmFtRUfSEbCICfmta NilQzDf2jXlFcB/uXHwppADGjHPyBdiJLTmTHTIkDbkyqPWbd6eFJjH/P2Br8zsRwBi1 IX1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=XMziTAReggV8cPAuUjcDsW9X5b6xE1JpK9TNborUBOU=; b=c3GJ5aGzw8V5E6mWfR9e8nVnm45iW4ftU1em3RlQn3ffGfxO7V2WRsnrXyUCiVvLYV WfhSs7uswgy5n0wLMudFbnfyMRR3EgHlCt4zLL1D8ENsVzznDJtz/9fRII2gT09OjNih N/+8ZjIZA3cNjuQozGHG3QJ8Ye/Mlc/4UEfyq70qakIlQ9dE0M/mZFvoDhZT9D3zMat1 IIi+voc6EqaQUkGKxg3bf6l160/0OJ40zOkWIvLIm5x7DEH9JeM9EJXEHQF2/aQanhdw UFyhZHBqRnBrB3Tppfux3jQ/0yyNUdtFWU9UvMIQFNuN+RVdwzYorXTs+FLkBJ3C1XWE BTGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MJhG8orP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a14si9093396ejj.334.2020.06.22.09.13.22; Mon, 22 Jun 2020 09:13:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MJhG8orP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729840AbgFVQJT (ORCPT + 99 others); Mon, 22 Jun 2020 12:09:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729390AbgFVQJP (ORCPT ); Mon, 22 Jun 2020 12:09:15 -0400 Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75DD6C061573; Mon, 22 Jun 2020 09:09:14 -0700 (PDT) Received: by mail-qk1-x741.google.com with SMTP id 80so4140978qko.7; Mon, 22 Jun 2020 09:09:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XMziTAReggV8cPAuUjcDsW9X5b6xE1JpK9TNborUBOU=; b=MJhG8orPav1AYK2ETOPNu4cBBY4tMHZVI/mufHGSHxANJrEwJoAsNA/0nDzK50VJ0m nOGHG5uR1AL7PAILE3fBokX3QWxK5USDt+PNZrSMkGOqrDSHfdP7D7nqX21BeBq/X+vJ 09OTdcMJ6FGLISfTaCz3OamgoCWCJ+f2Euc0Fb78/qKRUeQKKPospZhPMTjPM4h3yJ7L EdyObI4OScXAjCD9h8FAl59zF8wqnZkND516f9tZ24+NfWkvDgF/0vTb7Qev2hDtXN0j Q4wJQmWjhy1GulrO6+ZBVy+muwvq1dJIJpclDQLTLthByeVR5CESWm/IUk+uyg+Bs8eQ w7hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XMziTAReggV8cPAuUjcDsW9X5b6xE1JpK9TNborUBOU=; b=lJJir9p4AKxUToA1FSKy65bfaPMdop61y5lkgXpWarAT5Rbg+dEup6qw5g6Eahch7R 2MbaJ9ww7wpJvIfmNDxpYFi/SlowKPgpKzXvrSG6ivVWCBAh5Qhm78YdKGnTEZ0NwiBy GUtm4OwOtyvyFBEkzYGd2lDWepxPNwdYbEAoiOKsqCFdpx9bdOajfIBcEJ62N5V+2DbW YePYl+9iuNY/dsSpO+KxlX4Riv8OSslia92LfsAy6+s6YKR7Cbmhp05TAsJjrr2IUmd2 SRPu7o7GAytECJ+ewiwUKMBo9er4lMQ9hE4wTHWE90H0N9mYlP8NZAoo3IO4I5gG6C5/ wlyg== X-Gm-Message-State: AOAM533zqWVIeIB03HA+RByYgYR8s3KUOvul7kOpL/DtiqPsiDcX0azy /soCm1GuK97Ui7/xQBCWkS0dkmMkRXU= X-Received: by 2002:a05:620a:810:: with SMTP id s16mr16003595qks.360.1592842153712; Mon, 22 Jun 2020 09:09:13 -0700 (PDT) Received: from [192.168.1.46] (c-73-88-245-53.hsd1.tn.comcast.net. [73.88.245.53]) by smtp.gmail.com with ESMTPSA id s42sm15774713qtk.14.2020.06.22.09.09.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2020 09:09:12 -0700 (PDT) Subject: Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes To: Lee Jones , andy.shevchenko@gmail.com, michael@walle.cc, robh+dt@kernel.org, broonie@kernel.org, devicetree@vger.kernel.org, linus.walleij@linaro.org, linux@roeck-us.net, andriy.shevchenko@linux.intel.com, robin.murphy@arm.com, gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20200611191002.2256570-1-lee.jones@linaro.org> <20200622080913.GO954398@dell> From: Frank Rowand Message-ID: <3aa3c8ad-4e6a-9b9b-be58-bd9da5a0fb0a@gmail.com> Date: Mon, 22 Jun 2020 11:09:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200622080913.GO954398@dell> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-06-22 03:09, Lee Jones wrote: > On Thu, 11 Jun 2020, Lee Jones wrote: > >> Currently, when a child platform device (sometimes referred to as a >> sub-device) is registered via the Multi-Functional Device (MFD) API, >> the framework attempts to match the newly registered platform device >> with its associated Device Tree (OF) node. Until now, the device has >> been allocated the first node found with an identical OF compatible >> string. Unfortunately, if there are, say for example '3' devices >> which are to be handled by the same driver and therefore have the same >> compatible string, each of them will be allocated a pointer to the >> *first* node. > > Any more reviews/comments before I apply this? > Yes, outstanding issues, so please do not apply. Shortly after you sent this email, you sent a reply to one of my earlier emails in this thread. I have replied to that email, so we still have an ongoing conversation where we are trying to resolve my understanding of the problem and whether the solution is appropriate. -Frank