Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2907733ybt; Mon, 22 Jun 2020 09:56:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyio9AwoeBpt8sSOvRI8k8a54YdqbMgC3rrOvG4t34Eo2mzX2XYEYHmmTGx4vdswvrdcMcn X-Received: by 2002:a50:f985:: with SMTP id q5mr17622643edn.180.1592844993940; Mon, 22 Jun 2020 09:56:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592844993; cv=none; d=google.com; s=arc-20160816; b=m2UlxM/OhdKOW0wfW17LfZF+aVXGDR1MQoRbAVsDnPhzRZducXrZzXlKmdJq6qJD+D 2aPqBNF/CJNad+s9CVpWeyEjfxYHEL4e6Amj4BnLLRbI7l/IS0SBZ0Uy+WaISBkjsQC3 K5VbK9Ud7cfjhRXtAsrW9Q+jnZw5SkThPHsS0ojIRQI1+1REhtwF7rJlU5/jdcAzsqGP p/3yGVb9FZg6NQiLlOn92FzZFMulfoI8ifkHXpavkzAvGlyg2dssLLM6Z0LK7J3PmAMr fPqygLTpQm3Z4ihZkQgySpCVIboy/jH+CWod4iq0l9Csrh3vK3RHhqaCtb9dOtW1hQtw dwKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=th3lOsqDiHTH7KvlF9nPRZ/8Hlg8cxvCjLNOEG5r3bs=; b=SF9sOqfvmI0DMKIy7pPBnknLnyDmLa+nCJ5FOPTbi+wwbbeTvLvzIb9Jc+z+N3tUVq kanRelb2xAgATByhxEbzWEOhPXB0j/mcGxC7fFLBXFZa3AEX5BadYx/zlST8phti8FRj fE7gw52oTc6yncpR+8sT8TiNkpvX8Qe1/rBJQ1s28/dLh89KxaVLSSvkDCC5fiwK/ffm OtIpv2olyXVxl0HHdS7tLhHqpsVkgs0gRxR1svI2fQHdL+EYWNTR2JjRCJnGhKrNUhhV JMwURBlLmfHVZdwi/yQCTUj8mSMOXfxNUov05Ztw45w14zifcclk36wvtuI2WXO8AcoU KMPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uU1JG+eR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n9si9720446ejz.644.2020.06.22.09.56.11; Mon, 22 Jun 2020 09:56:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=uU1JG+eR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729777AbgFVQxX (ORCPT + 99 others); Mon, 22 Jun 2020 12:53:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729471AbgFVQxX (ORCPT ); Mon, 22 Jun 2020 12:53:23 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E105C061795 for ; Mon, 22 Jun 2020 09:53:23 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id r9so255738wmh.2 for ; Mon, 22 Jun 2020 09:53:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=th3lOsqDiHTH7KvlF9nPRZ/8Hlg8cxvCjLNOEG5r3bs=; b=uU1JG+eR6ofMtuoeMIi/sf0qt8/r0mBgInTU0iC8ITHEYCEERu2/q9EBHvKhJbQloP 49FNfT2YYnKkQ8ZH1s0MPZh1F2jI3Is/YciZfujF7PvXd3CxzK1sP01LwBxraZ6py3cb kPl/t164CPCS7kUsBMbB3okFfUD+at8msoQ2wPOtXlGmwPlV5hdMhrfaHxGHQKZ27GnX tJUMUNszS1Ilh7YM5jO6d/fmpcBLogLNDiNv0kQ9vKrkys3NXX8E0mwbVzvDQXItk+pw aXCT5dYUDlqfmMclsEuj8aRMdXxqhHZfbShHpv48N8PQpaczV667N3VnVsvH8yGt9Ma8 3wRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=th3lOsqDiHTH7KvlF9nPRZ/8Hlg8cxvCjLNOEG5r3bs=; b=nIdqqjawmJPCl+kAF3n42b8W2Sf4zwtqm7sMxzSuqpBNywsDA2/j4ytlXEzssthIOw yBDIv2MjatcFEaRNrdDdQJYurxKF+3tCJ9ucmpa/n28vvVZQw6ZCREXSHLvk2W+FD1PO T36SzPKXcP+W9c1UoTAWcYuUTEipkMkzOejfVS0z3TU2SGjJ5kFYGLaF4mvoZDjUs0o9 /LVO9lZ1wiVzVHrkHxEw/LcOC01lxwe2wtI450pd6DY6g0M9DKSogjOChxKBNbEeSQ/Y 0pnzURnmXQou+rnDm4H47LCEBF4ZPwchEzZB3kGNqtVllcCUVZUhuFbHLkS3Rygj7NlS Z0bw== X-Gm-Message-State: AOAM5339ymSbGH2S/wzX8mXnBdcY+Pm6M2lPIJZ4r50NJRUwfphhickr DpYh2CJ1VZp3eMMIeA+HA9Xnqg== X-Received: by 2002:a7b:c201:: with SMTP id x1mr19134419wmi.58.1592844801763; Mon, 22 Jun 2020 09:53:21 -0700 (PDT) Received: from dell ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x14sm18737824wrt.60.2020.06.22.09.53.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2020 09:53:21 -0700 (PDT) Date: Mon, 22 Jun 2020 17:53:19 +0100 From: Lee Jones To: Frank Rowand Cc: andy.shevchenko@gmail.com, michael@walle.cc, robh+dt@kernel.org, broonie@kernel.org, devicetree@vger.kernel.org, linus.walleij@linaro.org, linux@roeck-us.net, andriy.shevchenko@linux.intel.com, robin.murphy@arm.com, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] mfd: core: Make a best effort attempt to match devices with the correct of_nodes Message-ID: <20200622165319.GX954398@dell> References: <20200611191002.2256570-1-lee.jones@linaro.org> <20200622080913.GO954398@dell> <3aa3c8ad-4e6a-9b9b-be58-bd9da5a0fb0a@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3aa3c8ad-4e6a-9b9b-be58-bd9da5a0fb0a@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Jun 2020, Frank Rowand wrote: > On 2020-06-22 03:09, Lee Jones wrote: > > On Thu, 11 Jun 2020, Lee Jones wrote: > > > >> Currently, when a child platform device (sometimes referred to as a > >> sub-device) is registered via the Multi-Functional Device (MFD) API, > >> the framework attempts to match the newly registered platform device > >> with its associated Device Tree (OF) node. Until now, the device has > >> been allocated the first node found with an identical OF compatible > >> string. Unfortunately, if there are, say for example '3' devices > >> which are to be handled by the same driver and therefore have the same > >> compatible string, each of them will be allocated a pointer to the > >> *first* node. > > > > Any more reviews/comments before I apply this? > > > > Yes, outstanding issues, so please do not apply. > > Shortly after you sent this email, you sent a reply to one of my > earlier emails in this thread. I have replied to that email, > so we still have an ongoing conversation where we are trying > to resolve my understanding of the problem and whether the > solution is appropriate. Happy to discuss whatever issues you're having. Looks like the ball is in your court. :) -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog