Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2908540ybt; Mon, 22 Jun 2020 09:57:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzyFoLvKJwCoMqmF4EPlCFYjqvuXayk6U8Gij4q/Txi/Ly+Nj7rtkFk74+/adcFyaa3jVDu X-Received: by 2002:a17:906:2b92:: with SMTP id m18mr17627619ejg.218.1592845064211; Mon, 22 Jun 2020 09:57:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592845064; cv=none; d=google.com; s=arc-20160816; b=rGPHRJKhh9yfnNxb59tJlE7PUf6sOaUsfn653jHF7kOwLBTAyfp4Uwt2CDrMBAcuob PgldqMHFJKX1a/ljiXY0YhrzpywtqjEmGuCG52Eg83wAZiTmHF600kCj3XRf/F1wIRu9 cZ7m/pqG4ADvB6yRtPp3ZVO3RW/HqxBbwQIsp75SkrCHHY7CRXOHPZreBKw4itMnXBJp ULs2S4TQmggnNNzzNoKNimpEUvkLW81jCx+ZapK+v17eOg1L3pOEyLGGUx5p3NZbFKTI sthzqigIqeggmjr5MJjxSRGngsAYJPwo9QV530+HPARJ7yFVK+U0aTifNDhj+te9GXRM F3Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature; bh=CZTlvFAlNc3LWcrcr7dNgPmPbMuGi4M+XaNluNT5THU=; b=kbhJprqfoyomDZf9gGCUnZGL7PuR3y1tapLexdiBMusv34LFApPAa9Im15HoBE0pJc 5v+WxDWZlOcHjCf6ge1XfhHIyX6nfpvwgtDGcsmmtQsQpHCEwcfOLQosHf/zWv998F88 0z7HXMA61h1r6PHarU68N39y9ddiiDEDMDPj9DunFQbxfMCmViJF4DjminGs/BsipvKe Zxz/MyL6Cuw7RH4A+840lmoxVC16fcVvoR0CVGJGj7jBHILNYDXdjih8jaY3qRz8Edxz GP38gIe83iRW+MJLry5m0U8IISmBMwrYmKRAKkNYlTuq3s1Xz8DAZZxDiY0Mes2nfOXa P8RQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LAOZECfR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j17si9096065ejc.223.2020.06.22.09.57.21; Mon, 22 Jun 2020 09:57:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LAOZECfR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729837AbgFVQw6 (ORCPT + 99 others); Mon, 22 Jun 2020 12:52:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:58284 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729519AbgFVQw5 (ORCPT ); Mon, 22 Jun 2020 12:52:57 -0400 Received: from localhost (mobile-166-170-222-206.mycingular.net [166.170.222.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3CB7420707; Mon, 22 Jun 2020 16:52:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592844777; bh=t+IlrfZ0txrH96mjZ3AX99x53oPkQ0E7qqZlBrlngJI=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=LAOZECfRGx7DAOKstitrSP0q6DlJcu/eERuglIEQjVW8WGwmg5zZ/OIpUXPB+/zrH sQSBmCaBB55o5Tp/Y/FGXNl7r54HpgLlPm7aFLyDKsxjiVuPK/gsHWZQQwgMWsXzZW U3DK8OhlaePUrLFg0cG2NAElF+6II+P/T+2qfeEM= Date: Mon, 22 Jun 2020 11:52:55 -0500 From: Bjorn Helgaas To: Flavio Suligoi Cc: Tom Joseph , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/1] pci: controller: cadence: fix wrong path in comment Message-ID: <20200622165255.GA2275961@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200622091520.9336-1-f.suligoi@asem.it> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please use "git log --oneline" to help construct the subject line. Maybe: PCI: cadence-ep: Remove obsolete path from comment On Mon, Jun 22, 2020 at 11:15:20AM +0200, Flavio Suligoi wrote: > This comment still refers to the old driver pathname, > when all PCI drivers were located directly under the > drivers/pci directory. > > Anyway the function name itself is enough, so we can > remove the overabundant path reference. > > Signed-off-by: Flavio Suligoi > Acked-by: Bjorn Helgaas I did not ack this. Please don't add acks unless someone does so explicitly. > --- > > v1: - after the suggestion of Bjorn, remove the whole comment line related to > the wrong path > - add: Acked-by: Bjorn Helgaas > > drivers/pci/controller/cadence/pcie-cadence-ep.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/controller/cadence/pcie-cadence-ep.c b/drivers/pci/controller/cadence/pcie-cadence-ep.c > index 1c15c8352125..690eefd328ea 100644 > --- a/drivers/pci/controller/cadence/pcie-cadence-ep.c > +++ b/drivers/pci/controller/cadence/pcie-cadence-ep.c > @@ -276,7 +276,6 @@ static int cdns_pcie_ep_send_legacy_irq(struct cdns_pcie_ep *ep, u8 fn, u8 intx) > cdns_pcie_ep_assert_intx(ep, fn, intx, true); > /* > * The mdelay() value was taken from dra7xx_pcie_raise_legacy_irq() > - * from drivers/pci/dwc/pci-dra7xx.c > */ > mdelay(1); > cdns_pcie_ep_assert_intx(ep, fn, intx, false); > -- > 2.17.1 >