Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2909095ybt; Mon, 22 Jun 2020 09:58:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwApSdhVb/LM/mfJirfym8c98enfmTyxYO0CBl3nbhebzNJwS6iugHpTyeQ5mFjRamebtBZ X-Received: by 2002:a17:906:7212:: with SMTP id m18mr16508653ejk.29.1592845123598; Mon, 22 Jun 2020 09:58:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592845123; cv=none; d=google.com; s=arc-20160816; b=0bg2IWaJ5mOdsZMYTROhsrn2/oALwvotVxABZLE9NGpxoYC23Cj/ojkcoLFPfG96Bc TfaKLfUCDccuO96O5ZpBMJbQAAZYSKxSd5p+OcN3hrH2t6fkF7bkiHHUMMNJEtXTMqPw 9V90D9rMp7ZggmeiztYxbphAZDk27nO93s8s+/f0ye2d/3xmQBxo3b926ytMb31kc+n4 Nk2PkE0PGeOwP3T+ljQsDeD6/z95Nn2VYXIr/ztMGT/0TtbR/nsR/OaFAB3u7h+aqtAs db5dk27ohLRfiOWHri+YNmxShinuUFfUglNDDqjLMcH1eXt6nqXBu+Vy8vmzeroE5i8/ +W8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=U2Loxh0UBGoStu/YgkMRO85TtEfjsm65VCNYI1DGVpM=; b=yE+Cy61FlKAFtEmJCiiSelZg7OhU+yyCYjLYKO4m5h90R7Q7eBoSG6oHtGXQr0+qHb T+kAM3arO7EX91I1lZorJ5Za15QcTMCbr+6XgEfuN/tZ09p61BsjmAbHAJ2Qv+FmMFh2 tGXf53NH7eyiLC4anByAbD974E8DM4/w54Ul/+Ub7E/rsD0IAaT8Y1JTEv+xee5LzlBV XlRrpnQ/R9+NfWkHG6F646bJmbJuKmHq5i39TKr6iKAOJFCHt98KoFegLpZ76J6p/BHI ghMXzdq2bxc0A8roaDonFb3+cIEivAWFa+pOeas3yLThmw88CjRQkuuVLCDRp4KV1hLx YTHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=hBbGeGzL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a9si10847406edm.76.2020.06.22.09.58.21; Mon, 22 Jun 2020 09:58:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=hBbGeGzL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729865AbgFVQyS (ORCPT + 99 others); Mon, 22 Jun 2020 12:54:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729648AbgFVQyR (ORCPT ); Mon, 22 Jun 2020 12:54:17 -0400 Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FABAC061796 for ; Mon, 22 Jun 2020 09:54:17 -0700 (PDT) Received: by mail-qt1-x843.google.com with SMTP id d27so13165287qtg.4 for ; Mon, 22 Jun 2020 09:54:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=U2Loxh0UBGoStu/YgkMRO85TtEfjsm65VCNYI1DGVpM=; b=hBbGeGzLTLBinyYmygP0QeLy0oQ2I6xRNrZUWldovLttIo6FHiqlFsCCneBCMwtu3b l+eesx3TqWWgSxl13iviJuwhWHwKLTn7AY8Is2/HdRql4/bKOtAaDyhKU0pudfhGb6hf vOBncZGzqJGUBX98xFFLXxeGqf8B1bZUTWawV79agKnkyFxjCy7Rx/4ZFOGzWsLkvJBY MlXWlf6wngLFVkq5RHRa/cCd2QQpyoaItKpMgrtNyi7xkZUfsovspyvQo28R97Guf7cf bz3cKl0CGfDrGP+HCW1T48Xk7Iz2QCCeVukYl1g3hzCWecOtEngG3CyZhXIMQPya+XkI S9hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=U2Loxh0UBGoStu/YgkMRO85TtEfjsm65VCNYI1DGVpM=; b=dK/QRn4cEyxXOxljg/IUhD6WswOd/TQdlBGzfNr0DMbJlRySwrr2oXiTZvEB/dQBdf 51oIchZtpzScFsVVgi9p8FOz19XN4E+s4kh/1aMeISlHl4aREgasLofpx6PNgpWuSvaa hRZSE9GAXAS6J1ByRdwgv0jjKup0RzJMixuxG3kQOr/jGAkmDPWWic/jJa90BsVgbR4b d37jxAPY5z881iSCQD5QqiTUqP2mHUxPZ74/nLuY2UrDA4KgYPi1+QNkrUcqVLy0EXv2 Y6vGmoz/5M0tTlpzuVCiUXUyv1wpGX6Ded4iDH9GXm8sz8ZRGchOkP25sUcHGXRR4SFY d/TA== X-Gm-Message-State: AOAM531//SBa3z6EAlElKd32L+sxweqWz+LZM2CiqS5fEjZZsNy6txHk rogkxnJxCC/FU6p805MfJI4j705xbixtUpsV3zuigA== X-Received: by 2002:ac8:23fb:: with SMTP id r56mr17439684qtr.197.1592844856891; Mon, 22 Jun 2020 09:54:16 -0700 (PDT) MIME-Version: 1.0 References: <20200617074023.30356-1-navid.emamdoost@gmail.com> In-Reply-To: From: Bartosz Golaszewski Date: Mon, 22 Jun 2020 18:54:06 +0200 Message-ID: Subject: Re: [PATCH v2] gpio: rcar: handle pm_runtime_get_sync failure case To: Geert Uytterhoeven Cc: Navid Emamdoost , Linus Walleij , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Navid Emamdoost , Qiushi Wu , Kangjie Lu , mccamant@cs.umn.edu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =C5=9Br., 17 cze 2020 o 09:43 Geert Uytterhoeven nap= isa=C5=82(a): > > On Wed, Jun 17, 2020 at 9:40 AM Navid Emamdoost > wrote: > > Calling pm_runtime_get_sync increments the counter even in case of > > failure, causing incorrect ref count. Call pm_runtime_put if > > pm_runtime_get_sync fails. > > > > Signed-off-by: Navid Emamdoost > > Reviewed-by: Geert Uytterhoeven > Is this stable material? Bart