Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2935426ybt; Mon, 22 Jun 2020 10:36:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy3OvJ8UGoD9rlN8KD7hq3r+Li3KY1j8gt1/OlCEiijX1d2S0ajHgPqsgCWuWyj3n/TQXgG X-Received: by 2002:a17:906:9147:: with SMTP id y7mr6844683ejw.399.1592847383758; Mon, 22 Jun 2020 10:36:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592847383; cv=none; d=google.com; s=arc-20160816; b=0Fp7e6Oe2/m/cNo5Kh0NOZm2lzkrw0GQYjLptKS/FMEXzFqNXXvh/Czx01fJcxSRWi lHMhWXW/VltU63jD0HnuH1xzCBC985suiVCPVqKzI0//BjCEhwZQyWlsc+PNoKpuUA5g JMubkTKr2zNTHgyS1EwAKlc1EN5zEQBrrGCk5BWDO1ishu7dE1KX4Zb9B9i+yXZ/q74N JwyA0sTC1q1zDqS3fCCHjRKF2PPbpDYbvPntkyrWhaCpF4lvZaA8qtBSs/o8XT5dkWBC EBc9GQHg4CR02SALYFuvOOX6ieViulJdzhg0jx7u9wi8LX906BbZ9zgneyqSaz/2abLr hYTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=qS8rlq857F7iYBSfMLLx4hHB6U15Rzq9z9mfZC7Kzmg=; b=1HsFhiKXh3Pxu0ApNf0mhDXDbrI8wdZSDOJRF6DZERyBLgQQnvd7oF4LSCKpiSPp4A TTNAHErVHdz8pw1+tBmlctBQWiCg5+DUEhtG/AiREDBxlKnoAg6cEZgjmhhD9PR3vm9G jrLBSv296i3cgs7icpeenOyik8qUMTy1Lpz8V9V3pr2auicu6ARvV7GPqt2vTZFk5IkD QficxMdVnOH9AMdoK/IpGiVVrC07SpKNGDdHYOcghp+hqDRwWbG8zc73F8ga73PO9HV0 wkKP4GepxWVNT7RMsNrdPX74sypYAL9P4Pkz1hOLE3E4zD1W5dbPxFubCRhlG7S4wGNa g2Bw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=I6DrtN0a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w15si10386399edf.467.2020.06.22.10.36.01; Mon, 22 Jun 2020 10:36:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=I6DrtN0a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730193AbgFVRdN (ORCPT + 99 others); Mon, 22 Jun 2020 13:33:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730122AbgFVRdN (ORCPT ); Mon, 22 Jun 2020 13:33:13 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC768C061573 for ; Mon, 22 Jun 2020 10:33:11 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id x18so20264545lji.1 for ; Mon, 22 Jun 2020 10:33:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qS8rlq857F7iYBSfMLLx4hHB6U15Rzq9z9mfZC7Kzmg=; b=I6DrtN0aEZ1W7G8qhKoDRvFtV8oR6SUv/fT89Zl+kYuExEWbeXrbKlekNYD8YjK+Re hGi2TPi7oDDzqdReS/8xUqBJI4sr7q8HWyWwIPVcQhLOm+rtNiQTpKq/qm7AePg7IHEI EsDHb5+NobzF/ucrDtFaRnWi0RW6vptXh0x+U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qS8rlq857F7iYBSfMLLx4hHB6U15Rzq9z9mfZC7Kzmg=; b=uP+u6npUpmRqcG7pbDdXjcDlKWrQaPyxxun20nLlUI4+SVHD+C7k+wety69NN7tsiJ q+tjnLbziPpP71VPsD7Cannc6TGlgnQczPq0U1eslF4ccgomjuKsza3Sk/+InqxL7sYA KJ0Y6XENNeOEBeZvpZl4Akn5O8nrSFay0CAULUaMwGwdZat7kZ62I7LpGn9rR77Oohev xc2mGbXasJCHnPu/2Mohl8Cf6ceuDdNkd+5lSXVOsf+61kPfpyp7rD0TtqOeCzJA73JX KdOXSrpr9pqQPqeK0107UmLpVU/WNkxBwLto49FxCM4mqS6t60wvMrHXXGNEdsyg4+2I 8kpA== X-Gm-Message-State: AOAM530zvMIGKCaxEC/nTsum45zKHpx4mrk7jx/W/BzTN1QP3Chok8NZ iPl+6wTDwy6hbPSaVNh4ozvWRqMXT3c= X-Received: by 2002:a2e:b5bc:: with SMTP id f28mr8834789ljn.394.1592847189251; Mon, 22 Jun 2020 10:33:09 -0700 (PDT) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com. [209.85.208.178]) by smtp.gmail.com with ESMTPSA id s18sm3292488ljj.63.2020.06.22.10.33.07 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2020 10:33:08 -0700 (PDT) Received: by mail-lj1-f178.google.com with SMTP id a9so20268143ljn.6 for ; Mon, 22 Jun 2020 10:33:07 -0700 (PDT) X-Received: by 2002:a2e:b5d7:: with SMTP id g23mr8590245ljn.70.1592847187519; Mon, 22 Jun 2020 10:33:07 -0700 (PDT) MIME-Version: 1.0 References: <20200622030222.1370098-1-Jason@zx2c4.com> <20200622133747.GD2850@glitch> <20200622171001.GF2850@glitch> In-Reply-To: <20200622171001.GF2850@glitch> From: Linus Torvalds Date: Mon, 22 Jun 2020 10:32:51 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] Revert "kernel/printk: add kmsg SEEK_CUR handling" To: Bruno Meneguele Cc: "Jason A. Donenfeld" , Petr Mladek , Linux Kernel Mailing List , Sergey Senozhatsky , Steven Rostedt , David Laight Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 22, 2020 at 10:10 AM Bruno Meneguele wrote: > > Although both options are pretty fine by me too, I "fear" (not really) > we can end up stacking special behavior interfaces, forcing userspace to > keep a "table of special case files". Personally, I prefer to return > something _valid_ to userspace rather than _fail_ with special meaning. Well, what's even worse if user space has to handle two different things just because behavior changed in different kernels.. So at some point "odd behavior" is much better than "odd behavior in two different ways".. Linus