Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] qla2xxx: Set NVME status code for failed NVME FCP request
To:     Daniel Wagner <dwagner@suse.de>, linux-scsi@vger.kernel.org
Cc:     Nilesh Javali <njavali@marvell.com>,
        GR-QLogic-Storage-Upstream@marvell.com,
        linux-kernel@vger.kernel.org
References: <20200604100745.89250-1-dwagner@suse.de>
From:   Himanshu Madhani <himanshu.madhani@oracle.com>
Organization: Oracle Corporation
Message-ID: <3bbe9686-acaa-ea4e-c14c-7d33fdf1d97c@oracle.com>
Date:   Mon, 22 Jun 2020 12:35:02 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0)
 Gecko/20100101 Thunderbird/68.9.0
MIME-Version: 1.0
In-Reply-To: <20200604100745.89250-1-dwagner@suse.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 6/4/20 5:07 AM, Daniel Wagner wrote:
> The qla2xxx driver knows when request was processed successfully or
> not. But it always sets the NVME status code to 0/NVME_SC_SUCCESS. The
> upper layer needs to figure out from the rcv_rsplen and
> transferred_length variables if the request was successfully. This is
> not always possible, e.g. when the request data length is 0, the
> transferred_length is also set 0 which is interpreted as success in
> nvme_fc_fcpio_done(). Let's inform the upper
> layer (nvme_fc_fcpio_done()) when something went wrong.
> 
> nvme_fc_fcpio_done() maps all non NVME_SC_SUCCESS status codes to
> NVME_SC_HOST_PATH_ERROR. There isn't any benefit to map the QLA status
> code to the NVME status code. Therefore, let's use NVME_SC_INTERNAL to
> indicate an error which aligns it with the lpfc driver.
> 
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
>   drivers/scsi/qla2xxx/qla_nvme.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
> index d66d47a0f958..fa695a4007f8 100644
> --- a/drivers/scsi/qla2xxx/qla_nvme.c
> +++ b/drivers/scsi/qla2xxx/qla_nvme.c
> @@ -139,11 +139,12 @@ static void qla_nvme_release_fcp_cmd_kref(struct kref *kref)
>   	sp->priv = NULL;
>   	if (priv->comp_status == QLA_SUCCESS) {
>   		fd->rcv_rsplen = le16_to_cpu(nvme->u.nvme.rsp_pyld_len);
> +		fd->status = NVME_SC_SUCCESS;
>   	} else {
>   		fd->rcv_rsplen = 0;
>   		fd->transferred_length = 0;
> +		fd->status = NVME_SC_INTERNAL;
>   	}
> -	fd->status = 0;
>   	spin_unlock_irqrestore(&priv->cmd_lock, flags);
>   
>   	fd->done(fd);
> 

Makes sense.

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

-- 
Himanshu Madhani                     Oracle Linux Engineering