Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2992282ybt; Mon, 22 Jun 2020 12:05:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxOhQXeRbS8uRCImmOQnbuajSRLZcIIe/v60N5KE+yl62oAs/BFHpENGsdNNcG+5VbGFqur X-Received: by 2002:a50:ee93:: with SMTP id f19mr17808345edr.256.1592852727812; Mon, 22 Jun 2020 12:05:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592852727; cv=none; d=google.com; s=arc-20160816; b=gzMs/oDXmzCa+VQN8z4uVOSburMQWefgqIJCjXWdNmtgexGHCHBxmvBV7b/Pp0/Yif 94WHJPnD3U4uyBzOU8MHq188oF/vfRvylUJxqgDWdmS9Z/krjXN8SrF6L4YqXHRR59zj fHyiuEVfDsjbzynbC8nXIAsthYANYY26R8Cbrimkvr2AQo7FVpK5NPO+nCZiT90RI1uW dFxsJbFIj6OqL5Rxcuud0X9oHEe6usnldmWo1kmXZEas2Xi7ynsj/1BswFoJkR5GiHyU mCsL4GhK7QpM3MEvzQdnACG3Ews5sYWk2sxM2AS12yCWWCyrsB3opHbZUuwEWytwu3G7 fThg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=YiIRvunMQtxeuGVgZ5L0inUxadC2P3BTm0K3sfiI6MM=; b=o2i4YznddGGe824KbF1jY86Iv/17/lJC0FVaJak1FakxPQD5mUMf/B1PIfmMIszgxw yxHw0xBikym+Uks4UzhiHfPX3grBU+FGB6PTBb4H72U5f7+a3Y83LJzRkHZ60LENE0Hp 6fw2Pc9kP7IFu1vd6gTWiYltibhP3/PPyDNt9jMVL5nU0aCEz060oocikESAR9huK4G8 nBHG7rF534ALLNsJUC569waxoFSD3+DYsoQKD6B8milbv5wXbjZtdVL/5zJvhcmuc2rx dSf4in/+XoLC1WEHgjswQdRObB8xPuEP1Bfv15dqq7uU5GQW2PLB3lPEKs9eH9k0sZ64 JB8g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dt7si8738783ejb.395.2020.06.22.12.05.04; Mon, 22 Jun 2020 12:05:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730602AbgFVTAd convert rfc822-to-8bit (ORCPT + 99 others); Mon, 22 Jun 2020 15:00:33 -0400 Received: from mail-oi1-f196.google.com ([209.85.167.196]:40195 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730584AbgFVTAa (ORCPT ); Mon, 22 Jun 2020 15:00:30 -0400 Received: by mail-oi1-f196.google.com with SMTP id t25so16597335oij.7; Mon, 22 Jun 2020 12:00:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Z59w5oiWxqTwMyQwuHYI8ey8CfTBnQaiPGy2tHrE1Oc=; b=kRY6YDHpfLQEAztOC4Ywab6ilMvAmuAuWiSaXVUn22uJIEJvwHqhtDAmO1fj9jbNyJ vz/LORpkiccAZOWYd5g8RUBpXOuoEbDEsbkt3YCI0M7Bwn2vhJenHHnJrhaasYTnEw+g xGiHdj0fKc+xPIPCLO8bqHQiW7QH8vQ9YZrA1WG5eIEoUKQJE3udQJp8zP2SQH110Wdm kiFl0W4FTpTaT8pj4AmDHWXXlaJ5A+OU+ee75dycJODC3q4AlZkiuI6Tjg5kIJD2XQXg E9gimX1+bDJO6XJCCAtxiApHioh2dJMfVkMZ/Yu7zOiDad9BownqzrWLcyogJZoFnO8O T40A== X-Gm-Message-State: AOAM532j3Dc4/LmfOzxI+9KevQH3wGW9+uFiueQ9yA+WoavbRng15CrH HAz13jDPsMWz5ExnrIZH6fu+ANYsR5O/Ww7HJRO2sA== X-Received: by 2002:aca:849:: with SMTP id 70mr13140333oii.153.1592852428711; Mon, 22 Jun 2020 12:00:28 -0700 (PDT) MIME-Version: 1.0 References: <20200617074023.30356-1-navid.emamdoost@gmail.com> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 22 Jun 2020 21:00:17 +0200 Message-ID: Subject: Re: [PATCH v2] gpio: rcar: handle pm_runtime_get_sync failure case To: Bartosz Golaszewski Cc: Navid Emamdoost , Linus Walleij , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Navid Emamdoost , Qiushi Wu , Kangjie Lu , mccamant@cs.umn.edu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bartosz, On Mon, Jun 22, 2020 at 6:54 PM Bartosz Golaszewski wrote: > śr., 17 cze 2020 o 09:43 Geert Uytterhoeven napisał(a): > > On Wed, Jun 17, 2020 at 9:40 AM Navid Emamdoost > > wrote: > > > Calling pm_runtime_get_sync increments the counter even in case of > > > failure, causing incorrect ref count. Call pm_runtime_put if > > > pm_runtime_get_sync fails. > > > > > > Signed-off-by: Navid Emamdoost > > > > Reviewed-by: Geert Uytterhoeven > > Is this stable material? No, it cannot happen anyway. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds