Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 22 Jun 2020 12:29:32 -0700
From:   Bjorn Andersson <bjorn.andersson@linaro.org>
To:     Stephen Boyd <swboyd@chromium.org>
Cc:     Maulik Shah <mkshah@codeaurora.org>, agross@kernel.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        dianders@chromium.org, rnayak@codeaurora.org, ilina@codeaurora.org,
        lsrao@codeaurora.org, john.stultz@linaro.org
Subject: Re: [PATCH] soc: qcom: rpmh-rsc: Set suppress_bind_attrs flag
Message-ID: <20200622192932.GV128451@builder.lan>
References: <1592808805-2437-1-git-send-email-mkshah@codeaurora.org>
 <159281658960.62212.15968925558324290917@swboyd.mtv.corp.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <159281658960.62212.15968925558324290917@swboyd.mtv.corp.google.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon 22 Jun 02:03 PDT 2020, Stephen Boyd wrote:

> Quoting Maulik Shah (2020-06-21 23:53:25)
> > rpmh-rsc driver is fairly core to system and should not be removable
> > once its probed. However it allows to unbind driver from sysfs using
> > below command which results into a crash on sc7180.
> 
> What is the crash? The world falls apart because rpmh APIs start
> referencing pointers that point to freed memory?
> 

Presumably the devm_of_platform_populate() will cause said drivers to be
dismantled as well - but I think it's safe to say that that code path
isn't well tested...

I've applied the patch, but would have preferred that some time was
spent to make sure that things are unloadable as well.

Regards,
Bjorn

> > 
> > echo 18200000.rsc > /sys/bus/platform/drivers/rpmh/unbind
> > 
> > Lets prevent unbind at runtime by setting suppress_bind_attrs flag.
> 
> Ok. But when the Android module brigade comes knocking they'll have to
> revert this change and solve this problem too. Have fun!
> 
> > 
> > Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
> > ---
> 
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>