Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 22 Jun 2020 17:06:43 -0400
From:   Tom Rini <trini@konsulko.com>
To:     "H. Peter Anvin" <hpa@zytor.com>
Cc:     ron minnich <rminnich@gmail.com>,
        lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Borislav Petkov <bp@suse.de>,
        Dominik Brodowski <linux@dominikbrodowski.net>
Subject: Re: [PATCH] initrd: Remove erroneous comment
Message-ID: <20200622210643.GN27801@bill-the-cat>
References: <20200619143056.24538-1-trini@konsulko.com>
 <CAP6exYJ64Hy9y3Dzh9Asrq8Y0oDWYk+tf4UAcasEc-ZxTY8DAw@mail.gmail.com>
 <20200622204034.GL27801@bill-the-cat>
 <2455d1e8-d6b4-760b-9a4c-0071c5ae986d@zytor.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="uOSyunOxC/kgwQjk"
Content-Disposition: inline
In-Reply-To: <2455d1e8-d6b4-760b-9a4c-0071c5ae986d@zytor.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--uOSyunOxC/kgwQjk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 22, 2020 at 01:48:45PM -0700, H. Peter Anvin wrote:
> On 2020-06-22 13:40, Tom Rini wrote:
> > On Mon, Jun 22, 2020 at 01:02:16PM -0700, ron minnich wrote:
> >=20
> >> The other thing you ought to consider fixing:
> >> initrd is documented as follows:
> >>
> >>         initrd=3D         [BOOT] Specify the location of the initial r=
amdisk
> >>
> >> for bootloaders only.
> >>
> >> UEFI consumes initrd from the command line as well. As ARM servers
> >> increasingly use UEFI, there may be situations in which the initrd
> >> option doesn't make its way to the kernel? I don't know, UEFI is such
> >> a black box to me. But I've seen this "initrd consumption" happen.
> >>
> >> Based on docs, and the growing use of bootloaders that are happy to
> >> consume initrd=3D and not pass it to the kernel, you might be better o=
ff
> >> trying to move to the new command line option anyway.
> >>
> >> IOW, this comment may not be what people want to see, but ... it might
> >> also be right. Or possibly changed to:
> >>
> >> /*
> >>  * The initrd keyword is in use today on ARM, PowerPC, and MIPS.
> >>  * It is also reserved for use by bootloaders such as UEFI and may
> >>  * be consumed by them and not passed on to the kernel.
> >>  * The documentation also shows it as reserved for bootloaders.
> >>  * It is advised to move to the initrdmem=3D option whereever possible.
> >>  */
> >=20
> > Fair warning, one of the other hats I wear is the chief custodian of the
> > U-Boot project.
> >=20
> > Note that on most architectures in modern times the device tree is used
> > to pass in initrd type information and "initrd=3D" on the command line =
is
> > quite legacy.
> >=20
> > But what do you mean UEFI "consumes" initrd=3D ?  It's quite expected t=
hat
> > when you configure grub/syslinux/systemd-boot/whatever via extlinux.conf
> > or similar with "initrd /some/file" something reasonable happens to
> > read that in to memory and pass along the location to Linux (which can
> > vary from arch to arch, when not using device tree).  I guess looking a=
t=20
> > Documentation/x86/boot.rst is where treating initrd=3D as a file that
> > should be handled and ramdisk_image / ramdisk_size set came from.  I do
> > wonder what happens in the case of ARM/ARM64 + UEFI without device tree.
> >=20
>=20
> UEFI plus the in-kernel UEFI stub is, in some ways, a "bootloader" in
> the traditional sense. It is totally fair that we should update the
> documentation with this as a different case, though, because it is part
> of the kernel tree and so the kernel now has partial ownership of the
> namespace.
>=20
> I suggest "STUB" for "in-kernel firmware stub" for this purpose; no need
> to restrict it to a specific firmware for the purpose of namespace
> reservation.

With a little bit of quick digging, yes, it would be good to document
and be very clear which things are reserved for (and how are treated by)
the in-kernel firmware stub or "kernel EFI stub" or whatever name is
best for drivers/firmware/efi/libstub/.  I forget the last time we tried
booting a linux kernel EFI stub rather than grub/etc over in U-Boot
under our EFI loader support but it's reasonable to expect that it work.
Thanks!

--=20
Tom

--uOSyunOxC/kgwQjk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAl7xHWMACgkQFHw5/5Y0
tyyZfgv/eEDRB+L1hz5xlufmmY/0pN8LuByKat4/WhG/wKO7NOtfRXsnfNANN1H8
TKPbLiweM8o8zT9X2E92nthgLFnQ083Za1r79USPOXo9+uhLml2GQYZjHBhgWYj8
ARmfbj/2AojbkBgIOnHFCvuodmWH/kC2HYriFYNlG5inb5eLLOk/Q+PxzzQq7fPI
UBzrfAKp896UuwZ4rZLJ0/TviC1iXNWR9oKEQ68Do81Li0fjddcR2trW/CPQffWt
O7+0Alewt2Ino4VvqM9Y1j/++7Ibnj2ft6nKfalBZ4ofcr6ahjsn5/p4zNu38ylA
8qcn1b0JNYorpRa3+yz2MWh+6M5ldY8GLJjl9UxSiINH5v7F/46gMy0uY9SS6Ift
oMVBMgYQrJU1wF9QcklbBApnor0WGNxdgydP/sHJZMAHTAlz/9uhgNplICmde4Sd
JxD2ByRWPoxp3DLIvXFzV31Iwv+koX9b/gsPaZhk5Xs6iiYD1LYrzc53HDudGEsf
EZMi8UC/
=bFgS
-----END PGP SIGNATURE-----

--uOSyunOxC/kgwQjk--