Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3098842ybt; Mon, 22 Jun 2020 15:07:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLGVQh7fczPVEjJoewTqGhpUvqCtntCdt1Yl53xDXbv80x8zyzQIoensAwgLPQ5qfZ+exj X-Received: by 2002:aa7:ca02:: with SMTP id y2mr18537741eds.106.1592863632191; Mon, 22 Jun 2020 15:07:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592863632; cv=none; d=google.com; s=arc-20160816; b=SDa4dYlbywdWjq2GBuFwKAZwebulfp1HYEwfuy1ieqCUfkyr+SASUK2Ikz3RFTeoI1 ZaPIJdcsdJtsFh/czxXPSs4AbAEJLkPJU/Ikeb9zKrMEmqF9EFbPmMWXLNogzTRXrcT2 XVHFdKo9pkO7QofVd3JORFL9FT9FGyjMH6T7nNeHiQ2DtwT8SYH0/65y9I3Djh0Wg3uS rfcilRn3y68jwdTKliOym0NBWy+cr7YF4+P4fyaR6kXjpvSUtpiHuBbcV4XmB8F5mSsT xKN1bOMar1jfGvgSlZkFb+9BlT+/LguCuOcoZLMdfrSQjFgfkUkBtgsKEB0tvRUaJ36Y iP6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=D9zKETShESnlmbV3mu0MXm27L6L0w57VJPQLcTIPbrk=; b=mlZfRvxqIdwm6xQ6t2pgU8cxb0wwDXTUsMB8ReCMvccLMrz9Gx+dwNV0SWwMtyMeXa o0nO/XU6epHHFgAK8jxrdf8NxID/g1tlA4U01ITIS3Jq4RloHYsJX60LQLUauq2wkzct V6q29FZEjWhgwf7K4NH9FzxLIT1lwXFPwnWv4YhI33q/MEP9CO7CErFABCYc8l+K7i8a wI4FLPCZpxb9KwPw5qe+Yoj4SSwQFK2OxrisahSIPuvsNFRjhEXRGD1h/F7NZvU9zQ5o adILnScDw8AoRxb40cf4kCJdRRiuMgv/+1Wat+A/gW93KkfNwxZ8X+6YXwW7WAo/G9hm HG6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="bNCQ3/cn"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id de28si9431367edb.492.2020.06.22.15.06.49; Mon, 22 Jun 2020 15:07:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="bNCQ3/cn"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730927AbgFVWEv (ORCPT + 99 others); Mon, 22 Jun 2020 18:04:51 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:39137 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730794AbgFVWEu (ORCPT ); Mon, 22 Jun 2020 18:04:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592863489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=D9zKETShESnlmbV3mu0MXm27L6L0w57VJPQLcTIPbrk=; b=bNCQ3/cnaPQ11zk3dqoQnHvKwmyBrrPHQL2KW4BbrAcZmDuLmXkTNNAmNxoQf8jNkZAPpQ JrrDZy4GJynpNfEUXftQrZdh/x88EXxKuv9HAkVUkm58SBrCKUIEm2qQgAqV0LtoXy7vIg 7qsU/6S3jiBtoXT0E849sHJx3vU7KL4= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-20-M-_Z7ItjPkmu6VOqRarj-w-1; Mon, 22 Jun 2020 18:04:47 -0400 X-MC-Unique: M-_Z7ItjPkmu6VOqRarj-w-1 Received: by mail-qk1-f199.google.com with SMTP id i62so4787263qkd.18 for ; Mon, 22 Jun 2020 15:04:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=D9zKETShESnlmbV3mu0MXm27L6L0w57VJPQLcTIPbrk=; b=lhEbcWObxtcQGmzvFA+Dz78nnEvrtM0LLijJDVpeya1e4d7/BuEPp7msDgEMohzhlv +yZe/XSnKOws+QDelphFmhfquWmT0fZuTX7Tax5Ke/DyOX/3RN4c5+gy6zDIUhz/8F6f 3JLt/XIRcoty8JA/BAWXn/Fy9Oo4s+w04hxQ29bBNbJPSYf5SxWcbRHjcnep11FS6xgB JTyYMsuhMwU17LgT6yWg2zy3T752ilbRJqpjPb2x0p2lGYI6Z8Ekw4P+SMWQovhS5rDh C06kwz1Pzan3aLN0Jy9/UiJdujXjrtz93lTEifSy/z6/t0Jirmh362OSBlODLVYos0Bv vzaA== X-Gm-Message-State: AOAM533ka8T4e40QAHU0fYO3tj9p8WFedmE1yA7MI40S8LFcZHffhBXW YXs8dmypjGUwfxlLclKb4HKMRahW/eeFBkMe0sf5StvhWp4zeQiw7vOPK/TqI8df19pgKOkBKpG /6KsF/8cAcWF/Gj9f/8ei1qte X-Received: by 2002:ac8:39a5:: with SMTP id v34mr3750917qte.377.1592863486980; Mon, 22 Jun 2020 15:04:46 -0700 (PDT) X-Received: by 2002:ac8:39a5:: with SMTP id v34mr3750894qte.377.1592863486754; Mon, 22 Jun 2020 15:04:46 -0700 (PDT) Received: from xz-x1.redhat.com ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id h6sm3506810qtu.2.2020.06.22.15.04.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2020 15:04:45 -0700 (PDT) From: Peter Xu To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Sean Christopherson , Paolo Bonzini , peterx@redhat.com, Vitaly Kuznetsov Subject: [PATCH 0/2] KVM: X86: A few fixes around ignore_msrs Date: Mon, 22 Jun 2020 18:04:40 -0400 Message-Id: <20200622220442.21998-1-peterx@redhat.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently ignore_msrs and report_ignored_msrs have a few issues: - Errors could be dumped to dmesg even if the msr access is triggered inside kvm itself (e.g., kvm_cpuid), while what we really want to trap should be either guest msr accesses, or KVM_SET_MSRS. - These two parameters didn't apply to feature msrs. Each of the patch in this series tries to handle one of the issues. Here KVM_MSR_RET_INVALID is introduced. Ideally it can be an enum with both 0/1 defined too, but I'll see whether there's any feedback first about this version. This originates from a discussion between Paolo and me on an unexpected warning msr access message that triggered on a RT system, which seemed to have caused some system jitters. Please have a look, thanks. Peter Xu (2): KVM: X86: Move ignore_msrs handling upper the stack KVM: X86: Do the same ignore_msrs check for feature msrs arch/x86/kvm/svm/svm.c | 2 +- arch/x86/kvm/vmx/vmx.c | 2 +- arch/x86/kvm/x86.c | 90 +++++++++++++++++++++++++++++------------- arch/x86/kvm/x86.h | 2 + 4 files changed, 66 insertions(+), 30 deletions(-) -- 2.26.2