Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3145056ybt;
        Mon, 22 Jun 2020 16:28:54 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwSbt6kWlzMtdG3I2g+netD62gmU9ZGnoGhfiYpB1OiwUcAGlUdrkOj2uQYamnXbE6bxEOP
X-Received: by 2002:a05:6402:1ca2:: with SMTP id cz2mr18480464edb.15.1592868534747;
        Mon, 22 Jun 2020 16:28:54 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1592868534; cv=none;
        d=google.com; s=arc-20160816;
        b=cXcro44EvAl0SM+zR6DUVnOXy+BKvWlDA7yU2crCSxrIDOyA9Um9XAdueyanNKqkEu
         BHs+1+30o5sq5FzlJWvASulJ7c/IK3GR2eCasGMBHhOeBsAniGdhKdYh98ZKbU4T5WI/
         GCVdLVlM3N31TXU2/4yG3kQodmQSDQUYywhANZu4G0yYoPl1QkoSKom0LOLUHergoaCp
         DeDV5nWhUvWXJSNv0y47FfFdZ8LBe3CJmOrr0OFJDtiKKva8+Nw0ZkvMeczgmZww38n5
         hNnH/13PlaPvVnaXMGT84j0XWuttbnRQJrZBCqBOjDdYhURj/b6Z8QCoU4z89Dut8szV
         /9vg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=84q5yY6LYnxNqUORCFtB5L+rXvCQOMkQFWWuyLM+tZ0=;
        b=I3wkyx21CmtunaD7LfYTCdI2i69SGgoLmMkSY/fUkBkG9zyXXdqY7mlpwd53YmJgQm
         68HhZ5+1xjWY5LBP3yye81NCb/tQakxwbq5kOkFH2kwuyba2R1rliAasL46euDzEDfuj
         ejaUg3PiUqo6pZDyJWBTws10UbrfQ7XVGAq3uGAuZMWluqXFJZE5tIcDbLUVY1YZLW8A
         ozG62sgvKqoajSSQi97J8vsGlY9eE6zR76NmV8/54Pw1CL1xIasLTK7LluEAYB8wo2up
         Hdxhnq9hqFLcg7kCFyuu1EGrpFPxR/Wnn62jefsetHAQPBjHGs76DnVvQSWF+ipHSOwY
         LCVA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=XmS8lT0P;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id i7si11171364edb.116.2020.06.22.16.28.32;
        Mon, 22 Jun 2020 16:28:54 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=XmS8lT0P;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730250AbgFVUor (ORCPT <rfc822;tim.caudrey@gmail.com>
        + 99 others); Mon, 22 Jun 2020 16:44:47 -0400
Received: from mail.kernel.org ([198.145.29.99]:42554 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728421AbgFVUor (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 22 Jun 2020 16:44:47 -0400
Received: from kicinski-fedora-PC1C0HJN (unknown [163.114.132.1])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 741D62076A;
        Mon, 22 Jun 2020 20:44:46 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1592858686;
        bh=kS6Uoybp+uv0rgW5ZPADRgzJ/JhDOOrsBOC9xmxRys8=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=XmS8lT0PlQFUncpet6RPPNKJiTytxgchIQppj2jc87hagFVBEo+8Ql/sDjA93gw2V
         xppXiWF4HGNFdnANH9VrVtroo6KHFOiae3pLMuLElLUvR+1kWmdgBhcC1GTEZDN2mH
         Yikpwe2t+9MOfh2+wE9RxWptGDpvy8zmZqVX78Qk=
Date:   Mon, 22 Jun 2020 13:44:44 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Li Heng <liheng40@huawei.com>
Cc:     <vishal@chelsio.com>, <davem@davemloft.net>,
        <hariprasad@chelsio.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH resend] net: cxgb4: fix return error value in t4_prep_fw
Message-ID: <20200622134444.78f3fd74@kicinski-fedora-PC1C0HJN>
In-Reply-To: <1592621361-39925-1-git-send-email-liheng40@huawei.com>
References: <1592621361-39925-1-git-send-email-liheng40@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 20 Jun 2020 10:49:21 +0800 Li Heng wrote:
> t4_prep_fw goto bye tag with positive return value when something
> bad happened and which can not free resource in adap_init0.
> so fix it to return negative value.
> 
> Fixes: 16e47624e76b ("cxgb4: Add new scheme to update T4/T5 firmware")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Li Heng <liheng40@huawei.com>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

I don't remember signing off on this..