Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3176576ybt; Mon, 22 Jun 2020 17:28:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzouL4o769suJzKa0r/oqEr+ACGs7C8X3Q3mDcnX6K0nt97rjp7NtIL1PMyzpd8ST18HLWg X-Received: by 2002:a50:fc0d:: with SMTP id i13mr19178971edr.260.1592872085449; Mon, 22 Jun 2020 17:28:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592872085; cv=none; d=google.com; s=arc-20160816; b=1G/MFTZORyLLfBQT/oF2s5KdFc8s9ZY5r0qTyM32IQVG+m1kzgZf0DkJzpZPL8p9HG kRupYaM3Rej7G6HO144+sFd0P6naIqc57CdzFf6J/xN18LkWBgoyDHGUcntahr980O3F QtBN00Oif7nTqowwnt+BKEV0DVFO4O73Ut7FrrS7qmue+pfbdjdzYjsCkYNBL/lLwcqJ BT2n+i3hgKhrHbtW7fWjvKVTZzp4Fc/3+sKPeqxvUM8bEHDup3IWqcVaVNqKcE+Bona8 /Ur42Z/QIdJdmSq0tDmKmpvI1WoW8nTqGzxBgT0gUyemt9meB1al2jPT9pAz/NhniO9D kGKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=x6Go+1UdF8J5+q8/UVMFWuC8pcE5OHp5j85gRnFfBNM=; b=r+5hJRIB7HBGZ4f3OI03nwOpE+nAcz2CYjlQeBvLryv9I3nc5VDZQvvolQAIWc0l8s mjQWaYCq/VmFJv2AUPem0vLX8amKA7VY6t0turZSYlP2lK20tl/fCDcDY2268R09WgIX zlSw2+P+RosfO4dNqhucubVVhy8PETZjB6Fg2ultTNS2MEpI3f5mKbMcsXNb4tGa1aS3 hOVvbGuSC08jmjgs6eeSRLOLAHum1Cproh63KdJLX1cHk97zRf01OPGcOyjgVXwvnXx+ o+PZelWDj0RsJur0qzmUVWWAWpeRTyvIKQX6ckhoAYaoKGqon7PJaySbciaMTBMPaai5 pyhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UvTK9Bf9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g22si10449675eds.26.2020.06.22.17.27.43; Mon, 22 Jun 2020 17:28:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UvTK9Bf9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731773AbgFWAXE (ORCPT + 99 others); Mon, 22 Jun 2020 20:23:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:48280 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731524AbgFWAVw (ORCPT ); Mon, 22 Jun 2020 20:21:52 -0400 Received: from paulmck-ThinkPad-P72.home (50-39-105-78.bvtn.or.frontiernet.net [50.39.105.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 72DEC20809; Tue, 23 Jun 2020 00:21:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592871711; bh=iCKOvbCRfqkVczFsIKppK3kQNn2OlK2C2edwVd11wls=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UvTK9Bf9uANAh8kx4Yr3cThD+XvHhN/0pYIXS4WbTn+/tQwioQ9QGt3uYYBhuAM1T CdIFEcYSQQjoTuyRgCgA1NA8H9k3KvDhaBTfpaKrlWUyj+dbg9YbwjWOLvW2ht9+W7 KRHMQh3tflCZPfTQCTJuGCn3feKVV6T5zSFWMU88= From: paulmck@kernel.org To: rcu@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, joel@joelfernandes.org, "Paul E. McKenney" Subject: [PATCH tip/core/rcu 11/26] fs/btrfs: Add cond_resched() for try_release_extent_mapping() stalls Date: Mon, 22 Jun 2020 17:21:32 -0700 Message-Id: <20200623002147.25750-11-paulmck@kernel.org> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20200623002128.GA25456@paulmck-ThinkPad-P72> References: <20200623002128.GA25456@paulmck-ThinkPad-P72> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Paul E. McKenney" Very large I/Os can cause the following RCU CPU stall warning: RIP: 0010:rb_prev+0x8/0x50 Code: 49 89 c0 49 89 d1 48 89 c2 48 89 f8 e9 e5 fd ff ff 4c 89 48 10 c3 4c = 89 06 c3 4c 89 40 10 c3 0f 1f 00 48 8b 0f 48 39 cf 74 38 <48> 8b 47 10 48 85 c0 74 22 48 8b 50 08 48 85 d2 74 0c 48 89 d0 48 RSP: 0018:ffffc9002212bab0 EFLAGS: 00000287 ORIG_RAX: ffffffffffffff13 RAX: ffff888821f93630 RBX: ffff888821f93630 RCX: ffff888821f937e0 RDX: 0000000000000000 RSI: 0000000000102000 RDI: ffff888821f93630 RBP: 0000000000103000 R08: 000000000006c000 R09: 0000000000000238 R10: 0000000000102fff R11: ffffc9002212bac8 R12: 0000000000000001 R13: ffffffffffffffff R14: 0000000000102000 R15: ffff888821f937e0 __lookup_extent_mapping+0xa0/0x110 try_release_extent_mapping+0xdc/0x220 btrfs_releasepage+0x45/0x70 shrink_page_list+0xa39/0xb30 shrink_inactive_list+0x18f/0x3b0 shrink_lruvec+0x38e/0x6b0 shrink_node+0x14d/0x690 do_try_to_free_pages+0xc6/0x3e0 try_to_free_mem_cgroup_pages+0xe6/0x1e0 reclaim_high.constprop.73+0x87/0xc0 mem_cgroup_handle_over_high+0x66/0x150 exit_to_usermode_loop+0x82/0xd0 do_syscall_64+0xd4/0x100 entry_SYSCALL_64_after_hwframe+0x44/0xa9 On a PREEMPT=n kernel, the try_release_extent_mapping() function's "while" loop might run for a very long time on a large I/O. This commit therefore adds a cond_resched() to this loop, providing RCU any needed quiescent states. Signed-off-by: Paul E. McKenney --- fs/btrfs/extent_io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index 68c9605..7042395 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -4515,6 +4515,8 @@ int try_release_extent_mapping(struct page *page, gfp_t mask) /* once for us */ free_extent_map(em); + + cond_resched(); /* Allow large-extent preemption. */ } } return try_release_extent_state(tree, page, mask); -- 2.9.5