Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Mon, 22 Jun 2020 19:43:37 -0700
From:   rishabhb@codeaurora.org
To:     Bjorn Andersson <bjorn.andersson@linaro.org>
Cc:     linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
        tsoni@codeaurora.org, psodagud@codeaurora.org,
        sidgup@codeaurora.org, mathieu.poirier@linaro.org
Subject: Re: [v4 PATCH 0/3] Extend coredump functionality
In-Reply-To: <20200622222330.GN149351@builder.lan>
References: <1590611177-15826-1-git-send-email-rishabhb@codeaurora.org>
 <20200622222330.GN149351@builder.lan>
Message-ID: <d1eb275a572ac3e2979c6997daf5acf6@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020-06-22 15:23, Bjorn Andersson wrote:
> On Wed 27 May 13:26 PDT 2020, Rishabh Bhatnagar wrote:
> 
>> This patch series moves the coredump functionality to a separate
>> file and adds "inline" coredump feature. Inline coredump directly
>> copies segments from device memory during coredump to userspace.
>> This avoids extra memory usage at the cost of speed. Recovery is
>> stalled until all data is read by userspace.
>> 
>> Changelog:
>> 
> 
> Hi Rishabh,
> 
> This looks good to me, but it doesn't apply cleanly on linux-next. Can
> you please take a look?
> 
> Regards,
> Bjorn
> 
Yes some more gerrits have been merged in the meantime. I'll rebase on 
top
of Linux-next and send out another patchset.
>> v4 -> v3:
>> - Write a helper function to copy segment memory for every dump format
>> - Change segment dump fn to add offset and size adn covert mss driver
>> 
>> v3 -> v2:
>> - Move entire coredump functionality to remoteproc_coredump.c
>> - Modify rproc_coredump to perform dump according to conf. set by 
>> userspace
>> - Move the userspace configuration to debugfs from sysfs.
>> - Keep the default coredump implementation as is
>> 
>> v2 -> v1:
>> - Introduce new file for coredump.
>> - Add userspace sysfs configuration for dump type.
>> 
>> Rishabh Bhatnagar (3):
>>   remoteproc: Move coredump functionality to a new file
>>   remoteproc: Add inline coredump functionality
>>   remoteproc: Add coredump debugfs entry
>> 
>>  drivers/remoteproc/Makefile              |   1 +
>>  drivers/remoteproc/qcom_q6v5_mss.c       |   9 +-
>>  drivers/remoteproc/remoteproc_core.c     | 191 ------------------
>>  drivers/remoteproc/remoteproc_coredump.c | 328 
>> +++++++++++++++++++++++++++++++
>>  drivers/remoteproc/remoteproc_debugfs.c  |  86 ++++++++
>>  drivers/remoteproc/remoteproc_internal.h |   4 +
>>  include/linux/remoteproc.h               |  21 +-
>>  7 files changed, 443 insertions(+), 197 deletions(-)
>>  create mode 100644 drivers/remoteproc/remoteproc_coredump.c
>> 
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
>> Forum,
>> a Linux Foundation Collaborative Project
>>