Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3286982ybt; Mon, 22 Jun 2020 21:15:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3OlponAY0DzXzmi8+ZwSbWWQ13jQqLGSjj/HBJkq0N9Q1+b5dcFA2nkQn3MqrYWb4siRs X-Received: by 2002:a05:6402:3106:: with SMTP id dc6mr19547305edb.375.1592885719543; Mon, 22 Jun 2020 21:15:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592885719; cv=none; d=google.com; s=arc-20160816; b=m1FSx8WGQ4rIJaslldQngF7zFdFUsa7z0bGw5g6cLaHb9uiWpYlcE89jL3DUl7HhX0 3gAopQ8JCPW/p5qYUs3P0qGhUHrWpOi5yp9Hk4crtRd4lOMxciv76JaVMet4RYs+XWxu C4XmDa1tjB9nG0EF99KqKDrk2rVzGA2Z63Nzy204xHlkFL/S+3NqTixpXLVnjmuMVV+U ALG4K3tcgzNJHSF5Co/DFEBBvttIp6INQXS6XzwYnUci/Eu/7eWOQXmJhjRmVq3ky9Pc X70UQO2QZRwe3sHTCxbVjwYYSWGfE2Js8/7jzqpe9QwsLPmg6m9G0mhw3IMEvHDyFCEX ne8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=mv8fpARqu3lji8M5/uXJdQHFtDF893EsJNB3F97WKyo=; b=pgGOC3BOwmfQi0Os06X2wOgjCAQiD7kXYmAEaygRT6usjwbzHtOMelLKAdkCbTkZBQ uydsSPaq5Axo7h9EU/VMLHy6Cz9q0fqFsd62PHyyCw9SrhNUC+sJ5h8XNyeO9zxVNZRf /Nqrdtb03s4BgcLdCqMgpaOIMaZl21gWpH0MduNvAC0prQx+KnbSohVcNvla5KYVKv7U kXfmJaeX7avgZz51VcnzFgTjA9XPC3c2R+OU10vmOjNcFtUoQFZ2mJeiKZJ/SOsxRnir qV/4c5DxwwGev77ymZfReHf73mfTPOsK6QAFT9NGLgPNvuTgWHNyVfFjzqkHvEK9n01R C09w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=h23TU+Uu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id vr3si10007269ejb.520.2020.06.22.21.14.51; Mon, 22 Jun 2020 21:15:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=h23TU+Uu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731158AbgFVWsU (ORCPT + 99 others); Mon, 22 Jun 2020 18:48:20 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:50615 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731022AbgFVWsU (ORCPT ); Mon, 22 Jun 2020 18:48:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592866099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mv8fpARqu3lji8M5/uXJdQHFtDF893EsJNB3F97WKyo=; b=h23TU+Uump2nrXq3RyJqNcpoaAbSj8WG5/HwnwjtZqKTemXlJjnAlzXy7lIz/Ixfbv9PVo JmgafsQhapSQUrWmRArnk6VA/pfyq72dCarRwRA0i22IuPkQsYV1lRcl8TJaXjq8HAAteq P8G+FPQwJh1Fq+XbIybzMk5kQHv4wJg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-395-KnK5czC2P66Zj4vRZH2CuQ-1; Mon, 22 Jun 2020 18:48:15 -0400 X-MC-Unique: KnK5czC2P66Zj4vRZH2CuQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AF2A18031CB; Mon, 22 Jun 2020 22:48:14 +0000 (UTC) Received: from treble (ovpn-112-215.rdu2.redhat.com [10.10.112.215]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2F2547168B; Mon, 22 Jun 2020 22:48:14 +0000 (UTC) Date: Mon, 22 Jun 2020 17:48:11 -0500 From: Josh Poimboeuf To: Gaurav Singh Cc: Peter Zijlstra , open list Subject: Re: [PATCH] [objtoo] fix memory leak in special_get_alts Message-ID: <20200622224811.ske5jxc3s32yhgsp@treble> References: <20200622020434.18159-1-gaurav1086@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200622020434.18159-1-gaurav1086@gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 21, 2020 at 10:04:34PM -0400, Gaurav Singh wrote: > Free alt before returning to avoid memory leak. > > Signed-off-by: Gaurav Singh Hi Gaurav, Since objtool is a short-lived (and performance sensitive) process, we don't care about memory leaks. In fact we intentionally don't fix them. -- Josh