Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3288003ybt; Mon, 22 Jun 2020 21:17:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzoEqg8WFafG8TfoaV3xZrttVt3EueFj7lOYpuUiV7coTvcVG/xn/XBA8afT96UO3BL14eU X-Received: by 2002:a50:ce45:: with SMTP id k5mr20473822edj.80.1592885835063; Mon, 22 Jun 2020 21:17:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592885835; cv=none; d=google.com; s=arc-20160816; b=iQLXUyRqn/aTVIFfQ3k5mtQB/wO+QWtfnOonh/ihYJGqR/ALI0LoEOlxScuiEXV84V 4VTgJMVJjG+9pw/8tzo4SusWyt5coRrVkZoirQADj76QucV+lEyZpOObVf3fGT321eae DMpgH+ZBXHaV707s80PTX9PzyVL1+XgMGrPKtGLId4h9faEp6WICv2flRBK7gfiZ4ykK skja5JxcnJsNrNvY0kgv/OM3UWR4BS7StERyOrmQWEp7PKmraIVv5BVXVipFQiF64B2b Le4j6AjWSAFRaczQCzYJ6FPagFzpR5zyOz5aedLGH0gCSMPVsOkCBF2RwJ+yWi4O+6rM rq9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=n2dfCRjsqGMDaoIpxJkLhC84AzkkzCQ2Io5ieSahPLQ=; b=nIx8zfwAq0zz6p6pPNn6aiYCuRmRaElwodooxoDNmAH6X/hkdzldkcovck5u+DSypi yFtugvIwCAMYOzMnYZWGEdNnfe46ogOVwi63uw6gkIKR096BiPQ+6o+qj3MjaStNnNP2 0+Lq+yxzudufuwLe6y02judHoMKD5LuhCcXvhiOd1SOPV48hNZAyCsh5vHECnhm5z4q0 sjWgmP3xczFDIT3dybZ6Qv1+LYQJFNGJkr7ILNOLzlzN8P7/XIM8wsKApYXDPtyjUdY7 o//CTuTLJf6zblo95qpXPs/DDf94QkKvoybKJ+WkR3a8iNHzgWI7XwMB91vOdZjozC/k NMTg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dm7si5060790edb.43.2020.06.22.21.16.53; Mon, 22 Jun 2020 21:17:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731330AbgFWDfW (ORCPT + 99 others); Mon, 22 Jun 2020 23:35:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728526AbgFWDfV (ORCPT ); Mon, 22 Jun 2020 23:35:21 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 864D2C061573; Mon, 22 Jun 2020 20:35:21 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 7AD43120F93F8; Mon, 22 Jun 2020 20:35:19 -0700 (PDT) Date: Mon, 22 Jun 2020 20:35:16 -0700 (PDT) Message-Id: <20200622.203516.1857672250009821997.davem@davemloft.net> To: christian.brauner@ubuntu.com Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, arnd@arndb.de, guoren@kernel.org, linux-csky@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH 02/17] sparc64: enable HAVE_COPY_THREAD_TLS From: David Miller In-Reply-To: <20200622234326.906346-3-christian.brauner@ubuntu.com> References: <20200622234326.906346-1-christian.brauner@ubuntu.com> <20200622234326.906346-3-christian.brauner@ubuntu.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 22 Jun 2020 20:35:19 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christian Brauner Date: Tue, 23 Jun 2020 01:43:11 +0200 > diff --git a/arch/sparc/kernel/syscalls.S b/arch/sparc/kernel/syscalls.S > index db42b4fb3708..192f3a28a2b7 100644 > --- a/arch/sparc/kernel/syscalls.S > +++ b/arch/sparc/kernel/syscalls.S > @@ -86,19 +86,22 @@ sys32_rt_sigreturn: > * during system calls... > */ > .align 32 > -sys_vfork: /* Under Linux, vfork and fork are just special cases of clone. */ > - sethi %hi(0x4000 | 0x0100 | SIGCHLD), %o0 > - or %o0, %lo(0x4000 | 0x0100 | SIGCHLD), %o0 > - ba,pt %xcc, sys_clone > +sys_vfork: > + flushw > + ba,pt %xcc, sparc_vfork > + add %sp, PTREGS_OFF, %o0 Please indent branch delay slot instructions with one extra space, as was done in the code you are changing. > + ba,pt %xcc, sparc_fork > + add %sp, PTREGS_OFF, %o0 Likewise. > + ba,pt %xcc, sparc_clone > + add %sp, PTREGS_OFF, %o0 Likewise.